From: Cornelia Huck <cohuck@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: mst@redhat.com, linux-kernel@vger.kernel.org,
stable@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH] virtio_ring: fix num_free handling in error case
Date: Fri, 23 Feb 2018 13:47:26 +0100 [thread overview]
Message-ID: <20180223134726.3db96065.cohuck@redhat.com> (raw)
In-Reply-To: <20180223114130.16332-1-tiwei.bie@intel.com>
On Fri, 23 Feb 2018 19:41:30 +0800
Tiwei Bie <tiwei.bie@intel.com> wrote:
> The vq->vq.num_free hasn't been changed when error happens,
> so it shouldn't be changed when handling the error.
>
> Fixes: 780bc7903a32 ("virtio_ring: Support DMA APIs")
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> drivers/virtio/virtio_ring.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index eb30f3e09a47..71458f493cf8 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -428,8 +428,6 @@ static inline int virtqueue_add(struct virtqueue *_vq,
> i = virtio16_to_cpu(_vq->vdev, vq->vring.desc[i].next);
> }
>
> - vq->vq.num_free += total_sg;
> -
> if (indirect)
> kfree(desc);
>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
prev parent reply other threads:[~2018-02-23 12:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 11:41 [PATCH] virtio_ring: fix num_free handling in error case Tiwei Bie
2018-02-23 12:47 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223134726.3db96065.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mst@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tiwei.bie@intel.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).