From: Stephen Hemminger <stephen@networkplumber.org>
To: Siwei Liu <loseweigh@gmail.com>
Cc: Alexander Duyck <alexander.h.duyck@intel.com>,
virtio-dev@lists.oasis-open.org, Jiri Pirko <jiri@resnulli.us>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jakub Kicinski <kubakici@wp.pl>,
Sridhar Samudrala <sridhar.samudrala@intel.com>,
virtualization@lists.linux-foundation.org,
Netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework
Date: Tue, 10 Apr 2018 16:59:36 -0700 [thread overview]
Message-ID: <20180410165936.0faf9080@xeon-e3> (raw)
In-Reply-To: <CADGSJ22rVsC0TDTd6OKVnwbx0ExoQ8xWXBMumKB-OFH4sX=yaQ@mail.gmail.com>
On Tue, 10 Apr 2018 16:44:47 -0700
Siwei Liu <loseweigh@gmail.com> wrote:
> On Tue, Apr 10, 2018 at 4:28 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Tue, Apr 10, 2018 at 02:26:08PM -0700, Stephen Hemminger wrote:
> >> On Tue, 10 Apr 2018 11:59:50 -0700
> >> Sridhar Samudrala <sridhar.samudrala@intel.com> wrote:
> >>
> >> > Use the registration/notification framework supported by the generic
> >> > bypass infrastructure.
> >> >
> >> > Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
> >> > ---
> >>
> >> Thanks for doing this. Your current version has couple show stopper
> >> issues.
> >>
> >> First, the slave device is instantly taking over the slave.
> >> This doesn't allow udev/systemd to do its device rename of the slave
> >> device. Netvsc uses a delayed work to workaround this.
> >
> > Interesting. Does this mean udev must act within a specific time window
> > then?
>
> Sighs, lots of hacks. Why propgating this from driver to a common
> module. We really need a clean solution.
>
I had a patch to wait for udev to do the rename and go from there
but davem rejected it.
next prev parent reply other threads:[~2018-04-10 23:59 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1523386790-12396-1-git-send-email-sridhar.samudrala@intel.com>
[not found] ` <1523386790-12396-5-git-send-email-sridhar.samudrala@intel.com>
2018-04-10 21:26 ` [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework Stephen Hemminger
[not found] ` <20180410142608.50f15b45@xeon-e3>
2018-04-10 22:56 ` Samudrala, Sridhar
2018-04-10 23:28 ` Michael S. Tsirkin
[not found] ` <20180411022807-mutt-send-email-mst@kernel.org>
2018-04-10 23:44 ` Siwei Liu
[not found] ` <CADGSJ22rVsC0TDTd6OKVnwbx0ExoQ8xWXBMumKB-OFH4sX=yaQ@mail.gmail.com>
2018-04-10 23:59 ` Stephen Hemminger [this message]
2018-04-11 7:50 ` Jiri Pirko
2018-04-11 1:21 ` Michael S. Tsirkin
2018-04-11 7:53 ` Jiri Pirko
[not found] ` <20180411075334.GK2028@nanopsycho>
2019-02-22 1:14 ` net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework) Siwei Liu
[not found] ` <CADGSJ214RJV_zWVBGv0Ydo=CJj6WESTYAH=PpaYLFHdtWVrm3g@mail.gmail.com>
2019-02-22 1:39 ` Michael S. Tsirkin
[not found] ` <20190221203808-mutt-send-email-mst@kernel.org>
[not found] ` <581e4399-3969-aecd-e923-03bbc0880733@oracle.com>
2019-02-22 7:00 ` [virtio-dev] " Samudrala, Sridhar
[not found] ` <91d4cbb1-be7a-b53c-6b2a-99bef07e7c53@intel.com>
[not found] ` <d9ef40a2-237b-0cce-4401-ecaeac4c602a@oracle.com>
2019-02-22 15:14 ` Michael S. Tsirkin
[not found] ` <20190222100753-mutt-send-email-mst@kernel.org>
[not found] ` <e6a53bd1-83ab-f170-406a-03276e8c87e2@oracle.com>
2019-02-26 1:39 ` Stephen Hemminger
[not found] ` <20190225173912.26b93422@shemminger-XPS-13-9360>
2019-02-26 2:05 ` Michael S. Tsirkin
2019-02-26 2:08 ` Michael S. Tsirkin
[not found] ` <20190225210529-mutt-send-email-mst@kernel.org>
[not found] ` <d1060c75-eaba-ab6f-ff31-38cb3a47c711@oracle.com>
2019-02-27 21:57 ` Stephen Hemminger
2019-02-27 22:38 ` Michael S. Tsirkin
[not found] ` <20190227173710-mutt-send-email-mst@kernel.org>
[not found] ` <c72ce9eb-254c-cc3e-1969-f7f108506d5e@oracle.com>
2019-02-27 23:50 ` Michael S. Tsirkin
[not found] ` <20190227184601-mutt-send-email-mst@kernel.org>
2019-02-28 0:00 ` Liran Alon
2019-02-28 0:03 ` Stephen Hemminger
[not found] ` <20190227160342.788dc2b4@shemminger-XPS-13-9360>
2019-02-28 0:38 ` Michael S. Tsirkin
[not found] ` <a617ce13-4114-469d-ef33-a1c91150eeca@oracle.com>
2019-02-28 0:41 ` Michael S. Tsirkin
[not found] ` <20190227193923-mutt-send-email-mst@kernel.org>
2019-02-28 0:52 ` Jakub Kicinski
[not found] ` <20190227165205.307ed83c@cakuba.netronome.com>
2019-02-28 1:26 ` Michael S. Tsirkin
[not found] ` <20190227201857-mutt-send-email-mst@kernel.org>
2019-02-28 1:52 ` Jakub Kicinski
[not found] ` <20190227175218.736e13b6@cakuba.netronome.com>
2019-02-28 4:47 ` Michael S. Tsirkin
[not found] ` <20190227233812-mutt-send-email-mst@kernel.org>
2019-02-28 18:13 ` Jakub Kicinski
[not found] ` <20190228101356.39ac70aa@cakuba.netronome.com>
2019-02-28 19:36 ` Michael S. Tsirkin
[not found] ` <20190228143511-mutt-send-email-mst@kernel.org>
2019-02-28 19:56 ` Jakub Kicinski
[not found] ` <20190228115641.7afe6f09@cakuba.netronome.com>
2019-02-28 20:14 ` Michael S. Tsirkin
[not found] ` <20190228151349-mutt-send-email-mst@kernel.org>
2019-02-28 23:31 ` Jakub Kicinski
2019-03-01 0:20 ` Siwei Liu
[not found] ` <CADGSJ239j-fG_vifkj-gTnAb_RXtBEbnQCFdZGimcgPXh35CMA@mail.gmail.com>
2019-03-01 1:05 ` Jakub Kicinski
[not found] ` <20190228170520.527ed6df@cakuba.netronome.com>
2019-03-02 0:30 ` Siwei Liu
[not found] ` <36901346-e3d5-4e51-6a8d-678eb5b9e352@oracle.com>
2019-02-28 14:26 ` Michael S. Tsirkin
[not found] ` <20190228091119-mutt-send-email-mst@kernel.org>
[not found] ` <8a387954-1e21-947b-a5a9-c49adaea2e81@oracle.com>
2019-03-01 13:27 ` Michael S. Tsirkin
[not found] ` <1523386790-12396-3-git-send-email-sridhar.samudrala@intel.com>
2018-04-11 15:51 ` [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module Jiri Pirko
[not found] ` <20180411155127.GQ2028@nanopsycho>
2018-04-11 19:13 ` Samudrala, Sridhar
[not found] ` <6a8c1ff5-153a-e40a-91b3-48532b8d3a38@intel.com>
2018-04-18 9:25 ` Jiri Pirko
[not found] ` <20180418092515.GB1989@nanopsycho>
2018-04-18 18:43 ` Samudrala, Sridhar
[not found] ` <dd0d53f0-f5da-cb7d-f8f6-d0c8245eb3cf@intel.com>
2018-04-18 19:13 ` Jiri Pirko
[not found] ` <20180418191315.GA1922@nanopsycho>
2018-04-18 19:46 ` Michael S. Tsirkin
2018-04-18 20:32 ` Jiri Pirko
[not found] ` <20180418203206.GC1922@nanopsycho>
2018-04-18 22:46 ` Samudrala, Sridhar
2018-04-19 4:08 ` Michael S. Tsirkin
[not found] ` <ff0c5ea1-16d4-00a7-9952-9049efa818eb@intel.com>
2018-04-19 6:35 ` Jiri Pirko
[not found] ` <20180419070752-mutt-send-email-mst@kernel.org>
2018-04-19 7:22 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410165936.0faf9080@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=kubakici@wp.pl \
--cc=loseweigh@gmail.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox