From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-remoteproc@vger.kernel.org
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
virtualization@lists.linux-foundation.org,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: virtio remoteproc device
Date: Fri, 20 Apr 2018 19:53:55 +0300 [thread overview]
Message-ID: <20180420194321-mutt-send-email-mst@kernel.org> (raw)
Hello!
I note the following in the serial console:
if (is_rproc_serial(vdev)) {
/*
* Allocate DMA memory from ancestor. When a virtio
* device is created by remoteproc, the DMA memory is
* associated with the grandparent device:
* vdev => rproc => platform-dev.
*/
if (!vdev->dev.parent || !vdev->dev.parent->parent)
goto free_buf;
buf->dev = vdev->dev.parent->parent;
/* Increase device refcnt to avoid freeing it */
get_device(buf->dev);
buf->buf = dma_alloc_coherent(buf->dev, buf_size, &buf->dma,
GFP_KERNEL);
}
Added here:
commit 1b6370463e88b0c1c317de16d7b962acc1dab4f2
Author: Sjur Brændeland <sjur.brandeland@stericsson.com>
Date: Fri Dec 14 14:40:51 2012 +1030
virtio_console: Add support for remoteproc serial
I am not familiar with rproc so I have a question:
why is it required to use coherent memory here,
and why through a grandparent device?
Would it work to instead change vring_use_dma_api
to whitelist rproc (like we do for xen)?
I can sent a patch for your testing.
Thanks!
--
MST
next reply other threads:[~2018-04-20 16:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 16:53 Michael S. Tsirkin [this message]
2018-04-22 4:08 ` virtio remoteproc device Anup Patel
2018-04-23 8:55 ` Loic PALLARDY
2018-04-23 11:52 ` Michael S. Tsirkin
2018-04-23 19:40 ` Michael S. Tsirkin
2018-04-23 20:45 ` Loic PALLARDY
2018-04-23 21:02 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420194321-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).