From: Tiwei Bie <tiwei.bie@intel.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: mst@redhat.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
zhihong.wang@intel.com, pbonzini@redhat.com
Subject: Re: [RFC] virtio: support VIRTIO_F_IO_BARRIER
Date: Thu, 3 May 2018 21:26:47 +0800 [thread overview]
Message-ID: <20180503132647.yfulyzbygdfgu2or@debian> (raw)
In-Reply-To: <20180503090652.GB5301@stefanha-x1.localdomain>
On Thu, May 03, 2018 at 10:06:52AM +0100, Stefan Hajnoczi wrote:
> On Thu, May 03, 2018 at 10:59:55AM +0800, Tiwei Bie wrote:
> > This patch introduces the support for VIRTIO_F_IO_BARRIER.
> > When this feature is negotiated, driver will use the barriers
> > suitable for hardware devices.
> >
> > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
>
> I should have thought of this earlier, but why is a new feature bit
> necessary? If a hardware virtio device is in use, then the device
> should already negotiate VIRTIO_F_IOMMU_PLATFORM (i.e. use DMA APIs and
> IOMMU callbacks).
>
> Does disabling weak_barriers when VIRTIO_F_IOMMU_PLATFORM is set solve
> the problem?
The VIRTIO_F_IOMMU_PLATFORM feature can be set when the
device is implemented in software. And I think we don't
want the performance drop in this case.
Best regards,
Tiwei Bie
next prev parent reply other threads:[~2018-05-03 13:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180503025955.28816-1-tiwei.bie@intel.com>
2018-05-03 7:30 ` [RFC] virtio: support VIRTIO_F_IO_BARRIER Jason Wang
2018-05-03 8:30 ` Tiwei Bie
[not found] ` <20180503083015.kb7po26ga46g66tc@debian>
2018-05-03 9:09 ` Jason Wang
[not found] ` <1292c46c-34ad-ea21-1f05-164044a5f35a@redhat.com>
2018-05-03 9:58 ` Tiwei Bie
[not found] ` <20180503095823.zpxskdts7etpwl6x@debian>
2018-05-03 12:57 ` Jason Wang
2018-05-03 9:06 ` Stefan Hajnoczi
[not found] ` <20180503090652.GB5301@stefanha-x1.localdomain>
2018-05-03 13:26 ` Tiwei Bie [this message]
2018-05-03 13:50 ` Stefan Hajnoczi
2018-05-03 17:57 ` Michael S. Tsirkin
[not found] ` <20180503203108-mutt-send-email-mst@kernel.org>
2018-05-04 1:14 ` Tiwei Bie
2018-05-03 2:59 Tiwei Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503132647.yfulyzbygdfgu2or@debian \
--to=tiwei.bie@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox