Re: [PATCH v5 6/9] x86: prevent inline distortion by paravirt ops

Re: [PATCH v5 6/9] x86: prevent inline distortion by paravirt ops

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 4337 bytes --]

Hi Nadav,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.18-rc1 next-20180619]
[cannot apply to tip/x86/core]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Nadav-Amit/x86-macrofying-inline-asm-for-better-compilation/20180620-112043
config: i386-randconfig-x016-201824 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   arch/x86/include/asm/paravirt.h: Assembler messages:
>> arch/x86/include/asm/paravirt.h:253: Error: can't mix positional and keyword arguments
--
   arch/x86/include/asm/paravirt.h: Assembler messages:
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments
>> arch/x86/include/asm/paravirt.h:253: Error: can't mix positional and keyword arguments
   arch/x86/include/asm/paravirt.h:29: Error: can't mix positional and keyword arguments

vim +253 arch/x86/include/asm/paravirt.h

014b15be include/asm-x86/paravirt.h  Glauber de Oliveira Costa 2008-01-30  249  
014b15be include/asm-x86/paravirt.h  Glauber de Oliveira Costa 2008-01-30  250  static inline void write_gdt_entry(struct desc_struct *dt, int entry,
014b15be include/asm-x86/paravirt.h  Glauber de Oliveira Costa 2008-01-30  251  				   void *desc, int type)
f8822f42 include/asm-i386/paravirt.h Jeremy Fitzhardinge       2007-05-02  252  {
014b15be include/asm-x86/paravirt.h  Glauber de Oliveira Costa 2008-01-30 @253  	PVOP_VCALL4(pv_cpu_ops.write_gdt_entry, dt, entry, desc, type);
f8822f42 include/asm-i386/paravirt.h Jeremy Fitzhardinge       2007-05-02  254  }
014b15be include/asm-x86/paravirt.h  Glauber de Oliveira Costa 2008-01-30  255  

:::::: The code at line 253 was first introduced by commit
:::::: 014b15be30c04622d130946ab7c0a9101b523a8a x86: change write_gdt_entry signature.

:::::: TO: Glauber de Oliveira Costa <gcosta@redhat.com>
:::::: CC: Ingo Molnar <mingo@elte.hu>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33213 bytes --]

[-- Attachment #3: Type: text/plain, Size: 183 bytes --]

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v5 6/9] x86: prevent inline distortion by paravirt ops

[Peter Zijlstra]

On Tue, Jun 19, 2018 at 12:48:51PM -0700, Nadav Amit wrote:
> +#define paravirt_alt							\
> +	"PARAVIRT_CALL type=\"%c[paravirt_typenum]\""			\
> +	" clobber=\"%c[paravirt_clobber]\""				\
> +	" pv_opptr=\"%c[paravirt_opptr]\""

That wants to be:

+     " pv_opptr=\"%c[paravirt_opptr]\";"

And other than that I would suggest: 's/paravirt_alt/paravirt_call/g'.

Re: [PATCH v5 0/9] x86: macrofying inline asm for better compilation

[Peter Zijlstra]

On Tue, Jun 19, 2018 at 12:48:45PM -0700, Nadav Amit wrote:
> Nadav Amit (9):
>   Makefile: Prepare for using macros for inline asm
>   x86: objtool: use asm macro for better compiler decisions
>   x86: refcount: prevent gcc distortions
>   x86: alternatives: macrofy locks for better inlining
>   x86: bug: prevent gcc distortions
>   x86: prevent inline distortion by paravirt ops
>   x86: extable: use macros instead of inline assembly
>   x86: cpufeature: use macros instead of inline assembly
>   x86: jump-labels: use macros instead of inline assembly
> 
>  Makefile                               |  9 ++-
>  arch/x86/Makefile                      | 11 ++-
>  arch/x86/include/asm/alternative-asm.h | 20 ++++--
>  arch/x86/include/asm/alternative.h     | 11 +--
>  arch/x86/include/asm/asm.h             | 61 +++++++---------
>  arch/x86/include/asm/bug.h             | 98 +++++++++++++++-----------
>  arch/x86/include/asm/cpufeature.h      | 82 ++++++++++++---------
>  arch/x86/include/asm/jump_label.h      | 65 ++++++++++-------
>  arch/x86/include/asm/paravirt_types.h  | 56 +++++++--------
>  arch/x86/include/asm/refcount.h        | 74 +++++++++++--------
>  arch/x86/kernel/macros.S               | 16 +++++
>  include/asm-generic/bug.h              |  8 +--
>  include/linux/compiler.h               | 56 +++++++++++----
>  scripts/Kbuild.include                 |  4 +-
>  scripts/mod/Makefile                   |  2 +
>  15 files changed, 340 insertions(+), 233 deletions(-)
>  create mode 100644 arch/x86/kernel/macros.S

Aside from the one niggle:

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>