From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: [kbuild ack?] Re: [PATCH v6 0/9] x86: macrofying inline asm for better compilation Date: Sun, 15 Jul 2018 23:54:52 +0200 Message-ID: <20180715215452.GA14040@gmail.com> References: <20180622172212.199633-1-namit@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Nadav Amit Cc: Juergen Gross , Kate Stewart , Kees Cook , Josh Poimboeuf , Peter Zijlstra , Greg Kroah-Hartman , Christopher Li , X86 ML , Linux Kernel Mailing List , Philippe Ombredanne , "virtualization@lists.linux-foundation.org" , Masahiro Yamada , "linux-sparse@vger.kernel.org" , Ingo Molnar , Jan Beulich , "H. Peter Anvin" , Linus Torvalds , Thomas Gleixner , Sam Ravnborg , Alok Kataria List-Id: virtualization@lists.linuxfoundation.org * Nadav Amit wrote: > > I ran some limited number of benchmarks, and in general the performance > > impact is not very notable. You can still see >10 cycles shaved off some > > syscalls that manipulate page-tables (e.g., mprotect()), in which > > paravirt caused many functions not to be inlined. In addition this > > patch-set can prevent issues such as [1], and improves code readability > > and maintainability. Ok, that's good enough as a benefit, I suppose. > > Nadav Amit (9): > > Makefile: Prepare for using macros for inline asm This non-trivial kbuild patch needs an Acked-by from Masahiro. Thanks, Ingo