* Re: [PATCH] vhost/scsi: increase VHOST_SCSI_PREALLOC_PROT_SGLS to 2048 [not found] <20180808192955.1115-1-gedwards@ddn.com> @ 2018-08-08 20:42 ` Michael S. Tsirkin 2018-08-22 17:25 ` Greg Edwards 0 siblings, 1 reply; 2+ messages in thread From: Michael S. Tsirkin @ 2018-08-08 20:42 UTC (permalink / raw) To: Greg Edwards; +Cc: pbonzini, virtualization On Wed, Aug 08, 2018 at 01:29:55PM -0600, Greg Edwards wrote: > The current value of VHOST_SCSI_PREALLOC_PROT_SGLS is too small to > accommodate larger I/Os, e.g. 16-32 MiB, when the VIRTIO_SCSI_F_T10_PI > feature bit is negotiated and the backing store supports T10 PI. > > vhost-scsi rejects the command with errors like: > > [ 59.581317] vhost_scsi_calc_sgls: requested sgl_count: 1820 exceeds pre-allocated max_sgls: 512 > > Signed-off-by: Greg Edwards <gedwards@ddn.com> > --- > drivers/vhost/scsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c > index 17fcd3b2e686..8c32cf58d6fa 100644 > --- a/drivers/vhost/scsi.c > +++ b/drivers/vhost/scsi.c > @@ -56,7 +56,7 @@ > #define VHOST_SCSI_DEFAULT_TAGS 256 > #define VHOST_SCSI_PREALLOC_SGLS 2048 > #define VHOST_SCSI_PREALLOC_UPAGES 2048 > -#define VHOST_SCSI_PREALLOC_PROT_SGLS 512 > +#define VHOST_SCSI_PREALLOC_PROT_SGLS 2048 > > struct vhost_scsi_inflight { > /* Wait for the flush operation to finish */ I guess it's ok since PREALLOC_SGLS is already 2K ... or am I missing something. Paolo, any input on this? > -- > 2.17.1 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] vhost/scsi: increase VHOST_SCSI_PREALLOC_PROT_SGLS to 2048 2018-08-08 20:42 ` [PATCH] vhost/scsi: increase VHOST_SCSI_PREALLOC_PROT_SGLS to 2048 Michael S. Tsirkin @ 2018-08-22 17:25 ` Greg Edwards 0 siblings, 0 replies; 2+ messages in thread From: Greg Edwards @ 2018-08-22 17:25 UTC (permalink / raw) To: Michael S. Tsirkin; +Cc: pbonzini, virtualization On Wed, Aug 08, 2018 at 11:42:22PM +0300, Michael S. Tsirkin wrote: > On Wed, Aug 08, 2018 at 01:29:55PM -0600, Greg Edwards wrote: >> The current value of VHOST_SCSI_PREALLOC_PROT_SGLS is too small to >> accommodate larger I/Os, e.g. 16-32 MiB, when the VIRTIO_SCSI_F_T10_PI >> feature bit is negotiated and the backing store supports T10 PI. >> >> vhost-scsi rejects the command with errors like: >> >> [ 59.581317] vhost_scsi_calc_sgls: requested sgl_count: 1820 exceeds pre-allocated max_sgls: 512 >> >> Signed-off-by: Greg Edwards <gedwards@ddn.com> >> --- >> drivers/vhost/scsi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c >> index 17fcd3b2e686..8c32cf58d6fa 100644 >> --- a/drivers/vhost/scsi.c >> +++ b/drivers/vhost/scsi.c >> @@ -56,7 +56,7 @@ >> #define VHOST_SCSI_DEFAULT_TAGS 256 >> #define VHOST_SCSI_PREALLOC_SGLS 2048 >> #define VHOST_SCSI_PREALLOC_UPAGES 2048 >> -#define VHOST_SCSI_PREALLOC_PROT_SGLS 512 >> +#define VHOST_SCSI_PREALLOC_PROT_SGLS 2048 >> >> struct vhost_scsi_inflight { >> /* Wait for the flush operation to finish */ > > I guess it's ok since PREALLOC_SGLS is already 2K ... or > am I missing something. Paolo, any input on this? Ignore this patch. I believe I've identified the root cause [1], and will send out a new patch once I've done some more testing. Greg [1] https://www.spinics.net/lists/linux-scsi/msg122825.html ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-22 17:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180808192955.1115-1-gedwards@ddn.com>
2018-08-08 20:42 ` [PATCH] vhost/scsi: increase VHOST_SCSI_PREALLOC_PROT_SGLS to 2048 Michael S. Tsirkin
2018-08-22 17:25 ` Greg Edwards
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).