From: Peter Zijlstra <peterz@infradead.org>
To: Juergen Gross <jgross@suse.com>
Cc: rusty@rustcorp.com.au, x86@kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, mingo@redhat.com,
tglx@linutronix.de, hpa@zytor.com,
xen-devel@lists.xenproject.org, akataria@vmware.com,
boris.ostrovsky@oracle.com
Subject: Re: [PATCH v2 09/11] x86/paravirt: move the Xen-only pv_irq_ops under the PARAVIRT_XXL umbrella
Date: Fri, 24 Aug 2018 16:10:45 +0200 [thread overview]
Message-ID: <20180824141045.GO24124@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180813073739.26108-10-jgross@suse.com>
On Mon, Aug 13, 2018 at 09:37:37AM +0200, Juergen Gross wrote:
> Some of the paravirt ops defined in pv_irq_ops are for Xen PV guests
> only. Define them only if CONFIG_PARAVIRT_XXL is set.
> diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h
> index e652ec27d945..ae53ee36d8fb 100644
> --- a/arch/x86/include/asm/paravirt_types.h
> +++ b/arch/x86/include/asm/paravirt_types.h
> @@ -197,8 +197,10 @@ struct pv_irq_ops {
> struct paravirt_callee_save irq_disable;
> struct paravirt_callee_save irq_enable;
>
> +#ifdef CONFIG_PARAVIRT_XXL
> void (*safe_halt)(void);
> void (*halt)(void);
> +#endif
that makes me sad... but it appears VSMP also uses them. Can't you
simply make VSMP also select XXL, I don't think that's used quite as
much as Xen is :-)
next prev parent reply other threads:[~2018-08-24 14:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180813073739.26108-1-jgross@suse.com>
2018-08-13 7:37 ` [PATCH v2 01/11] x86/paravirt: make paravirt_patch_call() and paravirt_patch_jmp() static Juergen Gross
2018-08-13 7:37 ` [PATCH v2 02/11] x86/paravirt: remove clobbers parameter from paravirt patch functions Juergen Gross
2018-08-13 7:37 ` [PATCH v2 03/11] x86/paravirt: remove clobbers from struct paravirt_patch_site Juergen Gross
2018-08-13 7:37 ` [PATCH v2 04/11] x86/paravirt: use a single ops structure Juergen Gross
2018-08-13 7:37 ` [PATCH v2 05/11] x86/paravirt: remove unused paravirt bits Juergen Gross
2018-08-13 7:37 ` [PATCH v2 06/11] x86/paravirt: introduce new config option PARAVIRT_XXL Juergen Gross
2018-08-13 7:37 ` [PATCH v2 07/11] x86/paravirt: move items in pv_info under PARAVIRT_XXL umbrella Juergen Gross
2018-08-13 7:37 ` [PATCH v2 08/11] x86/paravirt: move the Xen-only pv_cpu_ops under the " Juergen Gross
2018-08-13 7:37 ` [PATCH v2 09/11] x86/paravirt: move the Xen-only pv_irq_ops " Juergen Gross
2018-08-13 7:37 ` [PATCH v2 10/11] x86/paravirt: move the Xen-only pv_mmu_ops " Juergen Gross
2018-08-13 7:37 ` [PATCH v2 11/11] x86/paravirt: remove unneeded mmu related paravirt ops bits Juergen Gross
2018-08-24 13:52 ` [PATCH v2 00/11] x86/paravirt: several cleanups Juergen Gross
[not found] ` <20180813073739.26108-2-jgross@suse.com>
2018-08-24 14:00 ` [PATCH v2 01/11] x86/paravirt: make paravirt_patch_call() and paravirt_patch_jmp() static Thomas Gleixner
[not found] ` <20180813073739.26108-3-jgross@suse.com>
2018-08-24 14:01 ` [PATCH v2 02/11] x86/paravirt: remove clobbers parameter from paravirt patch functions Thomas Gleixner
[not found] ` <20180813073739.26108-4-jgross@suse.com>
2018-08-24 14:03 ` [PATCH v2 03/11] x86/paravirt: remove clobbers from struct paravirt_patch_site Thomas Gleixner
[not found] ` <20180813073739.26108-10-jgross@suse.com>
2018-08-24 14:10 ` Peter Zijlstra [this message]
2018-08-24 14:13 ` [PATCH v2 09/11] x86/paravirt: move the Xen-only pv_irq_ops under the PARAVIRT_XXL umbrella Juergen Gross
[not found] ` <20180813073739.26108-11-jgross@suse.com>
2018-08-24 14:12 ` [PATCH v2 10/11] x86/paravirt: move the Xen-only pv_mmu_ops " Peter Zijlstra
2018-08-24 14:15 ` Juergen Gross
[not found] ` <45bfe8ab-683f-ab79-e3c6-c0a707b667c2@suse.com>
2018-08-24 14:13 ` [PATCH v2 00/11] x86/paravirt: several cleanups Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180824141045.GO24124@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akataria@vmware.com \
--cc=boris.ostrovsky@oracle.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox