* [PATCH] x86/paravirt: fix some warning messages
@ 2018-09-19 10:35 Dan Carpenter
2018-09-19 10:47 ` Juergen Gross
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2018-09-19 10:35 UTC (permalink / raw)
To: Juergen Gross, Peter Zijlstra
Cc: x86, kernel-janitors, virtualization, Ingo Molnar, H. Peter Anvin,
Alok Kataria, Thomas Gleixner
The first argument to WARN_ONCE() is a condition.
Fixes: 5800dc5c19f3 ("x86/paravirt: Fix spectre-v2 mitigations for paravirt guests")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c
index bbf006fe78d7..e4d4df37922a 100644
--- a/arch/x86/kernel/paravirt.c
+++ b/arch/x86/kernel/paravirt.c
@@ -89,7 +89,7 @@ static unsigned paravirt_patch_call(void *insnbuf, const void *target,
if (len < 5) {
#ifdef CONFIG_RETPOLINE
- WARN_ONCE("Failing to patch indirect CALL in %ps\n", (void *)addr);
+ WARN_ONCE(1, "Failing to patch indirect CALL in %ps\n", (void *)addr);
#endif
return len; /* call too long for patch site */
}
@@ -110,7 +110,7 @@ static unsigned paravirt_patch_jmp(void *insnbuf, const void *target,
if (len < 5) {
#ifdef CONFIG_RETPOLINE
- WARN_ONCE("Failing to patch indirect JMP in %ps\n", (void *)addr);
+ WARN_ONCE(1, "Failing to patch indirect JMP in %ps\n", (void *)addr);
#endif
return len; /* call too long for patch site */
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/paravirt: fix some warning messages
2018-09-19 10:35 [PATCH] x86/paravirt: fix some warning messages Dan Carpenter
@ 2018-09-19 10:47 ` Juergen Gross
0 siblings, 0 replies; 2+ messages in thread
From: Juergen Gross @ 2018-09-19 10:47 UTC (permalink / raw)
To: Dan Carpenter, Peter Zijlstra
Cc: x86, kernel-janitors, virtualization, Ingo Molnar, H. Peter Anvin,
Alok Kataria, Thomas Gleixner
On 19/09/18 12:35, Dan Carpenter wrote:
> The first argument to WARN_ONCE() is a condition.
>
> Fixes: 5800dc5c19f3 ("x86/paravirt: Fix spectre-v2 mitigations for paravirt guests")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-19 10:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-19 10:35 [PATCH] x86/paravirt: fix some warning messages Dan Carpenter
2018-09-19 10:47 ` Juergen Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).