From: Cornelia Huck <cohuck@redhat.com>
To: Halil Pasic <pasic@linux.ibm.com>
Cc: linux-s390@vger.kernel.org,
Colin Ian King <colin.king@canonical.com>,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [RFC PATCH 2/2] virtio/s390: fix race in ccw_io_helper()
Date: Thu, 20 Sep 2018 12:15:23 +0200 [thread overview]
Message-ID: <20180920121523.4177db92.cohuck@redhat.com> (raw)
In-Reply-To: <592b9fd1-0ab0-aa9f-31d7-a717610bd95c@linux.ibm.com>
On Wed, 19 Sep 2018 18:56:45 +0200
Halil Pasic <pasic@linux.ibm.com> wrote:
> On 09/19/2018 04:07 PM, Cornelia Huck wrote:
> > Do you spot any other places where we may need to care about concurrent
> > processing (like for the ->config area in the previous patch)?
> >
>
> It is hard to tell, because:
> * Synchronization external to the transport could make things work
> out just fine.
> * virtio_config_ops does not document these requirements if any.
> * So it's up to the devices to use the stuff without shooting
> themselves in the foot.
> * virtio-pci does not seem to do more to avoid such problems that
> we do.
>
> Back then when learning vritio-ccw I did ask myself such questions
> and based on vrito-pci and I was like looks similar, should be
> good enough.
Yep, I agree. If there's nothing obvious, I think we should just leave
it as it is now.
prev parent reply other threads:[~2018-09-20 10:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180912140202.12292-1-pasic@linux.ibm.com>
[not found] ` <20180912140202.12292-2-pasic@linux.ibm.com>
2018-09-18 18:29 ` [RFC PATCH 1/2] virtio/s390: avoid race on vcdev->config Cornelia Huck
[not found] ` <2f27c41d-4465-0fce-bbbb-b7b22a179eae@linux.ibm.com>
2018-09-19 11:28 ` Cornelia Huck
[not found] ` <20180912140202.12292-3-pasic@linux.ibm.com>
2018-09-18 18:45 ` [RFC PATCH 2/2] virtio/s390: fix race in ccw_io_helper() Cornelia Huck
[not found] ` <c0148f86-b7a5-0c66-146d-f2dbcd678436@linux.ibm.com>
2018-09-19 14:07 ` Cornelia Huck
[not found] ` <592b9fd1-0ab0-aa9f-31d7-a717610bd95c@linux.ibm.com>
2018-09-20 10:15 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920121523.4177db92.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=colin.king@canonical.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).