From: Cornelia Huck <cohuck@redhat.com>
To: Halil Pasic <pasic@linux.ibm.com>
Cc: linux-s390@vger.kernel.org,
Colin Ian King <colin.king@canonical.com>,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 2/2] virtio/s390: fix race in ccw_io_helper()
Date: Mon, 24 Sep 2018 15:32:57 +0200 [thread overview]
Message-ID: <20180924153257.24f367a4.cohuck@redhat.com> (raw)
In-Reply-To: <a55df275-d982-c051-1b17-465e3a30777f@linux.ibm.com>
On Mon, 24 Sep 2018 14:57:26 +0200
Halil Pasic <pasic@linux.ibm.com> wrote:
> On 09/21/2018 03:30 PM, Cornelia Huck wrote:
> > On Fri, 21 Sep 2018 14:46:21 +0200
> > Halil Pasic <pasic@linux.ibm.com> wrote:
> Again, not what I tried to say. By 'This' I meant 'this race'. How
> about?
>
> """
> This race normally does not cause any problems. The operations provided
> by struct virtio_config_ops are usually invoked in a well defined sequence,
> normally don't fail, and are normally usually quite infrequent too.
s/usually/used/
>
> Yet, if some of the these operations are directly triggered via
> sysfs attributes, like in the case described by the referenced bug,
> userspace is given an opportunity to force races by increasing the
> frequency of the given operations.
> """
Fine with me.
prev parent reply other threads:[~2018-09-24 13:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180921124621.43649-1-pasic@linux.ibm.com>
2018-09-24 11:52 ` [PATCH 0/2] virtio/s390: fix some races in virtio-ccw Christian Borntraeger
[not found] ` <20180921124621.43649-2-pasic@linux.ibm.com>
[not found] ` <20180921151433.519b6687.cohuck@redhat.com>
[not found] ` <d05aa6cb-d344-37dd-f1eb-55c28fcb9c62@linux.ibm.com>
[not found] ` <80a80dc6-ccb1-f245-b367-c2f9345ca151@linux.ibm.com>
2018-09-24 12:55 ` [PATCH 1/2] virtio/s390: avoid race on vcdev->config Cornelia Huck
[not found] ` <2b8982be-9066-cf08-657b-99ecf889e4a7@linux.ibm.com>
2018-09-24 14:50 ` Cornelia Huck
[not found] ` <20180921124621.43649-3-pasic@linux.ibm.com>
[not found] ` <20180921153031.77f7693b.cohuck@redhat.com>
[not found] ` <a55df275-d982-c051-1b17-465e3a30777f@linux.ibm.com>
2018-09-24 13:32 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924153257.24f367a4.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=colin.king@canonical.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).