From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH 2/2] virtio/s390: fix race in ccw_io_helper() Date: Mon, 24 Sep 2018 15:32:57 +0200 Message-ID: <20180924153257.24f367a4.cohuck@redhat.com> References: <20180921124621.43649-1-pasic@linux.ibm.com> <20180921124621.43649-3-pasic@linux.ibm.com> <20180921153031.77f7693b.cohuck@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Halil Pasic Cc: linux-s390@vger.kernel.org, Colin Ian King , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org On Mon, 24 Sep 2018 14:57:26 +0200 Halil Pasic wrote: > On 09/21/2018 03:30 PM, Cornelia Huck wrote: > > On Fri, 21 Sep 2018 14:46:21 +0200 > > Halil Pasic wrote: > Again, not what I tried to say. By 'This' I meant 'this race'. How > about? > > """ > This race normally does not cause any problems. The operations provided > by struct virtio_config_ops are usually invoked in a well defined sequence, > normally don't fail, and are normally usually quite infrequent too. s/usually/used/ > > Yet, if some of the these operations are directly triggered via > sysfs attributes, like in the case described by the referenced bug, > userspace is given an opportunity to force races by increasing the > frequency of the given operations. > """ Fine with me.