From: Marcelo Tosatti <mtosatti@redhat.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: Wanpeng Li <kernellwp@gmail.com>,
Florian Weimer <fweimer@redhat.com>,
Juergen Gross <jgross@suse.com>, Arnd Bergmann <arnd@arndb.de>,
Radim Krcmar <rkrcmar@redhat.com>,
Peter Zijlstra <peterz@infradead.org>, X86 ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Virtualization <virtualization@lists.linux-foundation.org>,
Stephen Boyd <sboyd@kernel.org>,
John Stultz <john.stultz@linaro.org>,
devel@linuxdriverproject.org, Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Matt Rickard <matt@softrans.com.au>
Subject: Re: [patch 00/11] x86/vdso: Cleanups, simmplifications and CLOCK_TAI support
Date: Sat, 6 Oct 2018 17:27:33 -0300 [thread overview]
Message-ID: <20181006202731.GC7129@amt.cnet> (raw)
In-Reply-To: <CALCETrXNKCNZzUXj=2sp1vBd_o7HHzfW6RwyY5v3-wMfbVaZnQ@mail.gmail.com>
On Thu, Oct 04, 2018 at 03:15:32PM -0700, Andy Lutomirski wrote:
> For better or for worse, I'm trying to understand this code. So far,
> I've come up with this patch:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?h=x86/vdso-tglx&id=14fd71e12b1c4492a06f368f75041f263e6862bf
>
> Is it correct, or am I missing some subtlety?
The master clock, when initialized, has a pair
masterclockvalues=(TSC value, time-of-day data).
When updating the guest clock, we only update relative to (TSC value)
that was read on masterclock initialization.
See the following comment on x86.c:
/*
*
* Assuming a stable TSC across physical CPUS, and a stable TSC
* across virtual CPUs, the following condition is possible.
* Each numbered line represents an event visible to both
* CPUs at the next numbered event.
...
When updating the "masterclockvalues" pair, all vcpus are
stopped.
next prev parent reply other threads:[~2018-10-06 20:27 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180914125006.349747096@linutronix.de>
2018-09-14 12:50 ` [patch 01/11] clocksource: Provide clocksource_arch_init() Thomas Gleixner
2018-09-14 12:50 ` [patch 02/11] x86/time: Implement clocksource_arch_init() Thomas Gleixner
2018-09-14 12:50 ` [patch 03/11] x86/vdso: Enforce 64bit clocksource Thomas Gleixner
2018-09-14 12:50 ` [patch 04/11] x86/vdso: Use unsigned int consistently for vsyscall_gtod_data::seq Thomas Gleixner
2018-09-14 12:50 ` [patch 05/11] x86/vdso: Introduce and use vgtod_ts Thomas Gleixner
2018-09-14 12:50 ` [patch 06/11] x86/vdso: Collapse high resolution functions Thomas Gleixner
2018-09-14 12:50 ` [patch 07/11] x86/vdso: Collapse coarse functions Thomas Gleixner
2018-09-14 12:50 ` [patch 08/11] x86/vdso: Replace the clockid switch case Thomas Gleixner
2018-09-14 12:50 ` [patch 09/11] x86/vdso: Simplify the invalid vclock case Thomas Gleixner
2018-09-14 12:50 ` [patch 10/11] x86/vdso: Move cycle_last handling into the caller Thomas Gleixner
2018-09-14 12:50 ` [patch 11/11] x66/vdso: Add CLOCK_TAI support Thomas Gleixner
[not found] ` <2f723b28-8f81-4b02-861c-42f756a8825a@redhat.com>
2018-09-14 13:05 ` [patch 00/11] x86/vdso: Cleanups, simmplifications and " Thomas Gleixner
2018-09-14 13:09 ` Peter Zijlstra
[not found] ` <alpine.DEB.2.21.1809141459530.10480@nanos.tec.linutronix.de>
[not found] ` <63a0f67d-fdb1-e2fc-5d4d-4f3cfbf86fd1@redhat.com>
2018-09-14 13:19 ` Thomas Gleixner
[not found] ` <20180914125119.081037164@linutronix.de>
2018-09-14 14:04 ` [patch 11/11] x66/vdso: Add " Andy Lutomirski
[not found] ` <ABB53D42-2A06-41B9-8A8C-40B39CD0289D@amacapital.net>
2018-09-14 14:27 ` Thomas Gleixner
[not found] ` <alpine.DEB.2.21.1809141625040.10480@nanos.tec.linutronix.de>
2018-09-14 14:59 ` Andy Lutomirski
[not found] ` <FAE37798-8CCE-44A5-9EF0-F69C2199BE60@amacapital.net>
2018-09-16 9:39 ` Thomas Gleixner
2018-09-14 14:22 ` [patch 00/11] x86/vdso: Cleanups, simmplifications and " Arnd Bergmann
[not found] ` <20180914125118.998589817@linutronix.de>
2018-09-14 15:26 ` [patch 10/11] x86/vdso: Move cycle_last handling into the caller Vitaly Kuznetsov
[not found] ` <20180914125118.293161327@linutronix.de>
2018-09-14 15:45 ` [patch 02/11] x86/time: Implement clocksource_arch_init() Vitaly Kuznetsov
[not found] ` <87zhwk6q2l.fsf@vitty.brq.redhat.com>
2018-09-15 6:05 ` Thomas Gleixner
[not found] ` <CAK8P3a1QfynDxkKBLXVa5Qj_z+7ct3QB5sDYuY5QV3ht-a0cTg@mail.gmail.com>
2018-09-17 13:00 ` [patch 00/11] x86/vdso: Cleanups, simmplifications and CLOCK_TAI support Thomas Gleixner
[not found] ` <alpine.DEB.2.21.1809171451380.16580@nanos.tec.linutronix.de>
2018-09-24 21:08 ` Arnd Bergmann
[not found] ` <20180914125118.909646643@linutronix.de>
2018-09-17 19:25 ` [patch 09/11] x86/vdso: Simplify the invalid vclock case Andy Lutomirski
[not found] ` <CALAqxLUv9Rd_eA7u9gZNFvTNrT1Z67RpHLozdeNC0W2yZm=Heg@mail.gmail.com>
2018-09-18 7:52 ` Thomas Gleixner
[not found] ` <alpine.DEB.2.21.1809180948570.3558@nanos.tec.linutronix.de>
2018-09-18 8:30 ` Peter Zijlstra
2018-09-18 8:52 ` Thomas Gleixner
[not found] ` <alpine.DEB.2.21.1809181050020.4167@nanos.tec.linutronix.de>
2018-09-18 10:06 ` Thomas Gleixner
[not found] ` <alpine.DEB.2.21.1809181204460.4167@nanos.tec.linutronix.de>
2018-09-18 10:41 ` Thomas Gleixner
[not found] ` <alpine.DEB.2.21.1809181237140.4167@nanos.tec.linutronix.de>
2018-09-18 12:48 ` Peter Zijlstra
2018-09-18 13:23 ` Thomas Gleixner
[not found] ` <alpine.DEB.2.21.1809181515170.6950@nanos.tec.linutronix.de>
2018-09-18 13:38 ` Peter Zijlstra
2018-09-18 15:52 ` Thomas Gleixner
[not found] ` <alpine.DEB.2.21.1809181731570.7302@nanos.tec.linutronix.de>
2018-09-27 14:41 ` Thomas Gleixner
2018-09-18 14:01 ` Andy Lutomirski
[not found] ` <863331ED-B04A-4B94-91A2-D34002C9CCDC@amacapital.net>
2018-09-18 22:46 ` Thomas Gleixner
[not found] ` <alpine.DEB.2.21.1809190037570.1468@nanos.tec.linutronix.de>
2018-09-18 23:03 ` Andy Lutomirski
[not found] ` <439A3E73-E4FF-4D66-800E-5BEE58EDE8F6@amacapital.net>
2018-09-18 23:16 ` Thomas Gleixner
[not found] ` <alpine.DEB.2.21.1809190112020.1468@nanos.tec.linutronix.de>
2018-09-27 14:36 ` Thomas Gleixner
[not found] ` <alpine.DEB.2.21.1809271630470.8118@nanos.tec.linutronix.de>
2018-09-27 14:39 ` Andy Lutomirski
[not found] ` <06e91c26-756f-f236-0af2-327e520c3065@rasmusvillemoes.dk>
2018-09-19 13:29 ` Thomas Gleixner
2018-10-03 5:15 ` [patch 00/11] x86/vdso: Cleanups, simmplifications and CLOCK_TAI support Andy Lutomirski
2018-10-03 9:22 ` Vitaly Kuznetsov
2018-10-03 19:00 ` Marcelo Tosatti
[not found] ` <87sh1ne64t.fsf@vitty.brq.redhat.com>
2018-10-03 10:20 ` Andy Lutomirski
2018-10-03 12:01 ` Vitaly Kuznetsov
[not found] ` <87murvdysd.fsf@vitty.brq.redhat.com>
2018-10-03 14:20 ` Andy Lutomirski
[not found] ` <8C316427-8BEC-4979-8AB2-5E385066BB6F@amacapital.net>
2018-10-03 15:10 ` Thomas Gleixner
[not found] ` <alpine.DEB.2.21.1810031704480.23677@nanos.tec.linutronix.de>
2018-10-03 16:18 ` Andy Lutomirski
2018-10-03 19:06 ` Marcelo Tosatti
[not found] ` <20181003190617.GC21381@amt.cnet>
2018-10-04 7:54 ` Vitaly Kuznetsov
[not found] ` <87k1mycfju.fsf@vitty.brq.redhat.com>
2018-10-04 8:11 ` Peter Zijlstra
2018-10-04 12:00 ` Paolo Bonzini
[not found] ` <20181004081100.GI19272@hirez.programming.kicks-ass.net>
2018-10-04 14:00 ` Andy Lutomirski
[not found] ` <B8C05946-43BB-40A4-A564-53904FAF8CC0@amacapital.net>
2018-10-04 19:31 ` Peter Zijlstra
[not found] ` <20181004193150.GQ19272@hirez.programming.kicks-ass.net>
2018-10-04 20:05 ` Andy Lutomirski
[not found] ` <499807AB-E779-40C3-AA3F-E8C77A7770EC@amacapital.net>
2018-10-04 22:15 ` Andy Lutomirski
2018-10-06 20:27 ` Marcelo Tosatti [this message]
2018-10-06 22:28 ` Andy Lutomirski
[not found] ` <CALCETrWqze2mifOdFc0GJYHtHGKiKX2Zdi5Kz87OyUogbqD15w@mail.gmail.com>
2018-10-08 15:26 ` Marcelo Tosatti
[not found] ` <20181008152650.GB27822@amt.cnet>
2018-10-08 17:38 ` Andy Lutomirski
[not found] ` <CALCETrVY6VHPLs0GXZM4+VYraTa1+xs=iRJoRa++OHX9Wq+ieg@mail.gmail.com>
2018-10-08 19:36 ` Marcelo Tosatti
[not found] ` <20181008193632.GA31729@amt.cnet>
2018-10-09 20:09 ` Andy Lutomirski
[not found] ` <CALCETrW6b8=dU6vkXNS-rW1GPzJTbVxuVNsU4aoD_NwwobVQcg@mail.gmail.com>
2018-10-11 22:27 ` Marcelo Tosatti
2018-10-11 23:00 ` Andy Lutomirski
2018-10-15 13:39 ` Marcelo Tosatti
2018-10-06 20:49 ` Marcelo Tosatti
[not found] ` <1832e2af-3189-cb50-f4b6-45e74cdcf4b4@redhat.com>
2018-10-04 14:04 ` Andy Lutomirski
2018-10-05 21:18 ` Marcelo Tosatti
[not found] ` <20181003190026.GB21381@amt.cnet>
2018-10-03 19:05 ` [patch 00/11] x86/vdso: Cleanups, simmplifications and CLOCK_TAI support\ Marcelo Tosatti
2018-10-03 22:32 ` [patch 00/11] x86/vdso: Cleanups, simmplifications and CLOCK_TAI support Andy Lutomirski
2018-10-04 16:37 ` Marcelo Tosatti
[not found] ` <20181004163705.GA25129@amt.cnet>
2018-10-04 17:08 ` Andy Lutomirski
[not found] ` <CALCETrWbWLM5Jjm7iJCE7S=BJ9OFw2QQGJ2Ao-qsuaN50z=y0A@mail.gmail.com>
2018-10-04 17:28 ` Vitaly Kuznetsov
2018-10-04 20:32 ` Andy Lutomirski
2018-09-14 12:50 Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181006202731.GC7129@amt.cnet \
--to=mtosatti@redhat.com \
--cc=arnd@arndb.de \
--cc=devel@linuxdriverproject.org \
--cc=fweimer@redhat.com \
--cc=jgross@suse.com \
--cc=john.stultz@linaro.org \
--cc=kernellwp@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=matt@softrans.com.au \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rkrcmar@redhat.com \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).