From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH RFC 3/4] barriers: convert a control to a data dependency Date: Wed, 2 Jan 2019 16:24:15 -0500 Message-ID: <20190102162400-mutt-send-email-mst__27421.2473923855$1546464141$gmane$org@kernel.org> References: <20190102205715.14054-1-mst@redhat.com> <20190102205715.14054-4-mst@redhat.com> <20190102210024.GJ6310@bombadil.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190102210024.GJ6310@bombadil.infradead.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Matthew Wilcox Cc: Andrea Parri , linux-doc@vger.kernel.org, Peter Zijlstra , Akira Yokosawa , Will Deacon , virtualization@lists.linux-foundation.org, David Howells , linux-arch@vger.kernel.org, Jonathan Corbet , linux-sparse@vger.kernel.org, Alan Stern , Matt Turner , "Paul E. McKenney" , Boqun Feng , Arnd Bergmann , Daniel Lustig , Nicholas Piggin , Ivan Kokshaysky , Luc Maranget , Richard Henderson , Jade Alglave , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.orgLuc Van Oostenryck List-Id: virtualization@lists.linuxfoundation.org On Wed, Jan 02, 2019 at 01:00:24PM -0800, Matthew Wilcox wrote: > On Wed, Jan 02, 2019 at 03:57:58PM -0500, Michael S. Tsirkin wrote: > > @@ -875,6 +893,8 @@ to the CPU containing it. See the section on "Multicopy atomicity" > > for more information. > > > > > > + > > + > > In summary: > > > > (*) Control dependencies can order prior loads against later stores. > > Was this hunk intentional? Nope, thanks for catching this. -- MST