From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: kvm@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration
Date: Sat, 10 Aug 2019 15:12:11 -0400 [thread overview]
Message-ID: <20190810150611-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1000f8a3-19a9-0383-61e5-ba08ddc9fcba@redhat.com>
On Thu, Aug 08, 2019 at 08:54:54PM +0800, Jason Wang wrote:
> I don't have any objection to convert to spinlock() but just want to
> know if any case that the above smp_mb() + counter looks good to you?
So how about we try this:
- revert the original patch for this release
- new safe patch with a spinlock for the next release
- whatever improvements we can come up with on top
Thoughts?
Because I think this needs much more scrutiny than we can
give an incremental patch.
--
MST
next prev parent reply other threads:[~2019-08-10 19:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190807070617.23716-1-jasowang@redhat.com>
2019-08-07 7:06 ` [PATCH V4 1/9] vhost: don't set uaddr for invalid address Jason Wang
2019-08-07 7:06 ` [PATCH V4 2/9] vhost: validate MMU notifier registration Jason Wang
2019-08-07 7:06 ` [PATCH V4 3/9] vhost: fix vhost map leak Jason Wang
2019-08-07 7:06 ` [PATCH V4 4/9] vhost: reset invalidate_count in vhost_set_vring_num_addr() Jason Wang
2019-08-07 7:06 ` [PATCH V4 5/9] vhost: mark dirty pages during map uninit Jason Wang
2019-08-07 7:06 ` [PATCH V4 6/9] vhost: don't do synchronize_rcu() in vhost_uninit_vq_maps() Jason Wang
2019-08-07 7:06 ` [PATCH V4 7/9] vhost: do not use RCU to synchronize MMU notifier with worker Jason Wang
2019-08-07 7:06 ` [PATCH V4 8/9] vhost: correctly set dirty pages in MMU notifiers callback Jason Wang
2019-08-07 7:06 ` [PATCH V4 9/9] vhost: do not return -EAGAIN for non blocking invalidation too early Jason Wang
[not found] ` <20190807070617.23716-8-jasowang@redhat.com>
2019-08-07 12:07 ` [PATCH V4 7/9] vhost: do not use RCU to synchronize MMU notifier with worker Jason Gunthorpe
[not found] ` <20190807120738.GB1557@ziepe.ca>
2019-08-07 14:02 ` Jason Wang
[not found] ` <ba5f375f-435a-91fd-7fca-bfab0915594b@redhat.com>
2019-08-08 12:54 ` Jason Wang
[not found] ` <1000f8a3-19a9-0383-61e5-ba08ddc9fcba@redhat.com>
2019-08-08 13:01 ` Jason Wang
2019-08-08 13:05 ` Jason Gunthorpe
2019-08-10 19:12 ` Michael S. Tsirkin [this message]
2019-08-09 5:15 ` [PATCH V4 0/9] Fixes for metadata accelreation David Miller
[not found] ` <20190808.221543.450194346419371363.davem@davemloft.net>
2019-08-09 5:35 ` Jason Wang
2019-08-09 5:48 [PATCH V5 0/9] Fixes for vhost metadata acceleration Jason Wang
[not found] <20190809054851.20118-1-jasowang@redhat.com>
2019-08-10 17:52 ` Michael S. Tsirkin
2019-08-12 2:44 ` Jason Wang
[not found] ` <360a3b91-1ac5-84c0-d34b-a4243fa748c4@redhat.com>
2019-08-12 4:13 ` David Miller
2019-08-12 9:49 ` Michael S. Tsirkin
[not found] ` <20190812054429-mutt-send-email-mst@kernel.org>
2019-08-12 13:02 ` Jason Gunthorpe
2019-08-13 8:12 ` Jason Wang
[not found] ` <20190812130252.GE24457@ziepe.ca>
2019-08-13 8:31 ` Jason Wang
[not found] ` <9a9641fe-b48f-f32a-eecc-af9c2f4fbe0e@redhat.com>
2019-08-13 11:57 ` Jason Gunthorpe
[not found] ` <20190813115707.GC29508@ziepe.ca>
2019-08-13 16:41 ` Christoph Hellwig
2019-08-15 3:28 ` Jason Wang
2019-08-15 3:26 ` Jason Wang
[not found] ` <74838e61-3a5e-0f51-2092-f4a16d144b45@redhat.com>
2019-08-15 19:33 ` Jason Gunthorpe
[not found] ` <663be71f-f96d-cfbc-95a0-da0ac6b82d9f@redhat.com>
2019-08-19 21:08 ` Michael S. Tsirkin
[not found] ` <20190819162733-mutt-send-email-mst@kernel.org>
2019-08-20 2:29 ` Jason Wang
[not found] ` <9325de4b-1d79-eb19-306e-e7a8fa8cc1a5@redhat.com>
2019-09-01 18:02 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190810150611-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).