From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch, kraxel@redhat.com, airlied@linux.ie,
corbet@lwn.net, z.liuxinliang@hisilicon.com,
zourongrong@gmail.com, kong.kongxinwei@hisilicon.com,
puck.chen@hisilicon.com, hdegoede@redhat.com, sam@ravnborg.org,
yc_chen@aspeedtech.com
Cc: virtualization@lists.linux-foundation.org,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org
Subject: [PATCH v2 4/4] drm/vram: Unconditonally set BO call-back functions
Date: Wed, 11 Sep 2019 13:09:10 +0200 [thread overview]
Message-ID: <20190911110910.30698-5-tzimmermann@suse.de> (raw)
In-Reply-To: <20190911110910.30698-1-tzimmermann@suse.de>
The statement's condition is always true.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
---
drivers/gpu/drm/drm_gem_vram_helper.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c
index 1a05e2a97b93..ab9f8523d887 100644
--- a/drivers/gpu/drm/drm_gem_vram_helper.c
+++ b/drivers/gpu/drm/drm_gem_vram_helper.c
@@ -93,8 +93,7 @@ static int drm_gem_vram_init(struct drm_device *dev,
int ret;
size_t acc_size;
- if (!gbo->bo.base.funcs)
- gbo->bo.base.funcs = &drm_gem_vram_object_funcs;
+ gbo->bo.base.funcs = &drm_gem_vram_object_funcs;
ret = drm_gem_object_init(dev, &gbo->bo.base, size);
if (ret)
--
2.23.0
prev parent reply other threads:[~2019-09-11 11:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 11:09 [PATCH v2 0/4] Merge VRAM MM and GEM VRAM source files Thomas Zimmermann
2019-09-11 11:09 ` [PATCH v2 1/4] drm/vram: Move VRAM memory manager to GEM VRAM implementation Thomas Zimmermann
2019-09-11 11:09 ` [PATCH v2 2/4] drm/vram: Have VRAM MM call GEM VRAM functions directly Thomas Zimmermann
2019-09-11 11:09 ` [PATCH v2 3/4] drm/vram: Unexport internal functions of VRAM MM Thomas Zimmermann
2019-09-11 11:09 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190911110910.30698-5-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@linux.ie \
--cc=corbet@lwn.net \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=kraxel@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=puck.chen@hisilicon.com \
--cc=sam@ravnborg.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=yc_chen@aspeedtech.com \
--cc=z.liuxinliang@hisilicon.com \
--cc=zourongrong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).