From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}() Date: Fri, 7 Feb 2020 16:00:30 +0200 Message-ID: <20200207140030.GY13686@intel.com> References: <20200207084135.4524-1-tzimmermann@suse.de> <20200207084135.4524-3-tzimmermann@suse.de> <20200207133720.GZ43062@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20200207133720.GZ43062@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" To: Daniel Vetter Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, Thomas Zimmermann , alexander.deucher@amd.com, spice-devel@lists.freedesktop.org, sam@ravnborg.org, emil.velikov@collabora.com List-Id: virtualization@lists.linuxfoundation.org On Fri, Feb 07, 2020 at 02:37:20PM +0100, Daniel Vetter wrote: > On Fri, Feb 07, 2020 at 09:41:31AM +0100, Thomas Zimmermann wrote: > > The simple-encoder helpers initialize an encoder with an empty > > implementation. This covers the requirements of most of the existing > > DRM drivers. A call to drm_simple_encoder_create() allocates and > > initializes an encoder instance, a call to drm_simple_encoder_init() > > initializes a pre-allocated instance. > > = > > Signed-off-by: Thomas Zimmermann > = > This has quick a bit midlayer taste to it ... I think having this as a > helper would be cleaner ... > = > The other bit is drm_encoder->possible_crtcs. If we do create a helper for > these, lets at least try to make them not suck too badly :-) Otherwise I > guess it would be time to officially document what exactly possible_crtcs > =3D=3D 0 means from an uabi pov. I had some improvements for this stuff. Just re-sent the remainder. -- = Ville Syrj=E4l=E4 Intel