From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] virtio: Work around frames incorrectly marked as gso Date: Thu, 13 Feb 2020 10:53:25 -0500 Message-ID: <20200213105010-mutt-send-email-mst@kernel.org> References: <20191209104824.17059-1-anton.ivanov@cambridgegreys.com> <57230228-7030-c65f-a24f-910ca52bbe9e@cambridgegreys.com> <918222d9-816a-be70-f8af-b8dfcb586240@cambridgegreys.com> <20200211053502-mutt-send-email-mst@kernel.org> <9547228b-aa93-f2b6-6fdc-8d33cde3716a@cambridgegreys.com> <20200213045937-mutt-send-email-mst@kernel.org> <94fb9656-99ee-a001-e428-9d76c3620e61@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <94fb9656-99ee-a001-e428-9d76c3620e61@gmail.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" To: Eric Dumazet Cc: netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-um@lists.infradead.org, Anton Ivanov List-Id: virtualization@lists.linuxfoundation.org T24gVGh1LCBGZWIgMTMsIDIwMjAgYXQgMDc6NDQ6MDZBTSAtMDgwMCwgRXJpYyBEdW1hemV0IHdy b3RlOgo+IAo+IAo+IE9uIDIvMTMvMjAgMjowMCBBTSwgTWljaGFlbCBTLiBUc2lya2luIHdyb3Rl Ogo+ID4gT24gV2VkLCBGZWIgMTIsIDIwMjAgYXQgMDU6Mzg6MDlQTSArMDAwMCwgQW50b24gSXZh bm92IHdyb3RlOgo+ID4+Cj4gPj4KPiA+PiBPbiAxMS8wMi8yMDIwIDEwOjM3LCBNaWNoYWVsIFMu IFRzaXJraW4gd3JvdGU6Cj4gPj4+IE9uIFR1ZSwgRmViIDExLCAyMDIwIGF0IDA3OjQyOjM3QU0g KzAwMDAsIEFudG9uIEl2YW5vdiB3cm90ZToKPiA+Pj4+IE9uIDExLzAyLzIwMjAgMDI6NTEsIEph c29uIFdhbmcgd3JvdGU6Cj4gPj4+Pj4KPiA+Pj4+PiBPbiAyMDIwLzIvMTEg5LiK5Y2IMTI6NTUs IEFudG9uIEl2YW5vdiB3cm90ZToKPiA+Pj4+Pj4KPiA+Pj4+Pj4KPiA+Pj4+Pj4gT24gMDkvMTIv MjAxOSAxMDo0OCwgYW50b24uaXZhbm92QGNhbWJyaWRnZWdyZXlzLmNvbSB3cm90ZToKPiA+Pj4+ Pj4+IEZyb206IEFudG9uIEl2YW5vdiA8YW50b24uaXZhbm92QGNhbWJyaWRnZWdyZXlzLmNvbT4K PiA+Pj4+Pj4+Cj4gPj4+Pj4+PiBTb21lIG9mIHRoZSBmcmFtZXMgbWFya2VkIGFzIEdTTyB3aGlj aCBhcnJpdmUgYXQKPiA+Pj4+Pj4+IHZpcnRpb19uZXRfaGRyX2Zyb21fc2tiKCkgaGF2ZSBubyBH U09fVFlQRSwgbm8KPiA+Pj4+Pj4+IGZyYWdtZW50cyAoZGF0YV9sZW4gPSAwKSBhbmQgbGVuZ3Ro IHNpZ25pZmljYW50bHkgc2hvcnRlcgo+ID4+Pj4+Pj4gdGhhbiB0aGUgTVRVICg3NTIgaW4gbXkg ZXhwZXJpbWVudHMpLgo+ID4+Pj4+Pj4KPiA+Pj4+Pj4+IFRoaXMgaXMgb2JzZXJ2ZWQgb24gcmF3 IHNvY2tldHMgcmVhZGluZyBvZmYgdkV0aCBpbnRlcmZhY2VzCj4gPj4+Pj4+PiBpbiBhbGwgNC54 IGFuZCA1Lngga2VybmVscyBJIHRlc3RlZC4KPiA+Pj4+Pj4+Cj4gPj4+Pj4+PiBUaGVzZSBmcmFt ZXMgYXJlIHJlcG9ydGVkIGFzIGludmFsaWQgd2hpbGUgdGhleSBhcmUgaW4gZmFjdAo+ID4+Pj4+ Pj4gZ3NvLWxlc3MgZnJhbWVzLgo+ID4+Pj4+Pj4KPiA+Pj4+Pj4+IFRoaXMgcGF0Y2ggbWFya3Mg dGhlIHZuZXQgaGVhZGVyIGFzIG5vLUdTTyBmb3IgdGhlbSBpbnN0ZWFkCj4gPj4+Pj4+PiBvZiBy ZXBvcnRpbmcgaXQgYXMgaW52YWxpZC4KPiA+Pj4+Pj4+Cj4gPj4+Pj4+PiBTaWduZWQtb2ZmLWJ5 OiBBbnRvbiBJdmFub3YgPGFudG9uLml2YW5vdkBjYW1icmlkZ2VncmV5cy5jb20+Cj4gPj4+Pj4+ PiAtLS0KPiA+Pj4+Pj4+ICDCoCBpbmNsdWRlL2xpbnV4L3ZpcnRpb19uZXQuaCB8IDggKysrKysr LS0KPiA+Pj4+Pj4+ICDCoCAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0 aW9ucygtKQo+ID4+Pj4+Pj4KPiA+Pj4+Pj4+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L3Zp cnRpb19uZXQuaCBiL2luY2x1ZGUvbGludXgvdmlydGlvX25ldC5oCj4gPj4+Pj4+PiBpbmRleCAw ZDFmZTkyOTdhYzYuLmQ5MGQ1Y2ZmMWI5YSAxMDA2NDQKPiA+Pj4+Pj4+IC0tLSBhL2luY2x1ZGUv bGludXgvdmlydGlvX25ldC5oCj4gPj4+Pj4+PiArKysgYi9pbmNsdWRlL2xpbnV4L3ZpcnRpb19u ZXQuaAo+ID4+Pj4+Pj4gQEAgLTExMiw4ICsxMTIsMTIgQEAgc3RhdGljIGlubGluZSBpbnQKPiA+ Pj4+Pj4+IHZpcnRpb19uZXRfaGRyX2Zyb21fc2tiKGNvbnN0IHN0cnVjdCBza19idWZmICpza2Is Cj4gPj4+Pj4+PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaGRyLT5nc29fdHlwZSA9IFZJ UlRJT19ORVRfSERSX0dTT19UQ1BWNDsKPiA+Pj4+Pj4+ICDCoMKgwqDCoMKgwqDCoMKgwqAgZWxz ZSBpZiAoc2luZm8tPmdzb190eXBlICYgU0tCX0dTT19UQ1BWNikKPiA+Pj4+Pj4+ICDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBoZHItPmdzb190eXBlID0gVklSVElPX05FVF9IRFJfR1NPX1RD UFY2Owo+ID4+Pj4+Pj4gLcKgwqDCoMKgwqDCoMKgIGVsc2UKPiA+Pj4+Pj4+IC3CoMKgwqDCoMKg wqDCoMKgwqDCoMKgIHJldHVybiAtRUlOVkFMOwo+ID4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIGVs c2Ugewo+ID4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKHNrYi0+ZGF0YV9sZW4g PT0gMCkKPiA+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaGRyLT5nc29f dHlwZSA9IFZJUlRJT19ORVRfSERSX0dTT19OT05FOwo+ID4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKg wqDCoMKgwqAgZWxzZQo+ID4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBy ZXR1cm4gLUVJTlZBTDsKPiA+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCB9Cj4gPj4+Pj4+PiAgwqDC oMKgwqDCoMKgwqDCoMKgIGlmIChzaW5mby0+Z3NvX3R5cGUgJiBTS0JfR1NPX1RDUF9FQ04pCj4g Pj4+Pj4+PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaGRyLT5nc29fdHlwZSB8PSBWSVJU SU9fTkVUX0hEUl9HU09fRUNOOwo+ID4+Pj4+Pj4gIMKgwqDCoMKgwqAgfSBlbHNlCj4gPj4+Pj4+ Pgo+ID4+Pj4+Pgo+ID4+Pj4+PiBwaW5nLgo+ID4+Pj4+Pgo+ID4+Pj4+Cj4gPj4+Pj4gRG8geW91 IG1lYW4gZ3NvX3NpemUgaXMgc2V0IGJ1dCBnc29fdHlwZSBpcyBub3Q/IExvb2tzIGxpa2UgYSBi dWcKPiA+Pj4+PiBlbHNld2hlcmUuCj4gPj4+Pj4KPiA+Pj4+PiBUaGFua3MKPiA+Pj4+Pgo+ID4+ Pj4+Cj4gPj4+PiBZZXMuCj4gPj4+Pgo+ID4+Pj4gSSBjb3VsZCBub3QgdHJhY2UgaXQgd2hlcmUg aXQgaXMgY29taW5nIGZyb20uCj4gPj4+Pgo+ID4+Pj4gSSBzZWUgaXQgd2hlbiBkb2luZyByZWN2 bW1zZyBvbiByYXcgc29ja2V0cyBpbiB0aGUgVU1MIHZlY3RvciBuZXR3b3JrCj4gPj4+PiBkcml2 ZXJzLgo+ID4+Pj4KPiA+Pj4KPiA+Pj4gSSB0aGluayB3ZSBuZWVkIHRvIGZpbmQgdGhlIGN1bHBy aXQgYW5kIGZpeCBpdCB0aGVyZSwgbG90cyBvZiBvdGhlciB0aGluZ3MKPiA+Pj4gY2FuIGJyZWFr IG90aGVyd2lzZS4KPiA+Pj4gSnVzdCBwcmludGluZyBvdXQgc2tiLT5kZXYtPm5hbWUgc2hvdWxk IGRvIHRoZSB0cmljaywgbm8/Cj4gPj4KPiA+PiBUaGUgcHJpbnRrIGluIHZpcnRpb19uZXRfaGRy X2Zyb21fc2tiIHNheXMgTlVMTC4KPiA+Pgo+ID4+IFRoYXQgaXMgcHJvYmFibHkgbm9ybWFsIGZv ciBhIGxvY2FsbHkgb3JpZ2luYXRlZCBmcmFtZS4KPiA+Pgo+ID4+IEkgY2Fubm90IHJlcHJvZHVj ZSB0aGlzIHdpdGggbmV0d29yayB0cmFmZmljIGJ5IHRoZSB3YXkgLSBpdCBoYXBwZW5zIG9ubHkg aWYgdGhlIHRyYWZmaWMgaXMgbG9jYWxseSBvcmlnaW5hdGVkIG9uIHRoZSBob3N0Lgo+ID4+Cj4g Pj4gQSwKPiA+IAo+ID4gT0sgc28gaXMgaXQgY29kZSBpbiBfX3RjcF90cmFuc21pdF9za2IgdGhh dCBzZXRzIGdzb19zaXplIHRvIG5vbi1udWxsCj4gPiB3aGVuIGdzb190eXBlIGlzIDA/Cj4gPgo+ IAo+IENvcnJlY3Qgd2F5IHRvIGRldGVybWluZSBpZiBhIHBhY2tldCBpcyBhIGdzbyBvbmUgaXMg YnkgbG9va2luZyBhdCBnc29fc2l6ZS4KPiBUaGVuIG9ubHkgaXQgaXMgbGVnYWwgbG9va2luZyBh dCBnc29fdHlwZQo+IAo+IAo+IHN0YXRpYyBpbmxpbmUgYm9vbCBza2JfaXNfZ3NvKGNvbnN0IHN0 cnVjdCBza19idWZmICpza2IpCj4gewo+ICAgICByZXR1cm4gc2tiX3NoaW5mbyhza2IpLT5nc29f c2l6ZTsKPiB9Cj4gCj4gLyogTm90ZTogU2hvdWxkIGJlIGNhbGxlZCBvbmx5IGlmIHNrYl9pc19n c28oc2tiKSBpcyB0cnVlICovCj4gc3RhdGljIGlubGluZSBib29sIHNrYl9pc19nc29fdjYoY29u c3Qgc3RydWN0IHNrX2J1ZmYgKnNrYikKPiAuLi4KPiAKPiAKPiBUaGVyZSBpcyBhYnNvbHV0ZWx5 IG5vIHJlbGF0aW9uIGJldHdlZW4gR1NPIGFuZCBza2ItPmRhdGFfbGVuLCBza2IgY2FuIGJlIGxp bmVhcml6ZWQKPiBmb3IgdmFyaW91cyBvcnRob2dvbmFsIHJlYXNvbnMuCgpUaGUgcmVwb3J0ZWQg cHJvYmxlbSBpcyB0aGF0IHZpcnRpbyBnZXRzIGEgcGFja2V0IHdoZXJlIGdzb19zaXplCmlzICEw IGJ1dCBnc29fdHlwZSBpcyAwLgoKSXQgY3VycmVudGx5IGRyb3BzIHRoZXNlIG9uIHRoZSBhc3N1 bXB0aW9uIHRoYXQgaXQncyBzb21lIHR5cGUKb2YgYSBnc28gcGFja2V0IGl0IGRvZXMgbm90IGtu b3cgaG93IHRvIGhhbmRsZS4KCgpTbyB5b3UgYXJlIHNheWluZyBpZiBza2JfaXNfZ3NvIHdlIGNh biBzdGlsbCBoYXZlIGdzb190eXBlIHNldCB0byAwLAphbmQgdGhhdCdzIGFuIGV4cGVjdGVkIGNv bmZpZ3VyYXRpb24/CgpTbyB0aGUgcGF0Y2ggc2hvdWxkIGp1c3QgYmU6CgoKLSAgICAgICAgaWYg KHNrYl9pc19nc28oc2tiKSkgeworICAgICAgICBpZiAoc2tiX2lzX2dzbyhza2IpICYmIHNpbmZv LT5nc29fdHlwZSkgewoKCgo/CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlz dHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3Jn L21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24=