From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Philippe Brucker Subject: Re: [PATCH 03/15] drm/msm/mdp5: Remove direct access of dev->iommu_fwspec Date: Mon, 16 Mar 2020 16:42:09 +0100 Message-ID: <20200316154209.GD304669@myrica> References: <20200310091229.29830-1-joro@8bytes.org> <20200310091229.29830-4-joro@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200310091229.29830-4-joro@8bytes.org> Sender: linux-arm-msm-owner@vger.kernel.org To: Joerg Roedel Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, virtualization@lists.linux-foundation.org, Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Rob Clark , Sean Paul , Will Deacon , Robin Murphy , Matthias Brugger , Thierry Reding , Andy Gross , Bjorn Andersson , Joerg Roedel List-Id: virtualization@lists.linuxfoundation.org On Tue, Mar 10, 2020 at 10:12:17AM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > Use the accessor functions instead of directly dereferencing > dev->iommu_fwspec. > > Signed-off-by: Joerg Roedel Reviewed-by: Jean-Philippe Brucker > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > index e43ecd4be10a..1252e1d76340 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > @@ -725,7 +725,7 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev) > > if (config->platform.iommu) { > iommu_dev = &pdev->dev; > - if (!iommu_dev->iommu_fwspec) > + if (!dev_iommu_fwspec_get(iommu_dev)) > iommu_dev = iommu_dev->parent; > > aspace = msm_gem_address_space_create(iommu_dev, > -- > 2.17.1 >