From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Philippe Brucker Subject: Re: [PATCH 04/15] iommu/tegra-gart: Remove direct access of dev->iommu_fwspec Date: Mon, 16 Mar 2020 16:42:59 +0100 Message-ID: <20200316154259.GE304669@myrica> References: <20200310091229.29830-1-joro@8bytes.org> <20200310091229.29830-5-joro@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200310091229.29830-5-joro@8bytes.org> Sender: linux-kernel-owner@vger.kernel.org To: Joerg Roedel Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, virtualization@lists.linux-foundation.org, Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Rob Clark , Sean Paul , Will Deacon , Robin Murphy , Matthias Brugger , Thierry Reding , Andy Gross , Bjorn Andersson , Joerg Roedel List-Id: virtualization@lists.linuxfoundation.org On Tue, Mar 10, 2020 at 10:12:18AM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > Use the accessor functions instead of directly dereferencing > dev->iommu_fwspec. > > Signed-off-by: Joerg Roedel Reviewed-by: Jean-Philippe Brucker > --- > drivers/iommu/tegra-gart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/tegra-gart.c b/drivers/iommu/tegra-gart.c > index 3fb7ba72507d..db6559e8336f 100644 > --- a/drivers/iommu/tegra-gart.c > +++ b/drivers/iommu/tegra-gart.c > @@ -247,7 +247,7 @@ static int gart_iommu_add_device(struct device *dev) > { > struct iommu_group *group; > > - if (!dev->iommu_fwspec) > + if (!dev_iommu_fwspec_get(dev)) > return -ENODEV; > > group = iommu_group_get_for_dev(dev); > -- > 2.17.1 >