From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: Bharat Bhushan <bbhushan2@marvell.com>
Cc: "mst@redhat.com" <mst@redhat.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>
Subject: Re: [EXT] Re: [PATCH RFC] iommu/virtio: Use page size bitmap supported by endpoint
Date: Tue, 24 Mar 2020 07:48:11 +0100 [thread overview]
Message-ID: <20200324064811.GA2173442@myrica> (raw)
In-Reply-To: <MWHPR1801MB1966865A8DE5AB8FFFAEC85FE3F00@MWHPR1801MB1966.namprd18.prod.outlook.com>
On Mon, Mar 23, 2020 at 06:04:37PM +0000, Bharat Bhushan wrote:
> > > -static int viommu_domain_finalise(struct viommu_dev *viommu,
> > > +static int viommu_domain_finalise(struct viommu_endpoint *vdev,
> > > struct iommu_domain *domain)
> > > {
> > > int ret;
> > > struct viommu_domain *vdomain = to_viommu_domain(domain);
> > > + struct viommu_dev *viommu = vdev->viommu;
> > >
> > > vdomain->viommu = viommu;
> > > vdomain->map_flags = viommu->map_flags;
> > >
> > > - domain->pgsize_bitmap = viommu->pgsize_bitmap;
> > > + if (vdev->pgsize_bitmap)
> > > + domain->pgsize_bitmap = vdev->pgsize_bitmap;
> > > + else
> > > + domain->pgsize_bitmap = viommu->pgsize_bitmap;
> > > +
> >
> > nit: it could be nicer to initialize vdev->pgsize_bitmap in add_device(),
>
> To what size we should initialize in add_device, PAGE_SIZE?
No to viommu->pgsize_bitmap
Thanks,
Jean
prev parent reply other threads:[~2020-03-24 6:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200323084108.1721-1-bbhushan2@marvell.com>
2020-03-23 9:59 ` [PATCH RFC] iommu/virtio: Use page size bitmap supported by endpoint Jean-Philippe Brucker
2020-03-23 17:25 ` [EXT] " Bharat Bhushan
2020-03-24 7:58 ` Jean-Philippe Brucker
2020-03-23 18:04 ` Bharat Bhushan
2020-03-24 6:48 ` Jean-Philippe Brucker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324064811.GA2173442@myrica \
--to=jean-philippe@linaro.org \
--cc=bbhushan2@marvell.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox