From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: Bharat Bhushan <bbhushan2@marvell.com>
Cc: Robin Murphy <robin.murphy@arm.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"mst@redhat.com" <mst@redhat.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"eric.auger.pro@gmail.com" <eric.auger.pro@gmail.com>,
"eric.auger@redhat.com" <eric.auger@redhat.com>
Subject: Re: [EXT] Re: [RFC PATCH v2] iommu/virtio: Use page size bitmap supported by endpoint
Date: Thu, 2 Apr 2020 11:24:17 +0200 [thread overview]
Message-ID: <20200402092417.GA1176452@myrica> (raw)
In-Reply-To: <MWHPR1801MB19667BA1D59590BC3DFD87C7E3C60@MWHPR1801MB1966.namprd18.prod.outlook.com>
On Thu, Apr 02, 2020 at 03:53:40AM +0000, Bharat Bhushan wrote:
> > > > +struct virtio_iommu_probe_pgsize_mask {
> > > > + struct virtio_iommu_probe_property head;
> > > > + __u8 reserved[4];
> > > > + __u64 pgsize_bitmap;
> >
> > Should be __le64
>
> Based on" iommu/virtio: Fix sparse warning" patch https://www.spinics.net/lists/linux-virtualization/msg41944.html changed to __u64 (not __le64)
Yes that one was only for the virtio config struct, to play nice with
other devices. We should still use __le for the other structures,
including probe properties.
Thanks,
Jean
>
> Will keep __le64.
>
> Thanks
> -Bharat
>
> >
> > Thanks,
> > Jean
> >
> > > > +};
> > > > +
> > > > #define VIRTIO_IOMMU_RESV_MEM_T_RESERVED 0
> > > > #define VIRTIO_IOMMU_RESV_MEM_T_MSI 1
> > > >
prev parent reply other threads:[~2020-04-02 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 11:38 [RFC PATCH v2] iommu/virtio: Use page size bitmap supported by endpoint Bharat Bhushan
2020-04-01 13:00 ` Robin Murphy
2020-04-01 15:49 ` Jean-Philippe Brucker
2020-04-02 3:53 ` [EXT] " Bharat Bhushan
2020-04-02 9:24 ` Jean-Philippe Brucker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200402092417.GA1176452@myrica \
--to=jean-philippe@linaro.org \
--cc=bbhushan2@marvell.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jasowang@redhat.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=robin.murphy@arm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox