From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v2 2/2] vhost: disable for OABI Date: Mon, 6 Apr 2020 09:21:10 -0400 Message-ID: <20200406092056-mutt-send-email-mst@kernel.org> References: <20200406121233.109889-1-mst@redhat.com> <20200406121233.109889-3-mst@redhat.com> <20200406085707-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: "linux-kernel@vger.kernel.org" , Ard Biesheuvel , "richard.henderson@linaro.org" , "christophe.lyon@st.com" , kbuild test robot , "daniel.santos@pobox.com" , Jason Wang , "kbuild-all@lists.01.org" , Russell King , Linux ARM , Richard Earnshaw , Sudeep Dutt , Ashutosh Dixit , Greg Kroah-Hartman , "David S. Miller" , Networking , virtualization@lists.linux-foundation List-Id: virtualization@lists.linuxfoundation.org On Mon, Apr 06, 2020 at 03:15:20PM +0200, Arnd Bergmann wrote: > On Mon, Apr 6, 2020 at 3:02 PM Michael S. Tsirkin wrote: > > > > On Mon, Apr 06, 2020 at 02:50:32PM +0200, Arnd Bergmann wrote: > > > On Mon, Apr 6, 2020 at 2:12 PM Michael S. Tsirkin wrote: > > > > > > > > > > > +config VHOST_DPN > > > > + bool "VHOST dependencies" > > > > + depends on !ARM || AEABI > > > > + default y > > > > + help > > > > + Anything selecting VHOST or VHOST_RING must depend on VHOST_DPN. > > > > + This excludes the deprecated ARM ABI since that forces a 4 byte > > > > + alignment on all structs - incompatible with virtio spec requirements. > > > > + > > > > > > This should not be a user-visible option, so just make this 'def_bool > > > !ARM || AEABI' > > > > > > > I like keeping some kind of hint around for when one tries to understand > > why is a specific symbol visible. > > I meant you should remove the "VHOST dependencies" prompt, not the > help text, which is certainly useful here. You can also use the three lines > > bool > depends on !ARM || AEABI > default y > > in front of the help text, but those are equivalent to the one-line version > I suggested. > > Arnd Oh right. Good point. Thanks! -- MST