From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH 15/70] x86/boot/compressed/64: Always switch to own page-table Date: Mon, 6 Apr 2020 13:56:59 +0200 Message-ID: <20200406115659.GD2520@zn.tnic> References: <20200319091407.1481-1-joro@8bytes.org> <20200319091407.1481-16-joro@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20200319091407.1481-16-joro@8bytes.org> Sender: linux-kernel-owner@vger.kernel.org To: Joerg Roedel Cc: x86@kernel.org, hpa@zytor.com, Andy Lutomirski , Dave Hansen , Peter Zijlstra , Thomas Hellstrom , Jiri Slaby , Dan Williams , Tom Lendacky , Juergen Gross , Kees Cook , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, Joerg Roedel List-Id: virtualization@lists.linuxfoundation.org On Thu, Mar 19, 2020 at 10:13:12AM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > When booted through startup_64 the kernel keeps running on the EFI > page-table until the KASLR code sets up its own page-table. Without > KASLR the pre-decompression boot code never switches off the EFI > page-table. Change that by unconditionally switching to our own > page-table once the kernel is relocated. > > This makes sure we can make changes to the mapping when necessary, for Pls use passive voice in your commit message: no "we" or "I", etc, and describe your changes in imperative mood. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette