From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Eugenio Pérez" <eperezma@redhat.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
kvm list <kvm@vger.kernel.org>, Cornelia Huck <cohuck@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [PATCH v2 5/8] tools/virtio: Use __vring_new_virtqueue in virtio_test.c
Date: Thu, 16 Apr 2020 18:32:56 -0400 [thread overview]
Message-ID: <20200416183244-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20200416075643.27330-6-eperezma@redhat.com>
On Thu, Apr 16, 2020 at 09:56:40AM +0200, Eugenio Pérez wrote:
> As updated in ("2a2d1382fe9d virtio: Add improved queue allocation API")
>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Pls add motivation for these changes.
> ---
> tools/virtio/virtio_test.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/tools/virtio/virtio_test.c b/tools/virtio/virtio_test.c
> index 1d5144590df6..d9827b640c21 100644
> --- a/tools/virtio/virtio_test.c
> +++ b/tools/virtio/virtio_test.c
> @@ -106,10 +106,9 @@ static void vq_info_add(struct vdev_info *dev, int num)
> assert(r >= 0);
> memset(info->ring, 0, vring_legacy_size(num, 4096));
> vring_legacy_init(&info->vring, num, info->ring, 4096);
> - info->vq = vring_new_virtqueue(info->idx,
> - info->vring.num, 4096, &dev->vdev,
> - true, false, info->ring,
> - vq_notify, vq_callback, "test");
> + info->vq =
> + __vring_new_virtqueue(info->idx, info->vring, &dev->vdev, true,
> + false, vq_notify, vq_callback, "test");
> assert(info->vq);
> info->vq->priv = info;
> vhost_vq_setup(dev, info);
> --
> 2.18.1
next prev parent reply other threads:[~2020-04-16 22:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 7:56 [PATCH v2 0/8] tools/vhost: Reset virtqueue on tests Eugenio Pérez
2020-04-16 7:56 ` [PATCH v2 1/8] tools/virtio: fix virtio_test.c indentation Eugenio Pérez
2020-04-16 7:56 ` [PATCH v2 2/8] vhost: Not cleaning batched descs in VHOST_SET_VRING_BASE ioctl Eugenio Pérez
2020-04-16 7:56 ` [PATCH v2 3/8] vhost: Replace vq->private_data access by backend accesors Eugenio Pérez
2020-04-16 7:56 ` [PATCH v2 4/8] vhost: Fix bad order in vhost_test_set_backend at enable Eugenio Pérez
2020-04-16 7:56 ` [PATCH v2 5/8] tools/virtio: Use __vring_new_virtqueue in virtio_test.c Eugenio Pérez
2020-04-16 22:32 ` Michael S. Tsirkin [this message]
2020-04-17 12:24 ` Eugenio Perez Martin
2020-04-16 7:56 ` [PATCH v2 6/8] tools/virtio: Extract virtqueue initialization in vq_reset Eugenio Pérez
2020-04-16 7:56 ` [PATCH v2 7/8] tools/virtio: Reset index in virtio_test --reset Eugenio Pérez
2020-04-16 22:33 ` Michael S. Tsirkin
2020-04-17 7:04 ` Eugenio Perez Martin
2020-04-17 8:28 ` Michael S. Tsirkin
2020-04-16 7:56 ` [PATCH v2 8/8] tools/virtio: Use tools/include/list.h instead of stubs Eugenio Pérez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416183244-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=eperezma@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).