virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Duyck <alexander.duyck@gmail.com>
To: jasowang@redhat.com, david@redhat.com, mst@redhat.com
Cc: virtio-dev@lists.oasis-open.org,
	virtualization@lists.linux-foundation.org
Subject: [PATCH] virtio-balloon: Disable free page hinting/reporting if page poison is disabled
Date: Thu, 16 Apr 2020 12:30:38 -0700	[thread overview]
Message-ID: <20200416192809.8763.19308.stgit@localhost.localdomain> (raw)

From: Alexander Duyck <alexander.h.duyck@linux.intel.com>

If we have free page hinting or page reporting enabled we should disable it
if the pages are poisoned or initialized on free and we cannot notify the
hypervisor.

Fixes: 5d757c8d518d ("virtio-balloon: add support for providing free page reports to host")

Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
---
 drivers/virtio/virtio_balloon.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index 95d9c2f0a7be..08bc86a6e468 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -1110,8 +1110,12 @@ static int virtballoon_validate(struct virtio_device *vdev)
 	/* Tell the host whether we care about poisoned pages. */
 	if (!want_init_on_free() &&
 	    (IS_ENABLED(CONFIG_PAGE_POISONING_NO_SANITY) ||
-	     !page_poisoning_enabled()))
+	     !page_poisoning_enabled())) {
 		__virtio_clear_bit(vdev, VIRTIO_BALLOON_F_PAGE_POISON);
+	} else if (!virtio_has_feature(vdev, VIRTIO_BALLOON_F_PAGE_POISON)) {
+		__virtio_clear_bit(vdev, VIRTIO_BALLOON_F_FREE_PAGE_HINT);
+		__virtio_clear_bit(vdev, VIRTIO_BALLOON_F_REPORTING);
+	}
 
 	__virtio_clear_bit(vdev, VIRTIO_F_IOMMU_PLATFORM);
 	return 0;

             reply	other threads:[~2020-04-16 19:30 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-16 19:30 Alexander Duyck [this message]
2020-04-16 22:13 ` [PATCH] virtio-balloon: Disable free page hinting/reporting if page poison is disabled Michael S. Tsirkin
2020-04-16 23:52   ` Alexander Duyck
2020-04-17  6:28     ` Michael S. Tsirkin
2020-04-17  7:49       ` [virtio-dev] " David Hildenbrand
2020-04-17  8:50         ` Michael S. Tsirkin
2020-04-17  9:07           ` David Hildenbrand
2020-04-17  9:21             ` Michael S. Tsirkin
2020-04-17  9:51               ` David Hildenbrand
2020-04-17  9:59                 ` Michael S. Tsirkin
2020-04-17 10:09                   ` David Hildenbrand
2020-04-17 10:19                     ` [virtio-dev] " Michael S. Tsirkin
2020-04-17 10:26                       ` David Hildenbrand
2020-04-17 10:29                         ` Michael S. Tsirkin
2020-04-17 10:31                           ` David Hildenbrand
2020-04-17 11:02                             ` Michael S. Tsirkin
2020-04-17 11:18                               ` David Hildenbrand
2020-04-17 16:22                     ` Alexander Duyck
2020-04-20 13:28                       ` David Hildenbrand
2020-04-20 18:32                         ` Alexander Duyck
2020-04-21  7:29                           ` David Hildenbrand
2020-04-21 15:05                             ` Alexander Duyck
2020-04-21 15:18                               ` [virtio-dev] " David Hildenbrand
2020-04-21 15:50                                 ` Alexander Duyck
2020-04-22 10:24                                   ` David Hildenbrand
2020-04-22 15:49                                     ` Alexander Duyck
2020-04-17  7:46 ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200416192809.8763.19308.stgit@localhost.localdomain \
    --to=alexander.duyck@gmail.com \
    --cc=david@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).