From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Philippe Brucker Subject: Re: [PATCH] iommu/virtio: reverse arguments to list_add Date: Wed, 6 May 2020 11:35:24 +0200 Message-ID: <20200506093524.GA497896@myrica> References: <1588704467-13431-1-git-send-email-Julia.Lawall@inria.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1588704467-13431-1-git-send-email-Julia.Lawall@inria.fr> Sender: kernel-janitors-owner@vger.kernel.org To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, Joerg Roedel , virtualization@lists.linux-foundation.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, eugene.volanschi@inria.fr List-Id: virtualization@lists.linuxfoundation.org On Tue, May 05, 2020 at 08:47:47PM +0200, Julia Lawall wrote: > Elsewhere in the file, there is a list_for_each_entry with > &vdev->resv_regions as the second argument, suggesting that > &vdev->resv_regions is the list head. So exchange the > arguments on the list_add call to put the list head in the > second argument. > > Fixes: 2a5a31487445 ("iommu/virtio: Add probe request") > Signed-off-by: Julia Lawall Thanks for the fix. The reason this hasn't blown up so far is iommu_alloc_resv_region() initializes region->list, but adding more than one item would break the list. Reviewed-by: Jean-Philippe Brucker > --- > drivers/iommu/virtio-iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/virtio-iommu.c b/drivers/iommu/virtio-iommu.c > index d5cac4f46ca5..4e1d11af23c8 100644 > --- a/drivers/iommu/virtio-iommu.c > +++ b/drivers/iommu/virtio-iommu.c > @@ -453,7 +453,7 @@ static int viommu_add_resv_mem(struct viommu_endpoint *vdev, > if (!region) > return -ENOMEM; > > - list_add(&vdev->resv_regions, ®ion->list); > + list_add(®ion->list, &vdev->resv_regions); > return 0; > } > >