Re: [PATCH v3 24/75] x86/boot/compressed/64: Unmap GHCB page before booting the kernel

Joerg Roedel
2020-05-13T11:30:11Z

On Wed, May 13, 2020 at 01:13:40PM +0200, Borislav Petkov wrote:
> On Tue, Apr 28, 2020 at 05:16:34PM +0200, Joerg Roedel wrote:
> > @@ -302,9 +313,13 @@ void do_boot_page_fault(struct pt_regs *regs, unsigned long error_code)
> > * - User faults
> > * - Reserved bits set
> > */
> > - if (error_code & (X86_PF_PROT | X86_PF_USER | X86_PF_RSVD)) {
> > + if (ghcb_fault ||
> > + error_code & (X86_PF_PROT | X86_PF_USER | X86_PF_RSVD)) {
> > /* Print some information for debugging */
> > - error_putstr("Unexpected page-fault:");
> > + if (ghcb_fault)
> > + error_putstr("Page-fault on GHCB page:");
> > + else
> > + error_putstr("Unexpected page-fault:");
>
> You could carve out the info dumping into a separate function to
> unclutter this if-statement (diff ontop):

Yeah, I had this this way in v2, but changed it upon you request[1] :)

Joerg

[1] https://lore.kernel.org/lkml/20200402114941.GA9352@zn.tnic/