virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
To: Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Jann Horn <jannh-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	"Catangiu,
	Adrian Costin" <acatan-vV1OtcyAfmbQT0dZR+AlfA@public.gmane.org>,
	"linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org"
	<linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
	"linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
	<virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	"linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org"
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	"rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org"
	<rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>,
	"len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
	<len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"fweimer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
	<fweimer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org"
	<keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	"luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org"
	<luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>,
	"wad-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org"
	<wad-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	"mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"bonzini-mXXj517/zsQ@public.gmane.org"
	<bonzini-mXXj517/zsQ@public.gmane.org>, "Graf (AWS),
	Alexander" <graf-ebkRAfMGSJGzQB+pC5nmwQ@public.gmane.org>
Subject: Re: [RFC]: mm,power: introduce MADV_WIPEONSUSPEND
Date: Tue, 7 Jul 2020 10:07:26 +0200	[thread overview]
Message-ID: <20200707080726.GA32357@amd> (raw)
In-Reply-To: <20200707073823.GA3820-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]

Hi!

> > > > This patch adds logic to the kernel power code to zero out contents of
> > > > all MADV_WIPEONSUSPEND VMAs present in the system during its transition
> > > > to any suspend state equal or greater/deeper than Suspend-to-memory,
> > > > known as S3.
> > >
> > > How does the application learn that its memory got wiped? S2disk is an
> > > async operation and it can happen at any time during the task execution.
> > > So how does the application work to prevent from corrupted state - e.g.
> > > when suspended between two memory loads?
> > 
> > You can do it seqlock-style, kind of - you reserve the first byte of
> > the page or so as a "is this page initialized" marker, and after every
> > read from the page, you do a compiler barrier and check whether that
> > byte has been cleared.
> 
> This is certainly possible yet wery awkwar interface to use IMHO.
> MADV_EXTERNALY_VOLATILE would express the actual semantic much better.
> I might not still understand the expected usecase but if the target
> application has to be changed anyway then why not simply use a
> transparent and proper signaling mechanism like poll on a fd. That

The goal is to have cryprographically-safe get_random_number() with 0
syscalls.

You'd need to do:

   if (!poll(did_i_migrate)) {
         use_prng_seed();
	 if (poll(did_i_migrate)) {
	       /* oops_they_migrated_me_in_middle_of_computation,
 	          lets_redo_it() */
 		  goto retry:
	 }
   }

Which means two syscalls..

Best regards,


									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  parent reply	other threads:[~2020-07-07  8:07 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-03 10:34 [RFC]: mm,power: introduce MADV_WIPEONSUSPEND Catangiu, Adrian Costin
     [not found] ` <B7793B7A-3660-4769-9B9A-FFCF250728BB-vV1OtcyAfmbQT0dZR+AlfA@public.gmane.org>
2020-07-03 11:04   ` Jann Horn
     [not found]     ` <CAG48ez2CpHX9i3YgkNyMHPz63ohjkaSZscMtwSHOFYN4VQow3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-07-04  1:33       ` Colm MacCárthaigh
2020-07-06 12:09       ` Alexander Graf
2020-07-03 11:30   ` Michal Hocko
     [not found]     ` <20200703113026.GT18446-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-07-03 12:17       ` Rafael J. Wysocki
     [not found]         ` <CAJZ5v0g+ip-EuUsoK646W-jVSSUhbnvHKsWmFH0+F1w0oYSmGw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-07-03 22:39           ` Pavel Machek
2020-07-03 13:29       ` Jann Horn
     [not found]         ` <CAG48ez2O2z4L=n57Omwy6s1sWQkdTkPKiikhbfdVhiyd_TGRRw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-07-03 22:34           ` Pavel Machek
2020-07-03 22:53             ` Jann Horn
2020-07-07  7:38           ` Michal Hocko
     [not found]             ` <20200707073823.GA3820-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-07-07  8:07               ` Pavel Machek [this message]
2020-07-07  8:58                 ` Michal Hocko
     [not found]                   ` <20200707085847.GA5913-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-07-07 16:37                     ` Pavel Machek
     [not found]                       ` <E6B41570-E206-4458-921B-465B9EF74949@amazon.com>
     [not found]                         ` <E6B41570-E206-4458-921B-465B9EF74949-vV1OtcyAfmbQT0dZR+AlfA@public.gmane.org>
2020-07-12  7:22                           ` Pavel Machek
2020-07-13  8:02                             ` Michal Hocko
2020-07-04  1:45       ` Colm MacCárthaigh
     [not found]         ` <BC9E44B2-D3C2-43C7-8F4B-A31477147368-vV1OtcyAfmbQT0dZR+AlfA@public.gmane.org>
2020-07-07  7:40           ` Michal Hocko
2020-07-03 22:44   ` Pavel Machek
2020-07-03 22:56     ` Jann Horn
     [not found]       ` <CAG48ez0oWQd42a-H-Dzw1Wq7HgB5PpFRGCZeYxP8ohxaoZHmvQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-07-04 11:48         ` Pavel Machek
2020-07-06 12:26           ` Alexander Graf
     [not found]             ` <57ab4fb3-3f82-d34f-ad74-2214b45a4dd9-vV1OtcyAfmbQT0dZR+AlfA@public.gmane.org>
2020-07-06 12:52               ` Jann Horn
     [not found]                 ` <CAG48ez1tAAD+x6n07uCisXpqVpDUPX7xBWiKFkS3u2azHqd41A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-07-06 13:14                   ` Alexander Graf
2020-07-07  7:44                   ` Michal Hocko
     [not found]                     ` <20200707074425.GC3820-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-07-07  8:01                       ` Alexander Graf
     [not found]                         ` <efa55313-ce8a-bac9-15df-167f93c672b3-vV1OtcyAfmbQT0dZR+AlfA@public.gmane.org>
2020-07-07  9:14                           ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200707080726.GA32357@amd \
    --to=pavel-+zi9xunit7i@public.gmane.org \
    --cc=acatan-vV1OtcyAfmbQT0dZR+AlfA@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=bonzini-mXXj517/zsQ@public.gmane.org \
    --cc=fweimer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=graf-ebkRAfMGSJGzQB+pC5nmwQ@public.gmane.org \
    --cc=jannh-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org \
    --cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
    --cc=virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=wad-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).