* [PATCH v2 12/24] scsi: virtio_scsi: Demote seemingly unintentional kerneldoc header [not found] <20200713080001.128044-1-lee.jones@linaro.org> @ 2020-07-13 7:59 ` Lee Jones 2020-07-13 11:23 ` Michael S. Tsirkin 0 siblings, 1 reply; 3+ messages in thread From: Lee Jones @ 2020-07-13 7:59 UTC (permalink / raw) To: jejb, martin.petersen Cc: linux-scsi, Michael S. Tsirkin, linux-kernel, virtualization, Stefan Hajnoczi, Paolo Bonzini, Lee Jones This is the only use of kerneldoc in the sourcefile and no descriptions are provided. Fixes the following W=1 kernel build warning(s): drivers/scsi/virtio_scsi.c:109: warning: Function parameter or member 'vscsi' not described in 'virtscsi_complete_cmd' drivers/scsi/virtio_scsi.c:109: warning: Function parameter or member 'buf' not described in 'virtscsi_complete_cmd' Cc: "Michael S. Tsirkin" <mst@redhat.com> Cc: Jason Wang <jasowang@redhat.com> Cc: Stefan Hajnoczi <stefanha@redhat.com> Cc: virtualization@lists.linux-foundation.org Signed-off-by: Lee Jones <lee.jones@linaro.org> Acked-by: Paolo Bonzini <pbonzini@redhat.com> --- drivers/scsi/virtio_scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 0e0910c5b9424..56875467e4984 100644 --- a/drivers/scsi/virtio_scsi.c +++ b/drivers/scsi/virtio_scsi.c @@ -100,7 +100,7 @@ static void virtscsi_compute_resid(struct scsi_cmnd *sc, u32 resid) scsi_set_resid(sc, resid); } -/** +/* * virtscsi_complete_cmd - finish a scsi_cmd and invoke scsi_done * * Called with vq_lock held. -- 2.25.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 12/24] scsi: virtio_scsi: Demote seemingly unintentional kerneldoc header 2020-07-13 7:59 ` [PATCH v2 12/24] scsi: virtio_scsi: Demote seemingly unintentional kerneldoc header Lee Jones @ 2020-07-13 11:23 ` Michael S. Tsirkin 2020-07-13 11:53 ` Lee Jones 0 siblings, 1 reply; 3+ messages in thread From: Michael S. Tsirkin @ 2020-07-13 11:23 UTC (permalink / raw) To: Lee Jones Cc: linux-scsi, martin.petersen, linux-kernel, virtualization, Stefan Hajnoczi, Paolo Bonzini, jejb On Mon, Jul 13, 2020 at 08:59:49AM +0100, Lee Jones wrote: > This is the only use of kerneldoc in the sourcefile and no > descriptions are provided. > > Fixes the following W=1 kernel build warning(s): > > drivers/scsi/virtio_scsi.c:109: warning: Function parameter or member 'vscsi' not described in 'virtscsi_complete_cmd' > drivers/scsi/virtio_scsi.c:109: warning: Function parameter or member 'buf' not described in 'virtscsi_complete_cmd' > > Cc: "Michael S. Tsirkin" <mst@redhat.com> > Cc: Jason Wang <jasowang@redhat.com> > Cc: Stefan Hajnoczi <stefanha@redhat.com> > Cc: virtualization@lists.linux-foundation.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > Acked-by: Paolo Bonzini <pbonzini@redhat.com> Acked-by: Michael S. Tsirkin <mst@redhat.com> Pls merge with the rest of the patches (which tree is this for?) > --- > drivers/scsi/virtio_scsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c > index 0e0910c5b9424..56875467e4984 100644 > --- a/drivers/scsi/virtio_scsi.c > +++ b/drivers/scsi/virtio_scsi.c > @@ -100,7 +100,7 @@ static void virtscsi_compute_resid(struct scsi_cmnd *sc, u32 resid) > scsi_set_resid(sc, resid); > } > > -/** > +/* > * virtscsi_complete_cmd - finish a scsi_cmd and invoke scsi_done > * > * Called with vq_lock held. > -- > 2.25.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 12/24] scsi: virtio_scsi: Demote seemingly unintentional kerneldoc header 2020-07-13 11:23 ` Michael S. Tsirkin @ 2020-07-13 11:53 ` Lee Jones 0 siblings, 0 replies; 3+ messages in thread From: Lee Jones @ 2020-07-13 11:53 UTC (permalink / raw) To: Michael S. Tsirkin Cc: jejb, martin.petersen, linux-kernel, linux-scsi, Jason Wang, Stefan Hajnoczi, virtualization, Paolo Bonzini On Mon, 13 Jul 2020, Michael S. Tsirkin wrote: > On Mon, Jul 13, 2020 at 08:59:49AM +0100, Lee Jones wrote: > > This is the only use of kerneldoc in the sourcefile and no > > descriptions are provided. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/scsi/virtio_scsi.c:109: warning: Function parameter or member 'vscsi' not described in 'virtscsi_complete_cmd' > > drivers/scsi/virtio_scsi.c:109: warning: Function parameter or member 'buf' not described in 'virtscsi_complete_cmd' > > > > Cc: "Michael S. Tsirkin" <mst@redhat.com> > > Cc: Jason Wang <jasowang@redhat.com> > > Cc: Stefan Hajnoczi <stefanha@redhat.com> > > Cc: virtualization@lists.linux-foundation.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > Acked-by: Paolo Bonzini <pbonzini@redhat.com> > > Acked-by: Michael S. Tsirkin <mst@redhat.com> Thank you Michael. > Pls merge with the rest of the patches (which tree is this for?) My assumption is that Martin will take all of these (and the other sets) via the SCSI repo. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-13 11:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200713080001.128044-1-lee.jones@linaro.org>
2020-07-13 7:59 ` [PATCH v2 12/24] scsi: virtio_scsi: Demote seemingly unintentional kerneldoc header Lee Jones
2020-07-13 11:23 ` Michael S. Tsirkin
2020-07-13 11:53 ` Lee Jones
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).