From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] virtio_balloon: clear modern features under legacy Date: Wed, 15 Jul 2020 05:46:59 -0400 Message-ID: <20200715053808-mutt-send-email-mst@kernel.org> References: <20200710113046.421366-1-mst@redhat.com> <20200712105926-mutt-send-email-mst@kernel.org> <20200714044017-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" To: Alexander Duyck Cc: virtualization@lists.linux-foundation.org, LKML , stable@vger.kernel.org List-Id: virtualization@lists.linuxfoundation.org T24gVHVlLCBKdWwgMTQsIDIwMjAgYXQgMTA6MzE6NTZBTSAtMDcwMCwgQWxleGFuZGVyIER1eWNr IHdyb3RlOgo+IE9uIFR1ZSwgSnVsIDE0LCAyMDIwIGF0IDE6NDUgQU0gTWljaGFlbCBTLiBUc2ly a2luIDxtc3RAcmVkaGF0LmNvbT4gd3JvdGU6Cj4gPgo+ID4gT24gTW9uLCBKdWwgMTMsIDIwMjAg YXQgMDg6MTA6MTRBTSAtMDcwMCwgQWxleGFuZGVyIER1eWNrIHdyb3RlOgo+ID4gPiBPbiBTdW4s IEp1bCAxMiwgMjAyMCBhdCA4OjEwIEFNIE1pY2hhZWwgUy4gVHNpcmtpbiA8bXN0QHJlZGhhdC5j b20+IHdyb3RlOgo+ID4gPiA+Cj4gPiA+ID4gT24gRnJpLCBKdWwgMTAsIDIwMjAgYXQgMDk6MTM6 NDFBTSAtMDcwMCwgQWxleGFuZGVyIER1eWNrIHdyb3RlOgo+ID4gPiA+ID4gT24gRnJpLCBKdWwg MTAsIDIwMjAgYXQgNDozMSBBTSBNaWNoYWVsIFMuIFRzaXJraW4gPG1zdEByZWRoYXQuY29tPiB3 cm90ZToKPiA+ID4gPiA+ID4KPiAKPiA8c25pcD4KPiAKPiA+ID4gPiBBcyB5b3Ugc2F5IGNvcnJl Y3RseSB0aGUgY29tbWFuZCBpZCBpcyBhY3R1YWxseSBhc3N1bWVkIG5hdGl2ZSBlbmRpYW46Cj4g PiA+ID4KPiA+ID4gPgo+ID4gPiA+IHN0YXRpYyB1MzIgdmlydGlvX2JhbGxvb25fY21kX2lkX3Jl Y2VpdmVkKHN0cnVjdCB2aXJ0aW9fYmFsbG9vbiAqdmIpCj4gPiA+ID4gewo+ID4gPiA+ICAgICAg ICAgaWYgKHRlc3RfYW5kX2NsZWFyX2JpdChWSVJUSU9fQkFMTE9PTl9DT05GSUdfUkVBRF9DTURf SUQsCj4gPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZ2Yi0+Y29uZmlnX3Jl YWRfYml0bWFwKSkKPiA+ID4gPiAgICAgICAgICAgICAgICAgdmlydGlvX2NyZWFkKHZiLT52ZGV2 LCBzdHJ1Y3QgdmlydGlvX2JhbGxvb25fY29uZmlnLAo+ID4gPiA+ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgZnJlZV9wYWdlX2hpbnRfY21kX2lkLAo+ID4gPiA+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgJnZiLT5jbWRfaWRfcmVjZWl2ZWRfY2FjaGUpOwo+ID4gPiA+Cj4gPiA+ ID4gICAgICAgICByZXR1cm4gdmItPmNtZF9pZF9yZWNlaXZlZF9jYWNoZTsKPiA+ID4gPiB9Cj4g PiA+ID4KPiA+ID4gPgo+ID4gPiA+IFNvIGd1ZXN0IGFzc3VtZXMgbmF0aXZlLCBob3N0IGFzc3Vt ZXMgTEUuCj4gPiA+Cj4gPiA+IFRoaXMgd2Fzbid0IGV2ZW4gdGhlIG9uZSBJIHdhcyB0YWxraW5n IGFib3V0LCBidXQgbm93IHRoYXQgeW91IHBvaW50Cj4gPiA+IGl0IG91dCB0aGlzIGlzIGRlZmlu YXRlbHkgYnVnLiBUaGUgY29tbWFuZCBJRCBJIHdhcyB0YWxraW5nIGFib3V0IHdhcwo+ID4gPiB0 aGUgb25lIGJlaW5nIHBhc3NlZCB2aWEgdGhlIGRlc2NyaXB0b3IgcmluZy4gVGhhdCBvbmUgSSBi ZWxpZXZlIGlzCj4gPiA+IG5hdGl2ZSBvbiBib3RoIHNpZGVzLgo+ID4KPiA+IFdlbGwgcWVtdSBz d2FwcyBpdCBmb3IgbW9kZXJuIGRldmljZXM6Cj4gPgo+ID4gICAgICAgICB2aXJ0aW9fdHN3YXAz MnModmRldiwgJmlkKTsKPiA+Cj4gPiBndWVzdCBzd2FwcyBpdCB0b286Cj4gPiAgICAgICAgIHZi LT5jbWRfaWRfYWN0aXZlID0gY3B1X3RvX3ZpcnRpbzMyKHZiLT52ZGV2LAo+ID4gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZpcnRpb19iYWxsb29uX2NtZF9pZF9yZWNl aXZlZCh2YikpOwo+ID4gICAgICAgICBzZ19pbml0X29uZSgmc2csICZ2Yi0+Y21kX2lkX2FjdGl2 ZSwgc2l6ZW9mKHZiLT5jbWRfaWRfYWN0aXZlKSk7Cj4gPiAgICAgICAgIGVyciA9IHZpcnRxdWV1 ZV9hZGRfb3V0YnVmKHZxLCAmc2csIDEsICZ2Yi0+Y21kX2lkX2FjdGl2ZSwgR0ZQX0tFUk5FTCk7 Cj4gPgo+ID4gU28gaXQncyBuYXRpdmUgZm9yIGxlZ2FjeS4KPiAKPiBPa2F5LCB0aGF0IG1ha2Vz IHNlbnNlLiBJIGp1c3Qgd2Fzbid0IGZhbWlsaWFyIHdpdGggdGhlIHZpcnRpbzMyIHR5cGUuCj4g Cj4gSSBndWVzcyB0aGF0IGp1c3QgbWVhbnMgd2UgbmVlZCB0byBmaXggdGhlIG9yaWdpbmFsIGlz c3VlIHlvdSBmb3VuZAo+IHdoZXJlIHRoZSBndWVzdCB3YXMgYXNzdW1pbmcgbmF0aXZlIGZvciB0 aGUgY29tbWFuZCBJRCBpbiB0aGUgY29uZmlnLgo+IERvIHlvdSBwbGFuIHRvIHBhdGNoIHRoYXQg b3Igc2hvdWxkIEk/CgpJJ2xsIGRvIGl0LgoKCj4gPiA+ID4KPiA+ID4gPgo+ID4gPiA+Cj4gPiA+ ID4gPiA+IC0tLQo+ID4gPiA+ID4gPiAgZHJpdmVycy92aXJ0aW8vdmlydGlvX2JhbGxvb24uYyB8 IDkgKysrKysrKysrCj4gPiA+ID4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCsp Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3ZpcnRpby92aXJ0 aW9fYmFsbG9vbi5jIGIvZHJpdmVycy92aXJ0aW8vdmlydGlvX2JhbGxvb24uYwo+ID4gPiA+ID4g PiBpbmRleCA1ZDRiODkxYmY4NGYuLmI5YmMwMzM0NTE1NyAxMDA2NDQKPiA+ID4gPiA+ID4gLS0t IGEvZHJpdmVycy92aXJ0aW8vdmlydGlvX2JhbGxvb24uYwo+ID4gPiA+ID4gPiArKysgYi9kcml2 ZXJzL3ZpcnRpby92aXJ0aW9fYmFsbG9vbi5jCj4gPiA+ID4gPiA+IEBAIC0xMTA3LDYgKzExMDcs MTUgQEAgc3RhdGljIGludCB2aXJ0YmFsbG9vbl9yZXN0b3JlKHN0cnVjdCB2aXJ0aW9fZGV2aWNl ICp2ZGV2KQo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiAgc3RhdGljIGludCB2aXJ0YmFsbG9vbl92 YWxpZGF0ZShzdHJ1Y3QgdmlydGlvX2RldmljZSAqdmRldikKPiA+ID4gPiA+ID4gIHsKPiA+ID4g PiA+ID4gKyAgICAgICAvKgo+ID4gPiA+ID4gPiArICAgICAgICAqIExlZ2FjeSBkZXZpY2VzIG5l dmVyIHNwZWNpZmllZCBob3cgbW9kZXJuIGZlYXR1cmVzIHNob3VsZCBiZWhhdmUuCj4gPiA+ID4g PiA+ICsgICAgICAgICogRS5nLiB3aGljaCBlbmRpYW4tbmVzcyB0byB1c2U/IEJldHRlciBub3Qg dG8gYXNzdW1lIGFueXRoaW5nLgo+ID4gPiA+ID4gPiArICAgICAgICAqLwo+ID4gPiA+ID4gPiAr ICAgICAgIGlmICghdmlydGlvX2hhc19mZWF0dXJlKHZkZXYsIFZJUlRJT19GX1ZFUlNJT05fMSkp IHsKPiA+ID4gPiA+ID4gKyAgICAgICAgICAgICAgIF9fdmlydGlvX2NsZWFyX2JpdCh2ZGV2LCBW SVJUSU9fQkFMTE9PTl9GX0ZSRUVfUEFHRV9ISU5UKTsKPiA+ID4gPiA+ID4gKyAgICAgICAgICAg ICAgIF9fdmlydGlvX2NsZWFyX2JpdCh2ZGV2LCBWSVJUSU9fQkFMTE9PTl9GX1BBR0VfUE9JU09O KTsKPiA+ID4gPiA+ID4gKyAgICAgICAgICAgICAgIF9fdmlydGlvX2NsZWFyX2JpdCh2ZGV2LCBW SVJUSU9fQkFMTE9PTl9GX1JFUE9SVElORyk7Cj4gPiA+ID4gPiA+ICsgICAgICAgfQo+ID4gPiA+ ID4gPiAgICAgICAgIC8qCj4gPiA+ID4gPiA+ICAgICAgICAgICogSW5mb3JtIHRoZSBoeXBlcnZp c29yIHRoYXQgb3VyIHBhZ2VzIGFyZSBwb2lzb25lZCBvcgo+ID4gPiA+ID4gPiAgICAgICAgICAq IGluaXRpYWxpemVkLiBJZiB3ZSBjYW5ub3QgZG8gdGhhdCB0aGVuIHdlIHNob3VsZCBkaXNhYmxl Cj4gPiA+ID4gPgo+ID4gPiA+ID4gVGhlIHBhdGNoIGNvbnRlbnQgaXRzZWxmIEkgYW0gZmluZSB3 aXRoIHNpbmNlIG9kZHMgYXJlIG5vYm9keSB3b3VsZAo+ID4gPiA+ID4gZXhwZWN0IHRvIHVzZSB0 aGVzZSBmZWF0dXJlcyB3aXRoIGEgbGVnYWN5IGRldmljZS4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBB Y2tlZC1ieTogQWxleGFuZGVyIER1eWNrIDxhbGV4YW5kZXIuaC5kdXlja0BsaW51eC5pbnRlbC5j b20+Cj4gPiA+ID4KPiA+ID4gPiBIbW0gc28gbm93IHlvdSBwb2ludGVkIG91dCBpdCdzIGp1c3Qg Y21kIGlkLCBtYXliZSBJIHNob3VsZCBqdXN0IGZpeCBpdAo+ID4gPiA+IGluc3RlYWQ/IHdoYXQg ZG8geW91IHNheT8KPiA+ID4KPiA+ID4gU28gdGhlIGNvbmZpZyBpc3N1ZXMgYXJlIGJ1Z3MsIGJ1 dCBJIGRvbid0IHRoaW5rIHlvdSBzYXcgdGhlIG9uZSBJIHdhcwo+ID4gPiB0YWxraW5nIGFib3V0 LiBJbiB0aGUgZnVuY3Rpb24gc2VuZF9jbWRfaWRfc3RhcnQgdGhlIGNtZF9pZF9hY3RpdmUKPiA+ ID4gdmFsdWUgd2hpY2ggaXMgaW5pdGlhbGl6ZWQgYXMgYSB2aXJ0aW8zMiBpcyBhZGRlZCBhcyBh IHNnIGVudHJ5IGFuZAo+ID4gPiB0aGVuIHNlbnQgYXMgYW4gb3V0YnVmIHRvIHRoZSBkZXZpY2Uu IEknbSBhc3N1bWluZyB2aXJ0aW8zMiBpcyBhIGhvc3QKPiA+ID4gbmF0aXZlIGJ5dGUgb3JkZXJp bmcuCj4gPgo+ID4gSUlVQyBpdCBpc24ndCA6KSB2aXJ0aW8zMiBpcyBndWVzdCBuYXRpdmUgaWYg ZGV2aWNlIGlzIGxlZ2FjeSwgYW5kIExFIGlmCj4gPiBkZXZpY2UgaXMgbW9kZXJuLgo+IAo+IE9r YXkuIFNvIEkgc2hvdWxkIHByb2JhYmx5IGRvY3VtZW50IHRoYXQgZm9yIHRoZSBzcGVjIEkgaGF2 ZSBiZWVuCj4gd29ya2luZyBvbi4gSXQgbG9va3MgbGlrZSB0aGVyZSBpcyBhbiBleGFtcGxlIG9m IHNpbWlsYXIgZG9jdW1lbnRhdGlvbgo+IGZvciB0aGUgbWVtb3J5IHN0YXRpc3RpY3Mgc28gaXQg c2hvdWxkIGJlIHByZXR0eSBzdHJhaWdodCBmb3J3YXJkLgo+IAo+IFRoYW5rcy4KPiAKPiAtIEFs ZXgKCiJndWVzdCBuYXRpdmUgaWYgZGV2aWNlIGlzIGxlZ2FjeSwgYW5kIExFIGlmIGRldmljZSBp cyBtb2Rlcm4iCmlzIGEgc3RhbmRhcmQgdmlydGlvIHRoaW5nLiBCYWxsb29uIGhhcyBzcGVjaWFs IGxhbmd1YWdlIHNheWluZwppdHMgY29uZmlnIHNwYWNlIGlzIGFsd2F5cyBMRS4KCgoyLjQuMwoK TGVnYWN5IEludGVyZmFjZTogQSBOb3RlIG9uIERldmljZSBDb25maWd1cmF0aW9uIFNwYWNlIGVu ZGlhbi1uZXNzCk5vdGUgdGhhdCBmb3IgbGVnYWN5IGludGVyZmFjZXMsIGRldmljZSBjb25maWd1 cmF0aW9uIHNwYWNlIGlzIGdlbmVyYWxseSB0aGUgZ3Vlc3TigJlzIG5hdGl2ZSBlbmRpYW4sIHJh dGhlciB0aGFuClBDSeKAmXMgbGl0dGxlLWVuZGlhbi4gVGhlIGNvcnJlY3QgZW5kaWFuLW5lc3Mg aXMgZG9jdW1lbnRlZCBmb3IgZWFjaCBkZXZpY2UuCgoKVGhpcyBsYW5ndWFnZSBjb3VsZCB1c2Ug c29tZSB0d2Vha2luZzogZS5nLiAiUENJIiBoZXJlIHJlZmVycyB0byB0aGUgdGltZSB3aGVuClBD SSB3YXMgdGhlIG9ubHkgdHJhbnNwb3J0LiBBbmQgbW9zdCBkZXZpY2VzIGRvbid0IGRvY3VtZW50 IGVuZGlhbm5lc3MKc28ganVzdCByZWx5IG9uIHN0YW5kYXJkIG9uZS4KCgpTaW1pbGFybHk6Cgoy LjYuMwoKTGVnYWN5IEludGVyZmFjZXM6IEEgTm90ZSBvbiBWaXJ0cXVldWUgRW5kaWFubmVzcwoK Tm90ZSB0aGF0IHdoZW4gdXNpbmcgdGhlIGxlZ2FjeSBpbnRlcmZhY2UsIHRyYW5zaXRpb25hbCBk ZXZpY2VzIGFuZCBkcml2ZXJzIE1VU1QgdXNlIHRoZSBuYXRpdmUgZW5kaWFuIG9mCnRoZSBndWVz dCBhcyB0aGUgZW5kaWFuIG9mIGZpZWxkcyBhbmQgaW4gdGhlIHZpcnRxdWV1ZS4gVGhpcyBpcyBv cHBvc2VkIHRvIGxpdHRsZS1lbmRpYW4gZm9yIG5vbi1sZWdhY3kgaW50ZXJmYWNlCmFzIHNwZWNp ZmllZCBieSB0aGlzIHN0YW5kYXJkLiBJdCBpcyBhc3N1bWVkIHRoYXQgdGhlIGhvc3QgaXMgYWxy ZWFkeSBhd2FyZSBvZiB0aGUgZ3Vlc3QgZW5kaWFuLgoKCkNvdWxkIHVzZSBzb21lIGxvdmUgdG9v LCBlLmcuIGhvc3QgLT4gZGV2aWNlLCBndWVzdCAtPiBkcml2ZXIuCgoKCi0tIApNU1QKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9u IG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpo dHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFs aXphdGlvbg==