virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH v5 00/75] x86: SEV-ES Guest Support
       [not found]     ` <F5603CBB-31FB-4EE8-B67A-A1F2DBEE28D8@vmware.com>
@ 2020-08-18 15:07       ` Joerg Roedel
       [not found]         ` <6F9275F4-D5A4-4D30-8729-A57989568CA7@vmware.com>
  0 siblings, 1 reply; 4+ messages in thread
From: Joerg Roedel @ 2020-08-18 15:07 UTC (permalink / raw)
  To: Mike Stunes
  Cc: Juergen Gross, Tom Lendacky, Dave Hansen, Kees Cook,
	kvm@vger.kernel.org, Peter Zijlstra, Cfir Cohen, x86@kernel.org,
	linux-kernel@vger.kernel.org, Sean Christopherson,
	virtualization@lists.linux-foundation.org, Martin Radev,
	Joerg Roedel, Masami Hiramatsu, Andy Lutomirski, hpa@zytor.com,
	Erdem Aktas, David Rientjes, Dan Williams, Jiri Slaby

Hi Mike,

On Thu, Jul 30, 2020 at 11:23:50PM +0000, Mike Stunes wrote:
> Yes, FSGSBASE was enabled. If I disable it*, this kernel boots fine, with
> both CPUs online.
> 
> *That is, by forcing guest-CPUID[7].EBX bit 0 to 0.

Can you please test whether

	https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git/log/?h=sev-es-client-tip-5.9

still triggers this issue on your side?

Thanks,

	Joerg
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v5 00/75] x86: SEV-ES Guest Support
       [not found]         ` <6F9275F4-D5A4-4D30-8729-A57989568CA7@vmware.com>
@ 2020-08-20 12:10           ` Joerg Roedel
  2020-08-21  8:05           ` Joerg Roedel
  1 sibling, 0 replies; 4+ messages in thread
From: Joerg Roedel @ 2020-08-20 12:10 UTC (permalink / raw)
  To: Mike Stunes
  Cc: Juergen Gross, Tom Lendacky, Dave Hansen, Kees Cook,
	kvm@vger.kernel.org, Peter Zijlstra, Cfir Cohen, Joerg Roedel,
	x86@kernel.org, linux-kernel@vger.kernel.org, Sean Christopherson,
	virtualization@lists.linux-foundation.org, Martin Radev,
	Masami Hiramatsu, Andy Lutomirski, hpa@zytor.com, Erdem Aktas,
	David Rientjes, Dan Williams, Jiri Slaby

Hi Mike,

On Thu, Aug 20, 2020 at 12:58:13AM +0000, Mike Stunes wrote:
> Yes, I still see the issue — APs are offline after boot. I’ll spend
> some time seeing if I can figure out what the problem is. Thanks!

Thanks. I think the first step here would be to find out where on the
APs (which RIP) the first #VC exception happens. I guess in the #VC
entry code it triggers the next exception when trying to execute the
fsgsbase instructions.

Regards,

	Joerg
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v5 00/75] x86: SEV-ES Guest Support
       [not found]         ` <6F9275F4-D5A4-4D30-8729-A57989568CA7@vmware.com>
  2020-08-20 12:10           ` Joerg Roedel
@ 2020-08-21  8:05           ` Joerg Roedel
       [not found]             ` <84EC8E16-5ACD-421D-9B3A-1C80985A1A0B@vmware.com>
  1 sibling, 1 reply; 4+ messages in thread
From: Joerg Roedel @ 2020-08-21  8:05 UTC (permalink / raw)
  To: Mike Stunes
  Cc: Juergen Gross, Tom Lendacky, Dave Hansen, Kees Cook,
	kvm@vger.kernel.org, Peter Zijlstra, Cfir Cohen, x86@kernel.org,
	linux-kernel@vger.kernel.org, Sean Christopherson,
	virtualization@lists.linux-foundation.org, Martin Radev,
	Joerg Roedel, Masami Hiramatsu, Andy Lutomirski, hpa@zytor.com,
	Erdem Aktas, David Rientjes, Dan Williams, Jiri Slaby

Hi Mike,

On Thu, Aug 20, 2020 at 12:58:13AM +0000, Mike Stunes wrote:
> Yes, I still see the issue — APs are offline after boot. I’ll spend
> some time seeing if I can figure out what the problem is. Thanks!

Tom and a few others debugged another FSGSBASE issue yesterday, which I
think might also be the cause for the AP startup problems you are
seeing (if you test on Rome).

Can you try to disable support for RDPID in the guest, but keep fsgsbase
enabled?

Thanks,

	Joerg
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v5 00/75] x86: SEV-ES Guest Support
       [not found]             ` <84EC8E16-5ACD-421D-9B3A-1C80985A1A0B@vmware.com>
@ 2020-08-22 16:30               ` Joerg Roedel
  0 siblings, 0 replies; 4+ messages in thread
From: Joerg Roedel @ 2020-08-22 16:30 UTC (permalink / raw)
  To: Mike Stunes
  Cc: Juergen Gross, Tom Lendacky, Dave Hansen, Kees Cook,
	kvm@vger.kernel.org, Peter Zijlstra, Cfir Cohen, Joerg Roedel,
	x86@kernel.org, linux-kernel@vger.kernel.org, Sean Christopherson,
	virtualization@lists.linux-foundation.org, Martin Radev,
	Masami Hiramatsu, Andy Lutomirski, hpa@zytor.com, Erdem Aktas,
	David Rientjes, Dan Williams, Jiri Slaby

Hi Mike,

On Fri, Aug 21, 2020 at 05:42:16PM +0000, Mike Stunes wrote:
> Yes, that fixes the problem — I can see both CPUs running now. Thanks!

Thanks a lot for testing, good to have this issue resolved.


Regards,

	Joerg
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-08-22 16:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20200724160336.5435-1-joro@8bytes.org>
     [not found] ` <B65392F4-FD42-4AA3-8AA8-6C0C0D1FF007@vmware.com>
     [not found]   ` <20200730122645.GA3257@8bytes.org>
     [not found]     ` <F5603CBB-31FB-4EE8-B67A-A1F2DBEE28D8@vmware.com>
2020-08-18 15:07       ` [PATCH v5 00/75] x86: SEV-ES Guest Support Joerg Roedel
     [not found]         ` <6F9275F4-D5A4-4D30-8729-A57989568CA7@vmware.com>
2020-08-20 12:10           ` Joerg Roedel
2020-08-21  8:05           ` Joerg Roedel
     [not found]             ` <84EC8E16-5ACD-421D-9B3A-1C80985A1A0B@vmware.com>
2020-08-22 16:30               ` Joerg Roedel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).