Re: [PATCH v6 42/76] x86/sev-es: Setup early #VC handler

Juergen Gross via Virtualization
2021-09-06T05:07:58Z

[-- Attachment #1.1.1.1: Type: text/plain, Size: 1155 bytes --]

On 04.09.21 11:39, Lai Jiangshan wrote:
>> @@ -363,6 +370,33 @@ SYM_CODE_START_LOCAL(early_idt_handler_common)
>> jmp restore_regs_and_return_to_kernel
>> SYM_CODE_END(early_idt_handler_common)
>>
>> +#ifdef CONFIG_AMD_MEM_ENCRYPT
>> +/*
>> + * VC Exception handler used during very early boot. The
>> + * early_idt_handler_array can't be used because it returns via the
>> + * paravirtualized INTERRUPT_RETURN and pv-ops don't work that early.
>
> Hello Joerg, Juergen
>
> The commit ae755b5a4548 ("x86/paravirt: Switch iret pvops to ALTERNATIVE")
> ( https://lore.kernel.org/lkml/20210311142319.4723-12-jgross@suse.com/ )
> had been merged and the paravirt_iret is deferenced based via %rip.
>
> Can INTERRUPT_RETURN still be a problem if early_idt_handler_array
> is used instead for bringup IDT?

Even before my patch the dereferencing was done via %rip.

I vaguely remember having discussed the pvops usage with Joerg when he
wrote the SEV support. I'm not sure why pvops shouldn't have worked, but
I'm sure its usage makes no sense at all, as long as we don't have SEV
support for Xen PV guests.

Juergen

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 183 bytes --]