From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C7BC433E6 for ; Tue, 1 Sep 2020 12:10:05 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA32B206EF for ; Tue, 1 Sep 2020 12:10:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA32B206EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 93CA48709C; Tue, 1 Sep 2020 12:10:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8AhrL3ujQdoB; Tue, 1 Sep 2020 12:10:04 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id B84AC8708F; Tue, 1 Sep 2020 12:10:04 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8EB56C0052; Tue, 1 Sep 2020 12:10:04 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1CD9AC0051 for ; Tue, 1 Sep 2020 12:10:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 0C46620427 for ; Tue, 1 Sep 2020 12:10:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i2TRq9PdKwGG for ; Tue, 1 Sep 2020 12:10:01 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by silver.osuosl.org (Postfix) with ESMTPS id 47838203CE for ; Tue, 1 Sep 2020 12:10:01 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 8132A391; Tue, 1 Sep 2020 14:09:57 +0200 (CEST) Date: Tue, 1 Sep 2020 14:09:56 +0200 From: Joerg Roedel To: Borislav Petkov Subject: Re: [PATCH v6 31/76] x86/head/64: Setup MSR_GS_BASE before calling into C code Message-ID: <20200901120956.GA22385@8bytes.org> References: <20200824085511.7553-1-joro@8bytes.org> <20200824085511.7553-32-joro@8bytes.org> <20200828181346.GB19342@zn.tnic> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200828181346.GB19342@zn.tnic> Cc: Juergen Gross , Tom Lendacky , x86@kernel.org, Mike Stunes , Kees Cook , kvm@vger.kernel.org, Peter Zijlstra , Cfir Cohen , Dave Hansen , linux-kernel@vger.kernel.org, Sean Christopherson , virtualization@lists.linux-foundation.org, Martin Radev , Joerg Roedel , Masami Hiramatsu , Andy Lutomirski , hpa@zytor.com, Erdem Aktas , David Rientjes , Dan Williams , Jiri Slaby X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Fri, Aug 28, 2020 at 08:13:46PM +0200, Borislav Petkov wrote: > On Mon, Aug 24, 2020 at 10:54:26AM +0200, Joerg Roedel wrote: > > + movl $MSR_GS_BASE,%ecx > > I'm confused: is this missing those three lines: > > movl initial_gs(%rip),%eax > movl initial_gs+4(%rip),%edx > wrmsr > > as it is done in secondary_startup_64 ? No, it is a leftover from before I moved the MSR write into startup_64_setup_env(). I removed it, thanks for catching this. Regards, Joerg _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization