From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96CE1C433E6 for ; Tue, 1 Sep 2020 13:55:52 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C6D4206EF for ; Tue, 1 Sep 2020 13:55:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C6D4206EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 35CA2204CF; Tue, 1 Sep 2020 13:55:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LmKp1vILFqrD; Tue, 1 Sep 2020 13:55:51 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 388C8204B2; Tue, 1 Sep 2020 13:55:51 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1A244C07FF; Tue, 1 Sep 2020 13:55:51 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id DD58CC0051 for ; Tue, 1 Sep 2020 13:55:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id D56E9204CF for ; Tue, 1 Sep 2020 13:55:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PEPM5U+oLXGM for ; Tue, 1 Sep 2020 13:55:49 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by silver.osuosl.org (Postfix) with ESMTPS id 00DBF204B2 for ; Tue, 1 Sep 2020 13:55:48 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 9D02D391; Tue, 1 Sep 2020 15:55:46 +0200 (CEST) Date: Tue, 1 Sep 2020 15:55:45 +0200 From: Joerg Roedel To: Borislav Petkov Subject: Re: [PATCH v6 69/76] x86/realmode: Setup AP jump table Message-ID: <20200901135545.GE22385@8bytes.org> References: <20200824085511.7553-1-joro@8bytes.org> <20200824085511.7553-70-joro@8bytes.org> <20200831170937.GK27517@zn.tnic> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200831170937.GK27517@zn.tnic> Cc: Juergen Gross , Tom Lendacky , Dave Hansen , Mike Stunes , Kees Cook , kvm@vger.kernel.org, Peter Zijlstra , Cfir Cohen , x86@kernel.org, linux-kernel@vger.kernel.org, Sean Christopherson , virtualization@lists.linux-foundation.org, Martin Radev , Joerg Roedel , Masami Hiramatsu , Andy Lutomirski , hpa@zytor.com, Erdem Aktas , David Rientjes , Dan Williams , Jiri Slaby X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Mon, Aug 31, 2020 at 07:09:37PM +0200, Borislav Petkov wrote: > On Mon, Aug 24, 2020 at 10:55:04AM +0200, Joerg Roedel wrote: > > + /* Check if AP Jump Table is non-zero and page-aligned */ > > + if (!jump_table_addr || jump_table_addr & ~PAGE_MASK) > > + return 0; > > I think you need to return !0 here so that the panic() below fires with > a modified message: > > panic("Failed to get/update SEV-ES AP Jump Table"); > > or are we gonna boot an UP guest still? Right, this needs a !0 return value. This code runs once on the boot CPU before the kernel starts the secondary CPUs, so a panic() is the right thing to do if this fails. Regards, Joerg _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization