From: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
Vincent Whitchurch <vincent.whitchurch@axis.com>,
linux-remoteproc@vger.kernel.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
virtualization@lists.linux-foundation.org,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v5 3/4] rpmsg: update documentation
Date: Thu, 10 Sep 2020 09:18:41 +0200 [thread overview]
Message-ID: <20200910071841.GA17698@ubuntu> (raw)
In-Reply-To: <20200909224521.GC562265@xps15>
On Wed, Sep 09, 2020 at 04:45:21PM -0600, Mathieu Poirier wrote:
> On Wed, Aug 26, 2020 at 07:46:35PM +0200, Guennadi Liakhovetski wrote:
> > rpmsg_create_ept() takes struct rpmsg_channel_info chinfo as its last
> > argument, not a u32 value. The first two arguments are also updated.
> >
> > Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
> > ---
> > Documentation/rpmsg.txt | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/rpmsg.txt b/Documentation/rpmsg.txt
> > index 24b7a9e1a5f9..1ce353cb232a 100644
> > --- a/Documentation/rpmsg.txt
> > +++ b/Documentation/rpmsg.txt
> > @@ -192,9 +192,9 @@ Returns 0 on success and an appropriate error value on failure.
> >
> > ::
> >
> > - struct rpmsg_endpoint *rpmsg_create_ept(struct rpmsg_channel *rpdev,
> > - void (*cb)(struct rpmsg_channel *, void *, int, void *, u32),
> > - void *priv, u32 addr);
> > + struct rpmsg_endpoint *rpmsg_create_ept(struct rpmsg_device *rpdev,
> > + rpmsg_rx_cb_t cb, void *priv,
> > + struct rpmsg_channel_info chinfo);
>
> Again I don't see this being used in this set... It should have been sent on
> its own to the remoteproc and documentation mailing list. Note that
> Documentation/rpmsg.txt is now Documentation/staging/rpmsg.rst
Sure, can send it separately.
Thanks
Guennadi
> > every rpmsg address in the system is bound to an rx callback (so when
> > inbound messages arrive, they are dispatched by the rpmsg bus using the
> > --
> > 2.28.0
> >
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-09-10 7:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 17:46 [PATCH v5 0/4] Add a vhost RPMsg API Guennadi Liakhovetski
2020-08-26 17:46 ` [PATCH v5 1/4] vhost: convert VHOST_VSOCK_SET_RUNNING to a generic ioctl Guennadi Liakhovetski
[not found] ` <20200909224214.GB562265@xps15>
2020-09-10 7:15 ` Guennadi Liakhovetski
[not found] ` <20200910164643.GA579940@xps15>
2020-09-11 7:59 ` Guennadi Liakhovetski
2020-08-26 17:46 ` [PATCH v5 2/4] rpmsg: move common structures and defines to headers Guennadi Liakhovetski
2020-08-26 17:46 ` [PATCH v5 3/4] rpmsg: update documentation Guennadi Liakhovetski
[not found] ` <20200909224521.GC562265@xps15>
2020-09-10 7:18 ` Guennadi Liakhovetski [this message]
2020-09-10 11:19 ` Guennadi Liakhovetski
2020-08-26 17:46 ` [PATCH v5 4/4] vhost: add an RPMsg API Guennadi Liakhovetski
[not found] ` <20200909223946.GA562265@xps15>
2020-09-10 8:38 ` Guennadi Liakhovetski
[not found] ` <20200910172211.GB579940@xps15>
2020-09-11 7:46 ` Guennadi Liakhovetski
[not found] ` <20200911173313.GA613136@xps15>
2020-09-15 12:48 ` Guennadi Liakhovetski
2020-09-08 14:16 ` [PATCH v5 0/4] Add a vhost " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910071841.GA17698@ubuntu \
--to=guennadi.liakhovetski@linux.intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mst@redhat.com \
--cc=ohad@wizery.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=vincent.whitchurch@axis.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).