From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 511CFC43461 for ; Fri, 11 Sep 2020 07:59:25 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEF5E221E5 for ; Fri, 11 Sep 2020 07:59:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEF5E221E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 5E2828775D; Fri, 11 Sep 2020 07:59:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 72CVa4LCXpFI; Fri, 11 Sep 2020 07:59:22 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id DDB12876E2; Fri, 11 Sep 2020 07:59:22 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id CD157C0052; Fri, 11 Sep 2020 07:59:22 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id A87FCC0051 for ; Fri, 11 Sep 2020 07:59:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 805F72050F for ; Fri, 11 Sep 2020 07:59:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id urxR7M1t3EPL for ; Fri, 11 Sep 2020 07:59:19 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by silver.osuosl.org (Postfix) with ESMTPS id 455C320506 for ; Fri, 11 Sep 2020 07:59:19 +0000 (UTC) IronPort-SDR: XKR9gY1pSEUHul5AmmlkClcBoe96QZ8VjDKe174GvsP0i90p5jDPeHAoxfC/TFbJCVu7OGhZFY WT5vIJFuKpdA== X-IronPort-AV: E=McAfee;i="6000,8403,9740"; a="220267407" X-IronPort-AV: E=Sophos;i="5.76,414,1592895600"; d="scan'208";a="220267407" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2020 00:59:18 -0700 IronPort-SDR: iDT9vVAuH2W1PbzfD/zs+OjLyNdr4CigVukWNXDRllpKhMI7QnnLfYbitFQE61Jnlvi3krOJSk OlymXk/fwhSw== X-IronPort-AV: E=Sophos;i="5.76,414,1592895600"; d="scan'208";a="344563126" Received: from gliakhov-mobl2.ger.corp.intel.com (HELO ubuntu) ([10.252.38.203]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2020 00:59:16 -0700 Date: Fri, 11 Sep 2020 09:59:12 +0200 From: Guennadi Liakhovetski To: Mathieu Poirier Subject: Re: [PATCH v5 1/4] vhost: convert VHOST_VSOCK_SET_RUNNING to a generic ioctl Message-ID: <20200911075912.GB26801@ubuntu> References: <20200826174636.23873-1-guennadi.liakhovetski@linux.intel.com> <20200826174636.23873-2-guennadi.liakhovetski@linux.intel.com> <20200909224214.GB562265@xps15> <20200910062144.GA16802@ubuntu> <20200910164643.GA579940@xps15> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200910164643.GA579940@xps15> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Ohad Ben-Cohen , kvm@vger.kernel.org, "Michael S. Tsirkin" , Vincent Whitchurch , linux-remoteproc@vger.kernel.org, Pierre-Louis Bossart , virtualization@lists.linux-foundation.org, Liam Girdwood , Bjorn Andersson , sound-open-firmware@alsa-project.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Thu, Sep 10, 2020 at 10:46:43AM -0600, Mathieu Poirier wrote: > On Thu, Sep 10, 2020 at 09:15:13AM +0200, Guennadi Liakhovetski wrote: > > Hi Mathieu, > > > > On Wed, Sep 09, 2020 at 04:42:14PM -0600, Mathieu Poirier wrote: > > > On Wed, Aug 26, 2020 at 07:46:33PM +0200, Guennadi Liakhovetski wrote: > > > > VHOST_VSOCK_SET_RUNNING is used by the vhost vsock driver to perform > > > > crucial VirtQueue initialisation, like assigning .private fields and > > > > calling vhost_vq_init_access(), and clean up. However, this ioctl is > > > > actually extremely useful for any vhost driver, that doesn't have a > > > > side channel to inform it of a status change, e.g. upon a guest > > > > reboot. This patch makes that ioctl generic, while preserving its > > > > numeric value and also keeping the original alias. > > > > > > > > Signed-off-by: Guennadi Liakhovetski > > > > --- > > > > include/uapi/linux/vhost.h | 4 +++- > > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h > > > > index 75232185324a..11a4948b6216 100644 > > > > --- a/include/uapi/linux/vhost.h > > > > +++ b/include/uapi/linux/vhost.h > > > > @@ -97,6 +97,8 @@ > > > > #define VHOST_SET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x25, __u64) > > > > #define VHOST_GET_BACKEND_FEATURES _IOR(VHOST_VIRTIO, 0x26, __u64) > > > > > > > > +#define VHOST_SET_RUNNING _IOW(VHOST_VIRTIO, 0x61, int) > > > > + > > > > > > I don't see it used in the next patches and as such should be part of another > > > series. > > > > It isn't used in the next patches, it is used in this patch - see below. > > > > Right, but why is this part of this set? What does it bring? It should be part > of a patchset where "VHOST_SET_RUNNING" is used. Ok, I can remove this patch from this series and make it a part of the series, containing [1] "vhost: add an SOF Audio DSP driver" Thanks Guennadi [1] https://www.spinics.net/lists/linux-virtualization/msg43309.html > > > > /* VHOST_NET specific defines */ > > > > > > > > /* Attach virtio net ring to a raw socket, or tap device. > > > > @@ -118,7 +120,7 @@ > > > > /* VHOST_VSOCK specific defines */ > > > > > > > > #define VHOST_VSOCK_SET_GUEST_CID _IOW(VHOST_VIRTIO, 0x60, __u64) > > > > -#define VHOST_VSOCK_SET_RUNNING _IOW(VHOST_VIRTIO, 0x61, int) > > > > +#define VHOST_VSOCK_SET_RUNNING VHOST_SET_RUNNING > > > > > > > > /* VHOST_VDPA specific defines */ > > > > > > > > -- > > > > 2.28.0 > > > > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization