From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B5D8C4727E for ; Wed, 30 Sep 2020 09:47:23 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F8A82074A for ; Wed, 30 Sep 2020 09:47:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="YslZyjVo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F8A82074A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 2828085EC6; Wed, 30 Sep 2020 09:47:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aAiTxS4GDfnj; Wed, 30 Sep 2020 09:47:21 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 6244B86031; Wed, 30 Sep 2020 09:47:21 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 49D07C0889; Wed, 30 Sep 2020 09:47:21 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 87CD4C0051 for ; Wed, 30 Sep 2020 09:47:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 7673685EC6 for ; Wed, 30 Sep 2020 09:47:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Zz-vWpYvLEsq for ; Wed, 30 Sep 2020 09:47:18 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 42D7485AB5 for ; Wed, 30 Sep 2020 09:47:18 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id q9so988704wmj.2 for ; Wed, 30 Sep 2020 02:47:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=mk/10QMoJ+o57Gs0uKBi5jqLBb5COb+Y9kF4IXUlM/Q=; b=YslZyjVoOldROC3jA1fPKGoa2j+xP9ZMNK4SZUeZjFZmxDgc83XfrocubX8z+Ghi0i mxxZbyYhvNo/yzlGV7M9TYWiI6ebmWI5MPFUrLdFH5HEq/1glgvLqigSOT2sZCqvNTzQ 5j2dQDwMw2raEHsSORmptJcNQAmWyQj8NQX/A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=mk/10QMoJ+o57Gs0uKBi5jqLBb5COb+Y9kF4IXUlM/Q=; b=SsODGw+Q0ci7D3uhjHU8vlgQ32UzW6fY0jKfpJ+FnBr8P0Y4pVq4QwstSAeZ8M7P1i DnP9OAZLU9kj6Z5WkHo8vA+7uzT1fsVajZuT4i3QGJ/tnmiwaFVJme7KaXRH+7tHBbhi ngosHEe0i/LIr3IBIvptSNkBEpFtaYf5i+/NevO/IpTE/sE0tn3Psiqrhib6n3xYJul0 xM1wH++B9EH+XtjXsT97Lwy6G7VCt62mOf+l74OEGPEtx+CLMTzgIdy0bUs5h96+NpbH lq6Nzix3Q8zEcvbic/UbvMYxTjZPo6bi1tHcvo945ArmwIWpTUIOCQA4O1I6tzjfDPY3 CCkw== X-Gm-Message-State: AOAM532+uDK63UyU4W/1AvEqxJjQCX+ogdMvbu6MwkUmKX38puLiKFqT JqruLm8XMRnxzfwyPP/iTNh1OQ== X-Google-Smtp-Source: ABdhPJy8QqpQoBX6MWQ3S7YZuW9WMNYB4GRIEped2k61Hp3lacYf00Zpjbck3DpWjhDxW2rcxoc68Q== X-Received: by 2002:a1c:98d8:: with SMTP id a207mr1952908wme.157.1601459236371; Wed, 30 Sep 2020 02:47:16 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id n6sm1769842wmd.22.2020.09.30.02.47.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2020 02:47:15 -0700 (PDT) Date: Wed, 30 Sep 2020 11:47:12 +0200 From: Daniel Vetter To: christian.koenig@amd.com Subject: Re: [PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion Message-ID: <20200930094712.GW438822@phenom.ffwll.local> References: <20200929151437.19717-1-tzimmermann@suse.de> <20200929151437.19717-3-tzimmermann@suse.de> <8fad0114-064a-4ed5-c21d-d1b4294de0a1@amd.com> <2614314a-81f7-4722-c400-68d90e48e09a@suse.de> <8a84f62b-33f3-f44c-52af-c859a0e0d1fb@gmail.com> <07972ada-9135-3743-a86b-487f610c509f@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.7.0-1-amd64 Cc: luben.tuikov@amd.com, heiko@sntech.de, airlied@linux.ie, nouveau@lists.freedesktop.org, linus.walleij@linaro.org, dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk, melissa.srw@gmail.com, eric@anholt.net, ray.huang@amd.com, sam@ravnborg.org, sumit.semwal@linaro.org, emil.velikov@collabora.com, robh@kernel.org, linux-samsung-soc@vger.kernel.org, jy0922.shim@samsung.com, lima@lists.freedesktop.org, oleksandr_andrushchenko@epam.com, krzk@kernel.org, steven.price@arm.com, linux-rockchip@lists.infradead.org, kgene@kernel.org, bskeggs@redhat.com, linux+etnaviv@armlinux.org.uk, spice-devel@lists.freedesktop.org, alyssa.rosenzweig@collabora.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, etnaviv@lists.freedesktop.org, mripard@kernel.org, inki.dae@samsung.com, hdegoede@redhat.com, christian.gmeiner@gmail.com, xen-devel@lists.xenproject.org, virtualization@lists.linux-foundation.org, sean@poorly.run, apaneers@amd.com, linux-arm-kernel@lists.infradead.org, linaro-mm-sig@lists.linaro.org, amd-gfx@lists.freedesktop.org, tomeu.vizoso@collabora.com, sw0312.kim@samsung.com, hjc@rock-chips.com, kyungmin.park@samsung.com, miaoqinglang@huawei.com, yuq825@gmail.com, Thomas Zimmermann , alexander.deucher@amd.com, linux-media@vger.kernel.org, l.stach@pengutronix.de X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Wed, Sep 30, 2020 at 10:34:31AM +0200, Christian K=F6nig wrote: > Am 30.09.20 um 10:19 schrieb Thomas Zimmermann: > > Hi > > = > > Am 30.09.20 um 10:05 schrieb Christian K=F6nig: > > > Am 29.09.20 um 19:49 schrieb Thomas Zimmermann: > > > > Hi Christian > > > > = > > > > Am 29.09.20 um 17:35 schrieb Christian K=F6nig: > > > > > Am 29.09.20 um 17:14 schrieb Thomas Zimmermann: > > > > > > The new helper ttm_kmap_obj_to_dma_buf() extracts address and l= ocation > > > > > > from and instance of TTM's kmap_obj and initializes struct dma_= buf_map > > > > > > with these values. Helpful for TTM-based drivers. > > > > > We could completely drop that if we use the same structure inside= TTM as > > > > > well. > > > > > = > > > > > Additional to that which driver is going to use this? > > > > As Daniel mentioned, it's in patch 3. The TTM-based drivers will > > > > retrieve the pointer via this function. > > > > = > > > > I do want to see all that being more tightly integrated into TTM, b= ut > > > > not in this series. This one is about fixing the bochs-on-sparc64 > > > > problem for good. Patch 7 adds an update to TTM to the DRM TODO lis= t. > > > I should have asked which driver you try to fix here :) > > > = > > > In this case just keep the function inside bochs and only fix it ther= e. > > > = > > > All other drivers can be fixed when we generally pump this through TT= M. > > Did you take a look at patch 3? This function will be used by VRAM > > helpers, nouveau, radeon, amdgpu and qxl. If we don't put it here, we > > have to duplicate the functionality in each if these drivers. Bochs > > itself uses VRAM helpers and doesn't touch the function directly. > = > Ah, ok can we have that then only in the VRAM helpers? > = > Alternative you could go ahead and use dma_buf_map in ttm_bo_kmap_obj > directly and drop the hack with the TTM_BO_MAP_IOMEM_MASK. > = > What I want to avoid is to have another conversion function in TTM because > what happens here is that we already convert from ttm_bus_placement to > ttm_bo_kmap_obj and then to dma_buf_map. Hm I'm not really seeing how that helps with a gradual conversion of everything over to dma_buf_map and assorted helpers for access? There's too many places in ttm drivers where is_iomem and related stuff is used to be able to convert it all in one go. An intermediate state with a bunch of conversions seems fairly unavoidable to me. -Daniel > = > Thanks, > Christian. > = > > = > > Best regards > > Thomas > > = > > > Regards, > > > Christian. > > > = > > > > Best regards > > > > Thomas > > > > = > > > > > Regards, > > > > > Christian. > > > > > = > > > > > > Signed-off-by: Thomas Zimmermann > > > > > > --- > > > > > > =A0 include/drm/ttm/ttm_bo_api.h | 24 ++++++++++++++++++++++++ > > > > > > =A0 include/linux/dma-buf-map.h=A0 | 20 ++++++++++++++++++++ > > > > > > =A0 2 files changed, 44 insertions(+) > > > > > > = > > > > > > diff --git a/include/drm/ttm/ttm_bo_api.h b/include/drm/ttm/ttm= _bo_api.h > > > > > > index c96a25d571c8..62d89f05a801 100644 > > > > > > --- a/include/drm/ttm/ttm_bo_api.h > > > > > > +++ b/include/drm/ttm/ttm_bo_api.h > > > > > > @@ -34,6 +34,7 @@ > > > > > > =A0 #include > > > > > > =A0 #include > > > > > > =A0 #include > > > > > > +#include > > > > > > =A0 #include > > > > > > =A0 #include > > > > > > =A0 #include > > > > > > @@ -486,6 +487,29 @@ static inline void *ttm_kmap_obj_virtual(s= truct > > > > > > ttm_bo_kmap_obj *map, > > > > > > =A0=A0=A0=A0=A0 return map->virtual; > > > > > > =A0 } > > > > > > =A0 +/** > > > > > > + * ttm_kmap_obj_to_dma_buf_map > > > > > > + * > > > > > > + * @kmap: A struct ttm_bo_kmap_obj returned from ttm_bo_kmap. > > > > > > + * @map: Returns the mapping as struct dma_buf_map > > > > > > + * > > > > > > + * Converts struct ttm_bo_kmap_obj to struct dma_buf_map. If t= he memory > > > > > > + * is not mapped, the returned mapping is initialized to NULL. > > > > > > + */ > > > > > > +static inline void ttm_kmap_obj_to_dma_buf_map(struct ttm_bo_k= map_obj > > > > > > *kmap, > > > > > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0 struct dma_buf_map *map) > > > > > > +{ > > > > > > +=A0=A0=A0 bool is_iomem; > > > > > > +=A0=A0=A0 void *vaddr =3D ttm_kmap_obj_virtual(kmap, &is_iomem= ); > > > > > > + > > > > > > +=A0=A0=A0 if (!vaddr) > > > > > > +=A0=A0=A0=A0=A0=A0=A0 dma_buf_map_clear(map); > > > > > > +=A0=A0=A0 else if (is_iomem) > > > > > > +=A0=A0=A0=A0=A0=A0=A0 dma_buf_map_set_vaddr_iomem(map, (void _= _force __iomem *)vaddr); > > > > > > +=A0=A0=A0 else > > > > > > +=A0=A0=A0=A0=A0=A0=A0 dma_buf_map_set_vaddr(map, vaddr); > > > > > > +} > > > > > > + > > > > > > =A0 /** > > > > > > =A0=A0 * ttm_bo_kmap > > > > > > =A0=A0 * > > > > > > diff --git a/include/linux/dma-buf-map.h b/include/linux/dma-bu= f-map.h > > > > > > index fd1aba545fdf..2e8bbecb5091 100644 > > > > > > --- a/include/linux/dma-buf-map.h > > > > > > +++ b/include/linux/dma-buf-map.h > > > > > > @@ -45,6 +45,12 @@ > > > > > > =A0=A0 * > > > > > > =A0=A0 *=A0=A0=A0 dma_buf_map_set_vaddr(&map. 0xdeadbeaf); > > > > > > =A0=A0 * > > > > > > + * To set an address in I/O memory, use dma_buf_map_set_vaddr_= iomem(). > > > > > > + * > > > > > > + * .. code-block:: c > > > > > > + * > > > > > > + *=A0=A0=A0 dma_buf_map_set_vaddr_iomem(&map. 0xdeadbeaf); > > > > > > + * > > > > > > =A0=A0 * Test if a mapping is valid with either dma_buf_map_is= _set() or > > > > > > =A0=A0 * dma_buf_map_is_null(). > > > > > > =A0=A0 * > > > > > > @@ -118,6 +124,20 @@ static inline void dma_buf_map_set_vaddr(s= truct > > > > > > dma_buf_map *map, void *vaddr) > > > > > > =A0=A0=A0=A0=A0 map->is_iomem =3D false; > > > > > > =A0 } > > > > > > =A0 +/** > > > > > > + * dma_buf_map_set_vaddr_iomem - Sets a dma-buf mapping struct= ure to > > > > > > an address in I/O memory > > > > > > + * @map:=A0=A0=A0=A0=A0=A0=A0 The dma-buf mapping structure > > > > > > + * @vaddr_iomem:=A0=A0=A0 An I/O-memory address > > > > > > + * > > > > > > + * Sets the address and the I/O-memory flag. > > > > > > + */ > > > > > > +static inline void dma_buf_map_set_vaddr_iomem(struct dma_buf_= map *map, > > > > > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0 void __iomem *vaddr_iomem) > > > > > > +{ > > > > > > +=A0=A0=A0 map->vaddr_iomem =3D vaddr_iomem; > > > > > > +=A0=A0=A0 map->is_iomem =3D true; > > > > > > +} > > > > > > + > > > > > > =A0 /** > > > > > > =A0=A0 * dma_buf_map_is_equal - Compares two dma-buf mapping s= tructures > > > > > > for equality > > > > > > =A0=A0 * @lhs:=A0=A0=A0 The dma-buf mapping structure > > > > > _______________________________________________ > > > > > dri-devel mailing list > > > > > dri-devel@lists.freedesktop.org > > > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > _______________________________________________ > > > > amd-gfx mailing list > > > > amd-gfx@lists.freedesktop.org > > > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx > > > = > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > = > > = > > _______________________________________________ > > amd-gfx mailing list > > amd-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx > = -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization