From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41EA0C433E7 for ; Mon, 19 Oct 2020 15:14:56 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C8C42231B for ; Mon, 19 Oct 2020 15:14:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="MtCaBtJ5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C8C42231B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id AC19B20343; Mon, 19 Oct 2020 15:14:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1cj5U1zMHidu; Mon, 19 Oct 2020 15:14:53 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 9550520198; Mon, 19 Oct 2020 15:14:53 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 757F2C0052; Mon, 19 Oct 2020 15:14:53 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4792BC0051 for ; Mon, 19 Oct 2020 15:14:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 338662DE2A for ; Mon, 19 Oct 2020 15:14:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4VLtbiLTZvn2 for ; Mon, 19 Oct 2020 15:14:26 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by silver.osuosl.org (Postfix) with ESMTPS id 71F0C2D946 for ; Mon, 19 Oct 2020 15:14:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fPKhjFvX7s/li2p5PnTaBWubB/m1Dx3gc5qTCRzUVAE=; b=MtCaBtJ5IQ/x8oDWOCevBkygCj yEzyrsbN8NZUeRsNLZye91Ax14G4cADucQGCclbpc63l9DfUMm5hQ7fR+1N0RM34GBucA2FALk3kI qZpJHTNFSqLHo5DKTcrLrym4Kqtfb6GfHSLCojwq7Btx02s2pGX6M76pPttye73CTeoBwibx4xEYe 5iCtKZmQTiLNmnbgs+7dNsuqiySxQSijkfd33Z60uD/z3rG5dHM8aGYhIxcctDeeM008zH3xPltyV JsHS34NYRkM/XY3Zp/3wzmfxMHBSrX0WZu0awfp8zxFN5L1NM40NbTaIFGgs3knyLheYTnLVsJce2 0cAbqNQg==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUWra-0008TX-8b; Mon, 19 Oct 2020 15:14:19 +0000 Date: Mon, 19 Oct 2020 16:14:18 +0100 From: Matthew Wilcox To: Xie Yongji Subject: Re: [RFC 1/4] mm: export zap_page_range() for driver use Message-ID: <20201019151418.GT20115@casper.infradead.org> References: <20201019145623.671-1-xieyongji@bytedance.com> <20201019145623.671-2-xieyongji@bytedance.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201019145623.671-2-xieyongji@bytedance.com> Cc: linux-mm@kvack.org, virtualization@lists.linux-foundation.org, akpm@linux-foundation.org, mst@redhat.com X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Mon, Oct 19, 2020 at 10:56:20PM +0800, Xie Yongji wrote: > Export zap_page_range() for use in VDUSE. I think you're missing a lot of MMU notifier work by calling this directly. It probably works in every scenario you've tested, but won't work for others. I see you're using VM_MIXEDMAP -- would it make sense to use VM_PFNMAP instead and use zap_vma_ptes()? Or would it make sense to change zap_vma_ptes() to handle VM_MIXEDMAP as well as VM_PFNMAP? _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization