From: Sam Ravnborg <sam@ravnborg.org>
To: trix@redhat.com
Cc: tzimmermann@suse.de, airlied@linux.ie,
nouveau@lists.freedesktop.org, gustavoars@kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
daniel@ffwll.ch, spice-devel@lists.freedesktop.org,
airlied@redhat.com, virtualization@lists.linux-foundation.org,
bskeggs@redhat.com
Subject: Re: [PATCH] drm: remove unneeded break
Date: Mon, 19 Oct 2020 19:06:41 +0200 [thread overview]
Message-ID: <20201019170641.GA963808@ravnborg.org> (raw)
In-Reply-To: <20201019163115.25814-1-trix@redhat.com>
Hi Tom
On Mon, Oct 19, 2020 at 09:31:15AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return or break
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Looks good and builds with no warnings.
One of the diffs made me - "oh this looks wrong". But after I looked again
it was right and the resulting code is more readable - so good.
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Was tempted to just apply to drm-misc-next but will give others the
opportunity to chime in.
Sam
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next parent reply other threads:[~2020-10-19 17:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201019163115.25814-1-trix@redhat.com>
2020-10-19 17:06 ` Sam Ravnborg [this message]
2020-11-08 17:59 ` [PATCH] drm: remove unneeded break Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019170641.GA963808@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavoars@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=spice-devel@lists.freedesktop.org \
--cc=trix@redhat.com \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).