From: "Michael S. Tsirkin" <mst@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kbuild-all@lists.01.org, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com,
virtualization@lists.linux-foundation.org,
target-devel@vger.kernel.org, stefanha@redhat.com,
pbonzini@redhat.com, kbuild@lists.01.org,
Mike Christie <michael.christie@oracle.com>,
lkp@intel.com
Subject: Re: [PATCH 04/16] vhost: prep vhost_dev_init users to handle failures
Date: Fri, 23 Oct 2020 11:56:53 -0400 [thread overview]
Message-ID: <20201023115635-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20201009114126.GI1042@kadam>
On Fri, Oct 09, 2020 at 02:41:26PM +0300, Dan Carpenter wrote:
> Hi Mike,
>
> url: https://github.com/0day-ci/linux/commits/Mike-Christie/vhost-fix-scsi-cmd-handling-and-IOPs/20201008-045802
> base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
> config: x86_64-randconfig-m001-20201008 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> New smatch warnings:
> drivers/vhost/vdpa.c:844 vhost_vdpa_open() error: uninitialized symbol 'r'.
>
> Old smatch warnings:
> drivers/vhost/vdpa.c:436 vhost_vdpa_unlocked_ioctl() warn: maybe return -EFAULT instead of the bytes remaining?
> drivers/vhost/vdpa.c:489 vhost_vdpa_unlocked_ioctl() warn: maybe return -EFAULT instead of the bytes remaining?
>
> vim +/r +844 drivers/vhost/vdpa.c
>
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 793 static int vhost_vdpa_open(struct inode *inode, struct file *filep)
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 794 {
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 795 struct vhost_vdpa *v;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 796 struct vhost_dev *dev;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 797 struct vhost_virtqueue **vqs;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 798 int nvqs, i, r, opened;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 799
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 800 v = container_of(inode->i_cdev, struct vhost_vdpa, cdev);
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 801
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 802 opened = atomic_cmpxchg(&v->opened, 0, 1);
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 803 if (opened)
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 804 return -EBUSY;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 805
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 806 nvqs = v->nvqs;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 807 vhost_vdpa_reset(v);
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 808
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 809 vqs = kmalloc_array(nvqs, sizeof(*vqs), GFP_KERNEL);
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 810 if (!vqs) {
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 811 r = -ENOMEM;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 812 goto err;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 813 }
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 814
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 815 dev = &v->vdev;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 816 for (i = 0; i < nvqs; i++) {
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 817 vqs[i] = &v->vqs[i];
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 818 vqs[i]->handle_kick = handle_vq_kick;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 819 }
> 7dc4d1082d406f3 Mike Christie 2020-10-07 820 if (vhost_dev_init(dev, vqs, nvqs, 0, 0, 0, false,
> 7dc4d1082d406f3 Mike Christie 2020-10-07 821 vhost_vdpa_process_iotlb_msg))
> 7dc4d1082d406f3 Mike Christie 2020-10-07 822 goto err_dev_init;
>
> "r" not set on this error path.
>
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 823
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 824 dev->iotlb = vhost_iotlb_alloc(0, 0);
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 825 if (!dev->iotlb) {
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 826 r = -ENOMEM;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 827 goto err_init_iotlb;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 828 }
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 829
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 830 r = vhost_vdpa_alloc_domain(v);
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 831 if (r)
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 832 goto err_init_iotlb;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 833
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 834 filep->private_data = v;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 835
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 836 return 0;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 837
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 838 err_init_iotlb:
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 839 vhost_dev_cleanup(&v->vdev);
> 7dc4d1082d406f3 Mike Christie 2020-10-07 840 err_dev_init:
> 37787e9f81e2e58 Mike Christie 2020-09-21 841 kfree(vqs);
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 842 err:
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 843 atomic_dec(&v->opened);
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 @844 return r;
> 4c8cf31885f69e8 Tiwei Bie 2020-03-26 845 }
Yes looks like it would use r uninitialized ...
Mike?
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
prev parent reply other threads:[~2020-10-23 15:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1602104101-5592-5-git-send-email-michael.christie@oracle.com>
2020-10-08 0:58 ` [PATCH 04/16] vhost: prep vhost_dev_init users to handle failures kernel test robot
2020-10-09 11:41 ` Dan Carpenter
2020-10-23 15:56 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023115635-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).