* Re: [PATCH 04/16] vhost: prep vhost_dev_init users to handle failures
[not found] <1602104101-5592-5-git-send-email-michael.christie@oracle.com>
@ 2020-10-08 0:58 ` kernel test robot
2020-10-09 11:41 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2020-10-08 0:58 UTC (permalink / raw)
To: Mike Christie, martin.petersen, linux-scsi, target-devel, mst,
jasowang, pbonzini, stefanha, virtualization
Cc: clang-built-linux, kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3952 bytes --]
Hi Mike,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on vhost/linux-next]
[also build test WARNING on next-20201007]
[cannot apply to v5.9-rc8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mike-Christie/vhost-fix-scsi-cmd-handling-and-IOPs/20201008-045802
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: x86_64-randconfig-a016-20201008 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 4d1d8ae7100ec3c7e1709addb7b3ec6f9ad0b44f)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/7dc4d1082d406f391238a1897cb030f33c382bc3
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mike-Christie/vhost-fix-scsi-cmd-handling-and-IOPs/20201008-045802
git checkout 7dc4d1082d406f391238a1897cb030f33c382bc3
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/vhost/vdpa.c:820:6: warning: variable 'r' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (vhost_dev_init(dev, vqs, nvqs, 0, 0, 0, false,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/vhost/vdpa.c:844:9: note: uninitialized use occurs here
return r;
^
drivers/vhost/vdpa.c:820:2: note: remove the 'if' if its condition is always false
if (vhost_dev_init(dev, vqs, nvqs, 0, 0, 0, false,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/vhost/vdpa.c:798:16: note: initialize the variable 'r' to silence this warning
int nvqs, i, r, opened;
^
= 0
1 warning generated.
vim +820 drivers/vhost/vdpa.c
792
793 static int vhost_vdpa_open(struct inode *inode, struct file *filep)
794 {
795 struct vhost_vdpa *v;
796 struct vhost_dev *dev;
797 struct vhost_virtqueue **vqs;
798 int nvqs, i, r, opened;
799
800 v = container_of(inode->i_cdev, struct vhost_vdpa, cdev);
801
802 opened = atomic_cmpxchg(&v->opened, 0, 1);
803 if (opened)
804 return -EBUSY;
805
806 nvqs = v->nvqs;
807 vhost_vdpa_reset(v);
808
809 vqs = kmalloc_array(nvqs, sizeof(*vqs), GFP_KERNEL);
810 if (!vqs) {
811 r = -ENOMEM;
812 goto err;
813 }
814
815 dev = &v->vdev;
816 for (i = 0; i < nvqs; i++) {
817 vqs[i] = &v->vqs[i];
818 vqs[i]->handle_kick = handle_vq_kick;
819 }
> 820 if (vhost_dev_init(dev, vqs, nvqs, 0, 0, 0, false,
821 vhost_vdpa_process_iotlb_msg))
822 goto err_dev_init;
823
824 dev->iotlb = vhost_iotlb_alloc(0, 0);
825 if (!dev->iotlb) {
826 r = -ENOMEM;
827 goto err_init_iotlb;
828 }
829
830 r = vhost_vdpa_alloc_domain(v);
831 if (r)
832 goto err_init_iotlb;
833
834 filep->private_data = v;
835
836 return 0;
837
838 err_init_iotlb:
839 vhost_dev_cleanup(&v->vdev);
840 err_dev_init:
841 kfree(vqs);
842 err:
843 atomic_dec(&v->opened);
844 return r;
845 }
846
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32180 bytes --]
[-- Attachment #3: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 04/16] vhost: prep vhost_dev_init users to handle failures
[not found] <1602104101-5592-5-git-send-email-michael.christie@oracle.com>
2020-10-08 0:58 ` [PATCH 04/16] vhost: prep vhost_dev_init users to handle failures kernel test robot
@ 2020-10-09 11:41 ` Dan Carpenter
2020-10-23 15:56 ` Michael S. Tsirkin
1 sibling, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2020-10-09 11:41 UTC (permalink / raw)
To: kbuild, Mike Christie, martin.petersen, linux-scsi, target-devel,
mst, jasowang, pbonzini, stefanha, virtualization
Cc: kbuild-all, lkp
[-- Attachment #1: Type: text/plain, Size: 4484 bytes --]
Hi Mike,
url: https://github.com/0day-ci/linux/commits/Mike-Christie/vhost-fix-scsi-cmd-handling-and-IOPs/20201008-045802
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: x86_64-randconfig-m001-20201008 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/vhost/vdpa.c:844 vhost_vdpa_open() error: uninitialized symbol 'r'.
Old smatch warnings:
drivers/vhost/vdpa.c:436 vhost_vdpa_unlocked_ioctl() warn: maybe return -EFAULT instead of the bytes remaining?
drivers/vhost/vdpa.c:489 vhost_vdpa_unlocked_ioctl() warn: maybe return -EFAULT instead of the bytes remaining?
vim +/r +844 drivers/vhost/vdpa.c
4c8cf31885f69e8 Tiwei Bie 2020-03-26 793 static int vhost_vdpa_open(struct inode *inode, struct file *filep)
4c8cf31885f69e8 Tiwei Bie 2020-03-26 794 {
4c8cf31885f69e8 Tiwei Bie 2020-03-26 795 struct vhost_vdpa *v;
4c8cf31885f69e8 Tiwei Bie 2020-03-26 796 struct vhost_dev *dev;
4c8cf31885f69e8 Tiwei Bie 2020-03-26 797 struct vhost_virtqueue **vqs;
4c8cf31885f69e8 Tiwei Bie 2020-03-26 798 int nvqs, i, r, opened;
4c8cf31885f69e8 Tiwei Bie 2020-03-26 799
4c8cf31885f69e8 Tiwei Bie 2020-03-26 800 v = container_of(inode->i_cdev, struct vhost_vdpa, cdev);
4c8cf31885f69e8 Tiwei Bie 2020-03-26 801
4c8cf31885f69e8 Tiwei Bie 2020-03-26 802 opened = atomic_cmpxchg(&v->opened, 0, 1);
4c8cf31885f69e8 Tiwei Bie 2020-03-26 803 if (opened)
4c8cf31885f69e8 Tiwei Bie 2020-03-26 804 return -EBUSY;
4c8cf31885f69e8 Tiwei Bie 2020-03-26 805
4c8cf31885f69e8 Tiwei Bie 2020-03-26 806 nvqs = v->nvqs;
4c8cf31885f69e8 Tiwei Bie 2020-03-26 807 vhost_vdpa_reset(v);
4c8cf31885f69e8 Tiwei Bie 2020-03-26 808
4c8cf31885f69e8 Tiwei Bie 2020-03-26 809 vqs = kmalloc_array(nvqs, sizeof(*vqs), GFP_KERNEL);
4c8cf31885f69e8 Tiwei Bie 2020-03-26 810 if (!vqs) {
4c8cf31885f69e8 Tiwei Bie 2020-03-26 811 r = -ENOMEM;
4c8cf31885f69e8 Tiwei Bie 2020-03-26 812 goto err;
4c8cf31885f69e8 Tiwei Bie 2020-03-26 813 }
4c8cf31885f69e8 Tiwei Bie 2020-03-26 814
4c8cf31885f69e8 Tiwei Bie 2020-03-26 815 dev = &v->vdev;
4c8cf31885f69e8 Tiwei Bie 2020-03-26 816 for (i = 0; i < nvqs; i++) {
4c8cf31885f69e8 Tiwei Bie 2020-03-26 817 vqs[i] = &v->vqs[i];
4c8cf31885f69e8 Tiwei Bie 2020-03-26 818 vqs[i]->handle_kick = handle_vq_kick;
4c8cf31885f69e8 Tiwei Bie 2020-03-26 819 }
7dc4d1082d406f3 Mike Christie 2020-10-07 820 if (vhost_dev_init(dev, vqs, nvqs, 0, 0, 0, false,
7dc4d1082d406f3 Mike Christie 2020-10-07 821 vhost_vdpa_process_iotlb_msg))
7dc4d1082d406f3 Mike Christie 2020-10-07 822 goto err_dev_init;
"r" not set on this error path.
4c8cf31885f69e8 Tiwei Bie 2020-03-26 823
4c8cf31885f69e8 Tiwei Bie 2020-03-26 824 dev->iotlb = vhost_iotlb_alloc(0, 0);
4c8cf31885f69e8 Tiwei Bie 2020-03-26 825 if (!dev->iotlb) {
4c8cf31885f69e8 Tiwei Bie 2020-03-26 826 r = -ENOMEM;
4c8cf31885f69e8 Tiwei Bie 2020-03-26 827 goto err_init_iotlb;
4c8cf31885f69e8 Tiwei Bie 2020-03-26 828 }
4c8cf31885f69e8 Tiwei Bie 2020-03-26 829
4c8cf31885f69e8 Tiwei Bie 2020-03-26 830 r = vhost_vdpa_alloc_domain(v);
4c8cf31885f69e8 Tiwei Bie 2020-03-26 831 if (r)
4c8cf31885f69e8 Tiwei Bie 2020-03-26 832 goto err_init_iotlb;
4c8cf31885f69e8 Tiwei Bie 2020-03-26 833
4c8cf31885f69e8 Tiwei Bie 2020-03-26 834 filep->private_data = v;
4c8cf31885f69e8 Tiwei Bie 2020-03-26 835
4c8cf31885f69e8 Tiwei Bie 2020-03-26 836 return 0;
4c8cf31885f69e8 Tiwei Bie 2020-03-26 837
4c8cf31885f69e8 Tiwei Bie 2020-03-26 838 err_init_iotlb:
4c8cf31885f69e8 Tiwei Bie 2020-03-26 839 vhost_dev_cleanup(&v->vdev);
7dc4d1082d406f3 Mike Christie 2020-10-07 840 err_dev_init:
37787e9f81e2e58 Mike Christie 2020-09-21 841 kfree(vqs);
4c8cf31885f69e8 Tiwei Bie 2020-03-26 842 err:
4c8cf31885f69e8 Tiwei Bie 2020-03-26 843 atomic_dec(&v->opened);
4c8cf31885f69e8 Tiwei Bie 2020-03-26 @844 return r;
4c8cf31885f69e8 Tiwei Bie 2020-03-26 845 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41419 bytes --]
[-- Attachment #3: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 3+ messages in thread