* Re: [PATCH] drm: remove unneeded break
[not found] <20201019163115.25814-1-trix@redhat.com>
@ 2020-10-19 17:06 ` Sam Ravnborg
2020-11-08 17:59 ` Sam Ravnborg
0 siblings, 1 reply; 2+ messages in thread
From: Sam Ravnborg @ 2020-10-19 17:06 UTC (permalink / raw)
To: trix
Cc: tzimmermann, airlied, nouveau, gustavoars, dri-devel,
linux-kernel, daniel, spice-devel, airlied, virtualization,
bskeggs
Hi Tom
On Mon, Oct 19, 2020 at 09:31:15AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return or break
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Looks good and builds with no warnings.
One of the diffs made me - "oh this looks wrong". But after I looked again
it was right and the resulting code is more readable - so good.
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Was tempted to just apply to drm-misc-next but will give others the
opportunity to chime in.
Sam
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: remove unneeded break
2020-10-19 17:06 ` [PATCH] drm: remove unneeded break Sam Ravnborg
@ 2020-11-08 17:59 ` Sam Ravnborg
0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2020-11-08 17:59 UTC (permalink / raw)
To: trix
Cc: airlied, nouveau, gustavoars, dri-devel, linux-kernel,
tzimmermann, airlied, spice-devel, virtualization, bskeggs
Hi Tom
On Mon, Oct 19, 2020 at 07:06:41PM +0200, Sam Ravnborg wrote:
> Hi Tom
> On Mon, Oct 19, 2020 at 09:31:15AM -0700, trix@redhat.com wrote:
> > From: Tom Rix <trix@redhat.com>
> >
> > A break is not needed if it is preceded by a return or break
> >
> > Signed-off-by: Tom Rix <trix@redhat.com>
>
> Looks good and builds with no warnings.
>
> One of the diffs made me - "oh this looks wrong". But after I looked again
> it was right and the resulting code is more readable - so good.
>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> Was tempted to just apply to drm-misc-next but will give others the
> opportunity to chime in.
Thanks.
Now applied to drm-misc-next - will show up in -next in a week or so.
Sam
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-08 17:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20201019163115.25814-1-trix@redhat.com>
2020-10-19 17:06 ` [PATCH] drm: remove unneeded break Sam Ravnborg
2020-11-08 17:59 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).