From: Christoph Hellwig <hch@infradead.org>
To: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Arnd Bergmann <arnd@arndb.de>, Amit Shah <amit@kernel.org>,
Alexander Lobakin <alobakin@pm.me>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"linux-remoteproc@vger.kernel.org"
<linux-remoteproc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Christoph Hellwig <hch@infradead.org>, Suman Anna <s-anna@ti.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH virtio] virtio: virtio_console: fix DMA memory allocation for rproc serial
Date: Tue, 17 Nov 2020 14:02:30 +0000 [thread overview]
Message-ID: <20201117140230.GA30567@infradead.org> (raw)
In-Reply-To: <79d2eb78-caad-9c0d-e130-51e628cedaaa@st.com>
On Tue, Nov 17, 2020 at 03:00:32PM +0100, Arnaud POULIQUEN wrote:
> The dma_declare_coherent_memory allows to associate vdev0buffer memory region
> to the remoteproc virtio device (vdev parent). This region is used to allocated
> the rpmsg buffers.
> The memory for the rpmsg buffer is allocated by the rpmsg_virtio device in
> rpmsg_virtio_bus[1]. The size depends on the total size needed for the rpmsg
> buffers.
>
> The vrings are allocated directly by the remoteproc device.
Weird. I thought virtio was pretty strict in not allowing diret DMA
API usage in drivers to support the legacy no-mapping case.
Either way, the point stands: if you want these magic buffers handed
out to specific rpmsg instances I think not having to detour through the
DMA API is going to make everyones life easier.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-11-17 14:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AOKowLclCbOCKxyiJ71WeNyuAAj2q8EUtxrXbyky5E@cp7-web-042.plabs.ch>
2020-11-05 3:10 ` [PATCH virtio] virtio: virtio_console: fix DMA memory allocation for rproc serial Jason Wang
[not found] ` <aXBO8lWEART2MNuWacIKln3qh6wttCtF2oUd7vthkNU@cp3-web-012.plabs.ch>
2020-11-09 6:04 ` Jason Wang
2020-11-16 9:19 ` Christoph Hellwig
2020-11-16 9:51 ` Michael S. Tsirkin
2020-11-16 16:27 ` Christoph Hellwig
2020-11-16 10:46 ` Arnaud POULIQUEN
2020-11-16 16:28 ` Christoph Hellwig
2020-11-16 16:39 ` Christoph Hellwig
2020-11-17 14:00 ` Arnaud POULIQUEN
2020-11-17 14:02 ` Christoph Hellwig [this message]
2020-11-18 10:16 ` Michael S. Tsirkin
2020-11-16 12:25 ` Michael S. Tsirkin
[not found] ` <u9RJBckNwnezQttAPrOyEqDYKu0rnhedUZYGpaS83qg@cp3-web-024.plabs.ch>
2020-11-16 13:12 ` Michael S. Tsirkin
2020-11-16 16:30 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201117140230.GA30567@infradead.org \
--to=hch@infradead.org \
--cc=alobakin@pm.me \
--cc=amit@kernel.org \
--cc=arnaud.pouliquen@st.com \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mst@redhat.com \
--cc=ohad@wizery.com \
--cc=s-anna@ti.com \
--cc=stable@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).