From: Christoph Hellwig <hch@lst.de>
To: Martin Radev <martin.b.radev@gmail.com>
Cc: thomas.lendacky@amd.com, file@sect.tu-berlin.de,
robert.buhren@sect.tu-berlin.de, kvm@vger.kernel.org,
konrad.wilk@oracle.com, mathias.morbitzer@aisec.fraunhofer.de,
joro@8bytes.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
iommu@lists.linux-foundation.org, robin.murphy@arm.com,
hch@lst.de, kirill.shutemov@linux.intel.com,
m.szyprowski@samsung.com
Subject: Re: [PATCH] swiotlb: Validate bounce size in the sync/unmap path
Date: Wed, 13 Jan 2021 12:30:17 +0100 [thread overview]
Message-ID: <20210113113017.GA28106@lst.de> (raw)
In-Reply-To: <X/27MSbfDGCY9WZu@martin>
On Tue, Jan 12, 2021 at 04:07:29PM +0100, Martin Radev wrote:
> The size of the buffer being bounced is not checked if it happens
> to be larger than the size of the mapped buffer. Because the size
> can be controlled by a device, as it's the case with virtio devices,
> this can lead to memory corruption.
>
I'm really worried about all these hodge podge hacks for not trusted
hypervisors in the I/O stack. Instead of trying to harden protocols
that are fundamentally not designed for this, how about instead coming
up with a new paravirtualized I/O interface that is specifically
designed for use with an untrusted hypervisor from the start?
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next parent reply other threads:[~2021-01-13 11:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <X/27MSbfDGCY9WZu@martin>
2021-01-13 11:30 ` Christoph Hellwig [this message]
[not found] ` <YAV0uhfkimXn1izW@martin>
2021-01-18 15:14 ` [PATCH] swiotlb: Validate bounce size in the sync/unmap path Konrad Rzeszutek Wilk
[not found] ` <YA8O/2qBBzZo5hi7@martin>
2021-02-02 16:37 ` Konrad Rzeszutek Wilk
2021-02-02 22:34 ` Tom Lendacky
2021-02-02 23:13 ` Konrad Rzeszutek Wilk
2021-02-03 12:49 ` Christoph Hellwig
2021-02-03 19:36 ` Konrad Rzeszutek Wilk
2021-02-05 17:58 ` Christoph Hellwig
2021-02-08 17:14 ` Konrad Rzeszutek Wilk
2021-02-09 8:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113113017.GA28106@lst.de \
--to=hch@lst.de \
--cc=file@sect.tu-berlin.de \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=martin.b.radev@gmail.com \
--cc=mathias.morbitzer@aisec.fraunhofer.de \
--cc=robert.buhren@sect.tu-berlin.de \
--cc=robin.murphy@arm.com \
--cc=thomas.lendacky@amd.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).