From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: willemdebruijn.kernel@gmail.com, netdev@vger.kernel.org,
wangyunjian <wangyunjian@huawei.com>,
jerry.lilijun@huawei.com,
virtualization@lists.linux-foundation.org, xudingke@huawei.com,
brian.huangbin@huawei.com, chenchanghu@huawei.com
Subject: Re: [PATCH net-next v7] vhost_net: avoid tx queue stuck when sendmsg fails
Date: Tue, 19 Jan 2021 04:56:59 -0500 [thread overview]
Message-ID: <20210119045607-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210118143329.08cc14a6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Mon, Jan 18, 2021 at 02:33:29PM -0800, Jakub Kicinski wrote:
> On Fri, 15 Jan 2021 12:46:20 +0800 wangyunjian wrote:
> > From: Yunjian Wang <wangyunjian@huawei.com>
> >
> > Currently the driver doesn't drop a packet which can't be sent by tun
> > (e.g bad packet). In this case, the driver will always process the
> > same packet lead to the tx queue stuck.
> >
> > To fix this issue:
> > 1. in the case of persistent failure (e.g bad packet), the driver
> > can skip this descriptor by ignoring the error.
> > 2. in the case of transient failure (e.g -ENOBUFS, -EAGAIN and -ENOMEM),
> > the driver schedules the worker to try again.
> >
> > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>
> Michael, LMK if you want to have a closer look otherwise I'll apply
> tomorrow.
Thanks for the reminder. Acked.
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
prev parent reply other threads:[~2021-01-19 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1610685980-38608-1-git-send-email-wangyunjian@huawei.com>
2021-01-15 6:05 ` [PATCH net-next v7] vhost_net: avoid tx queue stuck when sendmsg fails Jason Wang
2021-01-15 18:15 ` Willem de Bruijn
2021-01-19 9:55 ` Michael S. Tsirkin
[not found] ` <20210118143329.08cc14a6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
2021-01-19 9:56 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119045607-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=brian.huangbin@huawei.com \
--cc=chenchanghu@huawei.com \
--cc=jerry.lilijun@huawei.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wangyunjian@huawei.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=xudingke@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox