From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93BCBC433DB for ; Wed, 20 Jan 2021 11:33:15 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BFF122AAA for ; Wed, 20 Jan 2021 11:33:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BFF122AAA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 85CFF8705B; Wed, 20 Jan 2021 11:33:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RYWn8B+rYYS6; Wed, 20 Jan 2021 11:33:13 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 6622B87046; Wed, 20 Jan 2021 11:33:13 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2B98FC088B; Wed, 20 Jan 2021 11:33:13 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 103A3C013A for ; Wed, 20 Jan 2021 11:33:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id E30A6203DC for ; Wed, 20 Jan 2021 11:33:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jP6KFlOtVGuq for ; Wed, 20 Jan 2021 11:33:10 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by silver.osuosl.org (Postfix) with ESMTPS id 5E224203D5 for ; Wed, 20 Jan 2021 11:33:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611142387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pFGGWQjriPthIYfyi3X3sOv+nCS3Pi6CkQN1y+wI4Fk=; b=FC/3g5Pp6QJbg0nD7+lVlHHkibyhibzysxm2MYHa68cJxDO2b+IOPHv07AjuaCKmxugRQB KXP10OYKvIZmSGUbJVC15bIY2Akq2JXzDnyZbMb24wqWl5EJxJFjIagvak3IAUYyt700QE fLPdRvUJw36rDF7bAMffTivXOBgIgXs= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-433-Ru53TD4lNRO_ucoeKB5JbA-1; Wed, 20 Jan 2021 06:33:05 -0500 X-MC-Unique: Ru53TD4lNRO_ucoeKB5JbA-1 Received: by mail-wr1-f72.google.com with SMTP id w5so11194308wrl.9 for ; Wed, 20 Jan 2021 03:33:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pFGGWQjriPthIYfyi3X3sOv+nCS3Pi6CkQN1y+wI4Fk=; b=uepQzQijLZoviJpWsn0dBysJ4mQfccHkWIwi83CmFJ8Mw/GqvBZSC4dTLLVmvNNUgh eLjRwH/NDmDUFXDJWr8Lppeon4m9w0WT5gFRdT+oU+2T7DzM9W4VY+iPb/SeFHrYr1uu wdHAECoD878Cc9X6YYLl7rgmcXlj8MykFHFtitaqdI850/Ib2GvpCS5zXs+eIDy9FWzW b25y0EVdoN0H1IOOzJOOorVv+/MM0zaRrWV9XRBfrRxa2GSTDhDoeKaqE8+LRocTmaDr dUNQSrOq/rqU2DQZ46oT3QQXv6ZYbjUQOup/Zhg45gfOjiE/4iWTFnPZIbNpApG2iN9r SJNw== X-Gm-Message-State: AOAM533IGF2Fo1q2BOD8O/Rc/+SGQlDvPOB3t1LXaQ75E7W9AuF18qVI GILxM266YSDjf/IrStQDUJHwX7Q04AcMyUd9Fyo/XHAQe5GuGr8gVGYG3mJYXWv7GfTNh7g8LV0 ZxPUwOYdZBqNqCuUFGXRFgB1fIqWN/C2np3EMSiKMAA== X-Received: by 2002:adf:f78e:: with SMTP id q14mr8804240wrp.320.1611142384134; Wed, 20 Jan 2021 03:33:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJxpAzKVhVIbT4hcSrf3FM2z1FMS/LGB4HGq2jsjXgqDx5dXW8G7egeuMP2ItkYMGP6U/CzXlw== X-Received: by 2002:adf:f78e:: with SMTP id q14mr8804219wrp.320.1611142383943; Wed, 20 Jan 2021 03:33:03 -0800 (PST) Received: from redhat.com (bzq-79-177-39-148.red.bezeqint.net. [79.177.39.148]) by smtp.gmail.com with ESMTPSA id a16sm2548221wrr.89.2021.01.20.03.33.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jan 2021 03:33:03 -0800 (PST) Date: Wed, 20 Jan 2021 06:33:00 -0500 From: "Michael S. Tsirkin" To: David Hildenbrand Subject: Re: [PATCH] virtio-mem: Assign boolean values to a bool variable Message-ID: <20210120063209-mutt-send-email-mst@kernel.org> References: <1611129031-82818-1-git-send-email-abaci-bugfix@linux.alibaba.com> <81a1817d-a1f5-dfca-550c-3e3f62cf3a9d@redhat.com> <20210120045736-mutt-send-email-mst@kernel.org> <20210120060301-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: Tian Tao , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Jiapeng Zhong X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Wed, Jan 20, 2021 at 12:14:14PM +0100, David Hildenbrand wrote: > On 20.01.21 12:03, Michael S. Tsirkin wrote: > > On Wed, Jan 20, 2021 at 11:04:18AM +0100, David Hildenbrand wrote: > >> On 20.01.21 10:57, Michael S. Tsirkin wrote: > >>> On Wed, Jan 20, 2021 at 10:40:37AM +0100, David Hildenbrand wrote: > >>>> On 20.01.21 08:50, Jiapeng Zhong wrote: > >>>>> Fix the following coccicheck warnings: > >>>>> > >>>>> ./drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment > >>>>> of 0/1 to bool variable. > >>>>> > >>>>> Reported-by: Abaci Robot > >>>>> Signed-off-by: Jiapeng Zhong > >>>>> --- > >>>>> drivers/virtio/virtio_mem.c | 2 +- > >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>>> > >>>>> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c > >>>>> index 9fc9ec4..85a272c 100644 > >>>>> --- a/drivers/virtio/virtio_mem.c > >>>>> +++ b/drivers/virtio/virtio_mem.c > >>>>> @@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev) > >>>>> * actually in use (e.g., trying to reload the driver). > >>>>> */ > >>>>> if (vm->plugged_size) { > >>>>> - vm->unplug_all_required = 1; > >>>>> + vm->unplug_all_required = true; > >>>>> dev_info(&vm->vdev->dev, "unplugging all memory is required\n"); > >>>>> } > >>>>> > >>>>> > >>>> > >>>> Hi, > >>>> > >>>> we already had a fix on the list for quite a while: > >>>> > >>>> https://lkml.kernel.org/r/1609233239-60313-1-git-send-email-tiantao6@hisilicon.com > >>> > >>> Can't find that one. > >> > >> Looks like it was only on virtualization@ and a couple of people on cc. > >> > >> https://lists.linuxfoundation.org/pipermail/virtualization/2020-December/051662.html > >> > >> Interestingly, I cannot find the follow-up ("[PATCH] virtio-mem: use > >> boolean value when setting vm->unplug_all_required") in the mailing list > >> archives, even though it has virtualization@ on cc. > > > > > > Unsurprising that I didn't merge it then ;) > > Well, you were on cc ;) Hmm true. Found it now. > > Want to send your ack on this one? > > Sure > > Acked-by: David Hildenbrand Added yours and the original Signed-off-by. Thanks! > > -- > Thanks, > > David / dhildenb _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization