From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: shahafs@mellanox.com, lulu@redhat.com, rdunlap@infradead.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH V3 18/19] virtio_vdpa: don't warn when fail to disable vq
Date: Fri, 5 Feb 2021 10:24:59 -0500 [thread overview]
Message-ID: <20210205102442-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210104065503.199631-19-jasowang@redhat.com>
On Mon, Jan 04, 2021 at 02:55:02PM +0800, Jason Wang wrote:
> There's no guarantee that the device can disable a specific virtqueue
> through set_vq_ready(). One example is the modern virtio-pci
> device. So this patch removes the warning.
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Do we need the read as a kind of flush though?
> ---
> drivers/virtio/virtio_vdpa.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c
> index 4a9ddb44b2a7..e28acf482e0c 100644
> --- a/drivers/virtio/virtio_vdpa.c
> +++ b/drivers/virtio/virtio_vdpa.c
> @@ -225,9 +225,8 @@ static void virtio_vdpa_del_vq(struct virtqueue *vq)
> list_del(&info->node);
> spin_unlock_irqrestore(&vd_dev->lock, flags);
>
> - /* Select and deactivate the queue */
> + /* Select and deactivate the queue (best effort) */
> ops->set_vq_ready(vdpa, index, 0);
> - WARN_ON(ops->get_vq_ready(vdpa, index));
>
> vring_del_virtqueue(vq);
>
> --
> 2.25.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-02-05 15:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 6:54 [PATCH V3 00/19] vDPA driver for virtio-pci device Jason Wang
2021-01-04 6:54 ` [PATCH V3 01/19] virtio-pci: do not access iomem via struct virtio_pci_device directly Jason Wang
2021-01-04 6:54 ` [PATCH V3 02/19] virtio-pci: split out modern device Jason Wang
2021-01-04 6:54 ` [PATCH V3 03/19] virtio-pci-modern: factor out modern device initialization logic Jason Wang
2021-01-04 6:54 ` [PATCH V3 04/19] virtio-pci-modern: introduce vp_modern_remove() Jason Wang
2021-01-04 6:54 ` [PATCH V3 05/19] virtio-pci-modern: introduce helper to set config vector Jason Wang
2021-01-04 6:54 ` [PATCH V3 06/19] virtio-pci-modern: introduce helpers for setting and getting status Jason Wang
2021-01-04 6:54 ` [PATCH V3 07/19] virtio-pci-modern: introduce helpers for setting and getting features Jason Wang
2021-01-04 6:54 ` [PATCH V3 08/19] virtio-pci-modern: introduce vp_modern_generation() Jason Wang
2021-01-04 6:54 ` [PATCH V3 09/19] virtio-pci-modern: introduce vp_modern_set_queue_vector() Jason Wang
2021-01-04 6:54 ` [PATCH V3 10/19] virtio-pci-modern: introduce vp_modern_queue_address() Jason Wang
2021-01-04 6:54 ` [PATCH V3 11/19] virtio-pci-modern: introduce helper to set/get queue_enable Jason Wang
2021-01-04 6:54 ` [PATCH V3 12/19] virtio-pci-modern: introduce helper for setting/geting queue size Jason Wang
2021-01-04 6:54 ` [PATCH V3 13/19] virtio-pci-modern: introduce helper for getting queue nums Jason Wang
2021-01-04 6:54 ` [PATCH V3 14/19] virtio-pci-modern: introduce helper to get notification offset Jason Wang
2021-01-04 6:54 ` [PATCH V3 15/19] virito-pci-modern: rename map_capability() to vp_modern_map_capability() Jason Wang
2021-01-04 6:55 ` [PATCH V3 16/19] virtio-pci: introduce modern device module Jason Wang
2021-02-05 15:34 ` Michael S. Tsirkin
2021-02-08 5:42 ` Jason Wang
2021-02-08 12:04 ` Michael S. Tsirkin
[not found] ` <fe639f0f-d639-3c3c-e297-042127788aca@redhat.com>
2021-02-09 9:23 ` Michael S. Tsirkin
[not found] ` <CA+G9fYteUN=s5Mp+BhdMPZt96B3qDa+2HwudmWgEmmrDELLPdw@mail.gmail.com>
2021-02-10 4:38 ` Jason Wang
[not found] ` <20210209091916-mutt-send-email-mst@kernel.org>
2021-02-10 4:44 ` Jason Wang
2021-02-10 12:35 ` Michael S. Tsirkin
2021-02-18 5:49 ` Jason Wang
2021-02-12 20:14 ` Guenter Roeck
2021-02-19 8:31 ` Jason Wang
2021-01-04 6:55 ` [PATCH V3 17/19] vdpa: set the virtqueue num during register Jason Wang
2021-02-05 15:27 ` Michael S. Tsirkin
2021-02-08 4:16 ` Jason Wang
2021-01-04 6:55 ` [PATCH V3 18/19] virtio_vdpa: don't warn when fail to disable vq Jason Wang
2021-02-05 15:24 ` Michael S. Tsirkin [this message]
2021-02-08 4:15 ` Jason Wang
2021-01-04 6:55 ` [PATCH V3 19/19] vdpa: introduce virtio pci driver Jason Wang
2021-02-02 3:53 ` [PATCH V3 00/19] vDPA driver for virtio-pci device Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205102442-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=rdunlap@infradead.org \
--cc=shahafs@mellanox.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).