From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC830C433E0 for ; Wed, 10 Feb 2021 08:44:30 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 766E664E32 for ; Wed, 10 Feb 2021 08:44:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 766E664E32 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 24CFF8347D; Wed, 10 Feb 2021 08:44:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HkNMuwJzUvz2; Wed, 10 Feb 2021 08:44:29 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 6388883C00; Wed, 10 Feb 2021 08:44:29 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 389E7C0174; Wed, 10 Feb 2021 08:44:29 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 92381C013A for ; Wed, 10 Feb 2021 08:44:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 802E483C00 for ; Wed, 10 Feb 2021 08:44:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AFKaSKR8qFje for ; Wed, 10 Feb 2021 08:44:26 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by whitealder.osuosl.org (Postfix) with ESMTPS id E55D08347D for ; Wed, 10 Feb 2021 08:44:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=U1BKN3rsCzUiXJC1oe+xxe/ch8raroLfRcCRmI+lPmc=; b=XvqHlN5NIpj3xl6J+TqXD3YNxu XO6fUcydTCSufFLJl9tYudCYSn3AZIbJfzKZOSnjalt2CaNozqO/WDiwy3OpJTdLallfXBkn9aj5n nae7MvB4m7WO0G0/1uuxmXM6fQu7qJyHlJ3NmK518kiY6WZJpowOsFilcFvohSIO5al5DG/76QQiL i8E9iU1y0eJJQ+F+CJHvciw65uhsgjpb0lxtT56Wnn3An6lUBq05EYdAo3rbL82s3+owqvSChGBpT o2aQ2oJHkmaYn9wWxY9+omT3ZBwiErI23dfOkkyPvk9ZWdDlL63aad3GXVbuXgn40Ca4KqcJOkCq6 zkO1DBRQ==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l9l6d-008bBr-LW; Wed, 10 Feb 2021 08:44:16 +0000 Date: Wed, 10 Feb 2021 08:44:15 +0000 From: Christoph Hellwig To: Mike Christie Subject: Re: [PATCH 12/13] target, vhost-scsi: don't switch cpus on completion Message-ID: <20210210084415.GF2045726@infradead.org> References: <20210209123845.4856-1-michael.christie@oracle.com> <20210209123845.4856-13-michael.christie@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210209123845.4856-13-michael.christie@oracle.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Cc: loberman@redhat.com, Chaitanya.Kulkarni@wdc.com, martin.petersen@oracle.com, mst@redhat.com, virtualization@lists.linux-foundation.org, target-devel@vger.kernel.org, stefanha@redhat.com, linux-scsi@vger.kernel.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" > struct se_device *se_dev = se_cmd->se_dev; > - int cpu = se_cmd->cpuid; > + int cpu; > + > + if (se_cmd->se_cmd_flags & SCF_IGNORE_CPUID_COMPL) > + cpu = smp_processor_id(); > + else > + cpu = se_cmd->cpuid; > > target_queue_cmd_work(&se_dev->queues[cpu].cq, se_cmd, cpu, > target_completion_wq); Can't we just use se_cmd->cpuid == WORK_CPU_UNBOUND as the no affinity indicator, which would remove all branches here. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization