From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB7CAC433E0 for ; Wed, 17 Feb 2021 17:59:53 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C4E764E4D for ; Wed, 17 Feb 2021 17:59:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C4E764E4D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id B00A286CB4; Wed, 17 Feb 2021 17:59:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KaXy8r9WQHFX; Wed, 17 Feb 2021 17:59:51 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 93C3A867D0; Wed, 17 Feb 2021 17:59:51 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 61BC8C0174; Wed, 17 Feb 2021 17:59:51 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id A6F8EC013A for ; Wed, 17 Feb 2021 17:59:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id A0D4E8574B for ; Wed, 17 Feb 2021 17:59:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K5M1IrxGhBvk for ; Wed, 17 Feb 2021 17:59:47 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 82DF5845C0 for ; Wed, 17 Feb 2021 17:59:47 +0000 (UTC) Received: from zn.tnic (p200300ec2f05bb00a5a1b5cb6f03bfce.dip0.t-ipconnect.de [IPv6:2003:ec:2f05:bb00:a5a1:b5cb:6f03:bfce]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id ED4941EC0402; Wed, 17 Feb 2021 18:59:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1613584784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=WmuQ8y/fflrvmjf86SX6xiFBOAxGxvoIY9jzq881ltE=; b=VtuqqWV9FksO9bvGEz8s/uGpYsmQhciTMb5Bf5x7ZRbliGBwcMAr4OEUnISJXR69BwU8JS gfteNUD430fYDD5Kj6HzYtes586+ku381MB0OWQ2UpD4sqHIPXR8P3HfmMaEIRoEW+MeMV +StFS37yM89lDHr/vpDza8tR87BZG+M= Date: Wed, 17 Feb 2021 18:59:39 +0100 From: Borislav Petkov To: Joerg Roedel Subject: Re: [PATCH 1/3] x86/sev-es: Introduce from_syscall_gap() helper Message-ID: <20210217175939.GA6479@zn.tnic> References: <20210217120143.6106-1-joro@8bytes.org> <20210217120143.6106-2-joro@8bytes.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210217120143.6106-2-joro@8bytes.org> Cc: kvm@vger.kernel.org, Peter Zijlstra , Dave Hansen , virtualization@lists.linux-foundation.org, Arvind Sankar , hpa@zytor.com, Jiri Slaby , x86@kernel.org, David Rientjes , Martin Radev , Tom Lendacky , Joerg Roedel , Kees Cook , Cfir Cohen , Andy Lutomirski , Dan Williams , Juergen Gross , Mike Stunes , Sean Christopherson , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Masami Hiramatsu , Erdem Aktas X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" I guess subject prefix should be "x86/traps:" but I'll fix that up while applying eventually. On Wed, Feb 17, 2021 at 01:01:41PM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > Introduce a helper to check whether an exception came from the syscall > gap and use it in the SEV-ES code > > Fixes: 315562c9af3d5 ("x86/sev-es: Adjust #VC IST Stack on entering NMI handler") > Cc: stable@vger.kernel.org # 5.10+ > Signed-off-by: Joerg Roedel > --- > arch/x86/include/asm/ptrace.h | 8 ++++++++ > arch/x86/kernel/traps.c | 3 +-- > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/include/asm/ptrace.h b/arch/x86/include/asm/ptrace.h > index d8324a236696..14854b2c4944 100644 > --- a/arch/x86/include/asm/ptrace.h > +++ b/arch/x86/include/asm/ptrace.h > @@ -94,6 +94,8 @@ struct pt_regs { > #include > #endif > > +#include > + > struct cpuinfo_x86; > struct task_struct; > > @@ -175,6 +177,12 @@ static inline bool any_64bit_mode(struct pt_regs *regs) > #ifdef CONFIG_X86_64 > #define current_user_stack_pointer() current_pt_regs()->sp > #define compat_user_stack_pointer() current_pt_regs()->sp > + > +static inline bool from_syscall_gap(struct pt_regs *regs) rip_within_syscall_gap() sounds kinda better to me and it is more readable when you look at it at the usage site: if (rip_within_syscall_gap(regs)) ... -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization